refactor: split updatePlayerInTablist into updateOthersFor and updateForOthers, adjust usages across services, and clean up tablist handling logic

Author: TheBjoRedCraft

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/command/SurfTabCommand.kt

@@ -16,7 +16,7 @@ fun surfTabCommand() = commandTree("surftab") {
             tablistConfiguration.reload()
 
             plugin.proxy.allPlayers.forEach {
-                tablistService.updatePlayerInTablist(it)
+                tablistService.updateOthersFor(it)
             }
 
             executor.sendText {

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/hook/LuckPermsHook.kt

@@ -32,8 +32,6 @@ object LuckPermsHook {
 
     private fun updatePlayerInTablist(user: User) {
         val player = plugin.proxy.getPlayer(user.uniqueId).getOrNull() ?: return
-        tablistService.updatePlayerInTablist(player)
+        tablistService.updateForOthers(player)
     }
-
-
 }

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/service/TablistService.kt

@@ -58,20 +58,32 @@ class VelocityTablistService {
         weight = LuckPermsHook.getWeight(target.uniqueId)
     )
 
-    fun updatePlayerInTablist(player: Player) {
-//        val server = player.currentServer.getOrNull()?.server ?: return
-//
-//        val seenServers = tablistService.getSeenServers(server)
-//        val viewers = seenServers.flatMap { it.playersConnected }.distinct()
-//
-//        viewers.forEach { viewer ->
-//            tablistService.removePlayer(viewer, player.uniqueId)
-//            tablistService.addPlayer(viewer, tablistService.createEntry(player, viewer))
-//        }
-//
-//        tablistService.removePlayer(player, player.uniqueId)
-//        tablistService.addPlayer(player, tablistService.createEntry(player, player))
+    fun updateOthersFor(viewer: Player) {
+        val server = viewer.currentServer.getOrNull()?.server ?: return
+
+        val seenServers = tablistService.getSeenServers(server)
+        val seenPlayers = seenServers.flatMap { it.playersConnected }.distinct()
+            .filterNot { it.uniqueId == viewer.uniqueId }
+
+        seenPlayers.forEach { seen ->
+            tablistService.removePlayer(viewer, seen.uniqueId)
+            tablistService.addPlayer(viewer, tablistService.createEntry(seen))
+        }
+
         // As velocity has no chat session api, we cannot update the tablist entries properly yet. Currently, it will cause the chat validation to fail.
         // [00:21:47] [Render thread/ERROR]: Received chat message from 1c779cb1-3860-4e23-9cac-7f160b2acc61, but they have no chat session initialized and secure chat is enforced
     }
+
+    fun updateForOthers(toUpdate: Player) {
+        val server = toUpdate.currentServer.getOrNull()?.server ?: return
+
+        val seenServers = tablistService.getSeenServers(server)
+        val seenPlayers = seenServers.flatMap { it.playersConnected }.distinct()
+            .filterNot { it.uniqueId == toUpdate.uniqueId }
+
+        seenPlayers.forEach { viewer ->
+            tablistService.removePlayer(viewer, toUpdate.uniqueId)
+            tablistService.addPlayer(viewer, tablistService.createEntry(toUpdate))
+        }
+    }
 }