Skip to content

Commit ee0fc27

Browse files
committed
edit: create variables for mechianism, host, and service name
1 parent 6f4e483 commit ee0fc27

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

fluss-common/src/test/java/com/alibaba/fluss/security/auth/sasl/gssapi/GssapiSaslServerTest.java

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,28 @@
1616

1717
package com.alibaba.fluss.security.auth.sasl.gssapi;
1818

19+
import static org.assertj.core.api.Assertions.assertThat;
20+
import static org.mockito.ArgumentMatchers.any;
21+
import static org.mockito.ArgumentMatchers.eq;
22+
import static org.mockito.Mockito.mock;
23+
import static org.mockito.Mockito.mockStatic;
24+
import static org.mockito.Mockito.when;
25+
1926
import com.alibaba.fluss.security.auth.sasl.jaas.LoginManager;
2027
import com.alibaba.fluss.security.auth.sasl.jaas.SaslServerFactory;
2128

2229
import org.junit.jupiter.api.Test;
2330
import org.mockito.MockedStatic;
2431

25-
import javax.security.auth.Subject;
26-
import javax.security.auth.login.AppConfigurationEntry;
27-
import javax.security.sasl.Sasl;
28-
import javax.security.sasl.SaslServer;
29-
3032
import java.security.PrivilegedExceptionAction;
3133
import java.util.Collections;
3234
import java.util.List;
3335
import java.util.Map;
3436

35-
import static org.assertj.core.api.Assertions.assertThat;
36-
import static org.mockito.ArgumentMatchers.any;
37-
import static org.mockito.ArgumentMatchers.eq;
38-
import static org.mockito.Mockito.mock;
39-
import static org.mockito.Mockito.mockStatic;
40-
import static org.mockito.Mockito.when;
37+
import javax.security.auth.Subject;
38+
import javax.security.auth.login.AppConfigurationEntry;
39+
import javax.security.sasl.Sasl;
40+
import javax.security.sasl.SaslServer;
4141

4242
/**
4343
* Unit tests for {@link SaslServerFactory} to verify it can create a SASL server for the mechanism
@@ -48,11 +48,14 @@
4848
* a privileged context.
4949
*/
5050
public class GssapiSaslServerTest {
51+
String mechanism = "GSSAPI";
52+
String service = "fluss";
53+
String host = "localhost";
5154

5255
@Test
5356
public void testCreateSaslServerForGssapi() throws Exception {
5457

55-
// Mock the dependencies: LoginManager, SaslServer, and Subject
58+
// Mock the dependencies: LoginManager, SaslServer
5659
LoginManager mockLoginManager = mock(LoginManager.class);
5760
SaslServer mockSaslServer = mock(SaslServer.class);
5861

@@ -82,17 +85,13 @@ public void testCreateSaslServerForGssapi() throws Exception {
8285
saslMock.when(
8386
() ->
8487
Sasl.createSaslServer(
85-
eq("GSSAPI"),
86-
eq("fluss"),
87-
eq("localhost"),
88-
eq(props),
89-
any()))
88+
eq(mechanism), eq(service), eq(host), eq(props), any()))
9089
.thenReturn(mockSaslServer);
9190

9291
// Call SaslServerFactory to create a SASL server for "GSSAPI" and verify the result
9392
SaslServer saslServer =
9493
SaslServerFactory.createSaslServer(
95-
"GSSAPI", "localhost", props, mockLoginManager, jaasConfig);
94+
mechanism, host, props, mockLoginManager, jaasConfig);
9695

9796
assertThat(saslServer).isNotNull();
9897
assertThat(saslServer).isEqualTo(mockSaslServer);

0 commit comments

Comments
 (0)