Fix disabling 3rd party links

Closes #49

Author: SMillerDev

src/PHPDraft/Out/HTML/default.phtml

@@ -153,7 +153,7 @@ use Enjoy\HttpStatusCode\Statuscodes;
                                    data-content="<textarea rows='8' cols='75'><?= $transition->get_curl_command($this->base_data['HOST']); ?></textarea>">
                                     <span class="glyphicon glyphicon-copy"></span>
                                 </a>
-                                <?php if (defined('THIRD_PARTY_ALLOWED') && THIRD_PARTY_ALLOWED): ?>
+                                <?php if (THIRD_PARTY_ALLOWED): ?>
                                 <a class="btn btn-default hurl"
                                    role="button"
                                    title="Try request"

src/PHPDraft/Out/HTML/material.phtml

@@ -192,7 +192,7 @@ use Enjoy\HttpStatusCode\Statuscodes;
                                 </div>
                             </div>
                             <div class="mdl-card__menu">
-                                <?php if (defined('THIRD_PARTY_ALLOWED') && THIRD_PARTY_ALLOWED): ?>
+                                <?php if (THIRD_PARTY_ALLOWED): ?>
                                 <a href="<?= $transition->get_hurl_link($this->base_data['HOST']); ?>" target="_blank" role="button" class="mdl-button mdl-button mdl-button--icon mdl-js-button mdl-js-ripple-effect">
                                     <i class="material-icons">play_arrow</i>
                                 </a>

src/PHPDraft/Out/UI.php

@@ -43,6 +43,7 @@ class UI
      * @param array $argv Arguments passed
      *
      * @return array results of the invocation
+     * @throws \PHPDraft\Parse\ExecutionException When something failed in execution
      */
     public static function main($argv = [])
     {
@@ -84,10 +85,10 @@ public static function main($argv = [])
         } else {
             $file = $argv[1];
         }
-        if (isset($options['y']) || isset($options['o'])) {
+        define('THIRD_PARTY_ALLOWED', getenv('PHPDRAFT_THIRD_PARTY') !== '0');
+        if ((isset($options['y']) || isset($options['o'])) && THIRD_PARTY_ALLOWED) {
             define('DRAFTER_ONLINE_MODE', 1);
         }
-        define('THIRD_PARTY_ALLOWED', !getenv('PHPDRAFT_THIRD_PARTY'));
 
         $template = (new self())->var_or_default($options['t'], 'default');
         $image    = (new self())->var_or_default($options['i']);

src/PHPDraft/Parse/JsonToHTML.php

@@ -59,6 +59,7 @@ public function __toString()
      * @param string|null $js       JS to load
      *
      * @return TemplateGenerator HTML template to display
+     * @throws \PHPDraft\Parse\ExecutionException As a runtime exception
      */
     public function get_html($template = 'default', $image = NULL, $css = NULL, $js = NULL)
     {