chore: fix PHPUnit 10 compat (#489)

Author: SMillerDev

.gitignore

@@ -1,5 +1,6 @@
 /.idea/
 /.phpintel/
+/tests/.phpunit.cache/**
 /tests/.phpunit.result.cache
 
 # IntelliJ

composer.lock

@@ -53,7 +53,7 @@ public function testSuccessfulParse(string $object, ArrayStructureElement $expec
      *
      * @return array
      */
-    public function parseObjectProvider(): array
+    public static function parseObjectProvider(): array
     {
         $return             = [];
         $base1              = new ArrayStructureElement();

src/PHPDraft/Model/Elements/Tests/ArrayStructureElementTest.php

@@ -70,7 +70,7 @@ public function testStringValue(mixed $value, mixed $string_value): void
      *
      * @return array
      */
-    public function stringValueProvider(): array
+    public static function stringValueProvider(): array
     {
         $return = [];
 
@@ -134,7 +134,7 @@ public function testParseCommon($value, BasicStructureElement $expected_value):
         $this->assertEquals([], $dep);
     }
 
-    public function parseValueProvider(): array
+    public static function parseValueProvider(): array
     {
         $return = [];
 

src/PHPDraft/Model/Elements/Tests/BasicStructureElementTest.php

@@ -141,7 +141,7 @@ public function testSuccessfulParse(string $object, EnumStructureElement $expect
      *
      * @return array
      */
-    public function parseObjectProvider(): array
+    public static function parseObjectProvider(): array
     {
         $value1 = new ElementStructureElement();
         $value1->value = 'item';

src/PHPDraft/Model/Elements/Tests/EnumStructureElementTest.php

@@ -57,7 +57,7 @@ public function testNewInstance(): void
      *
      * @covers \PHPDraft\Model\Elements\ObjectStructureElement::parse
      */
-    public function testSuccesfulParse(string $object, ObjectStructureElement $expected): void
+    public function testSuccessfulParse(string $object, ObjectStructureElement $expected): void
     {
         $dep = [];
         $res = $this->class->parse(json_decode($object), $dep);
@@ -73,7 +73,7 @@ public function testSuccesfulParse(string $object, ObjectStructureElement $expec
      *
      * @return array
      */
-    public function parseObjectProvider(): array
+    public static function parseObjectProvider(): array
     {
         $return             = [];
         $base1              = new ObjectStructureElement();

src/PHPDraft/Model/Elements/Tests/ObjectStructureElementTest.php

@@ -135,7 +135,7 @@ public function testSuccessfulParse(string $object, ObjectStructureElement $expe
      *
      * @return array
      */
-    public function parseObjectProvider(): array
+    public static function parseObjectProvider(): array
     {
         $return             = [];
         $base1              = new RequestBodyElement();

src/PHPDraft/Model/Elements/Tests/RequestBodyElementTest.php

@@ -16,7 +16,7 @@
  * Class CategoryTest
  * @covers \PHPDraft\Model\Category
  */
-class CategoryTest extends HierarchyElementChildTest
+class CategoryTest extends HierarchyElementChildTestBase
 {
     /**
      * Set up
@@ -38,6 +38,23 @@ public function tearDown(): void
         unset($this->reflection);
     }
 
+    /**
+     * Test if the value the class is initialized with is correct
+     * @covers \PHPDraft\Model\HierarchyElement
+     */
+    public function testChildrenSetup(): void
+    {
+        $this->assertSame([], $this->class->children);
+    }
+
+    /**
+     * Test if the value the class is initialized with is correct
+     */
+    public function testSetupCorrectly(): void
+    {
+        $this->assertPropertySame('parent', null);
+    }
+
     /**
      * Test if the value the class is initialized with is correct
      */

src/PHPDraft/Model/Tests/CategoryTest.php

@@ -1,7 +1,7 @@
 <?php
 
 /**
- * This file contains the HierarchyElementChildTest.php
+ * This file contains the HierarchyElementChildTestBase.php
  *
  * @package PHPDraft\Model
  * @author  Sean Molenaar<[email protected]>
@@ -17,7 +17,7 @@
  * Class HierarchyElementChildTest
  * @package PHPDraft\Model\Tests
  */
-class HierarchyElementChildTest extends LunrBaseTest
+abstract class HierarchyElementChildTestBase extends LunrBaseTest
 {
     /**
      * Mock of the parent class
@@ -31,22 +31,4 @@ public function setUp(): void
         $this->parent = $this->getMockBuilder('\PHPDraft\Model\HierarchyElement')
                              ->getMock();
     }
-
-    /**
-     * Test if the value the class is initialized with is correct
-     */
-    public function testChildrenSetup(): void
-    {
-        $this->assertSame([], $this->class->children);
-    }
-
-    /**
-     * Test if the value the class is initialized with is correct
-     */
-    public function testSetupCorrectly(): void
-    {
-        $property = $this->reflection->getProperty('parent');
-        $property->setAccessible(true);
-        $this->assertNull($property->getValue($this->class));
-    }
 }

src/PHPDraft/Model/Tests/HierarchyElementChildTest.php renamed to src/PHPDraft/Model/Tests/HierarchyElementChildTestBase.php

@@ -16,36 +16,57 @@
  */
 class ObjectElementTest extends LunrBaseTest
 {
+    /**
+     * @covers \PHPDraft\Model\Elements\ObjectStructureElement
+     */
     public function testKeySetup(): void
     {
         $this->assertSame(null, $this->class->key);
     }
 
+    /**
+     * @covers \PHPDraft\Model\Elements\ObjectStructureElement
+     */
     public function testTypeSetup(): void
     {
         $this->assertSame(null, $this->class->type);
     }
 
+    /**
+     * @covers \PHPDraft\Model\Elements\ObjectStructureElement
+     */
     public function testDescriptionSetup(): void
     {
         $this->assertSame(null, $this->class->description);
     }
 
+    /**
+     * @covers \PHPDraft\Model\Elements\ObjectStructureElement
+     */
     public function testElementSetup(): void
     {
         $this->assertSame(null, $this->class->element);
     }
 
+    /**
+     * @covers \PHPDraft\Model\Elements\ObjectStructureElement
+     */
     public function testValueSetup(): void
     {
         $this->assertSame(null, $this->class->value);
     }
 
+    /**
+     * @covers \PHPDraft\Model\Elements\ObjectStructureElement
+     */
     public function testStatusSetup(): void
     {
-        $this->assertSame('', $this->class->status);
+        $this->assertSame(null, $this->class->status);
     }
 
+    /**
+     * @covers \PHPDraft\Model\Elements\ObjectStructureElement
+     */
     public function testDepsSetup(): void
     {
         $this->assertSame(null, $this->class->deps);