A call to a non-existent constructor soci::details::into_type in soci::into

[Innokentiy-Alaytsev]

There seems to be a problem with soci::details;:into_type constructor call at https://github.com/SOCI/soci/blob/master/include/soci/into.h#L67. I've looked through the code for soci::into_type and didn't find a matching constructor. The simple test code fails as expected with a call to an overloaded function that failed to convert all the argument types:

    soci::session:: sql = ...;

    char s[ 100 ];

    sql << "select * from test", soci::into (s[ 0 ], sizeof (s));

[vadz]

Yes, indeed, the following diff can be used to reproduce the problem:

diff --git a/tests/common/test-common.cpp b/tests/common/test-common.cpp
index ffe9e1c8..0fcd1d6e 100644
--- a/tests/common/test-common.cpp
+++ b/tests/common/test-common.cpp
@@ -142,6 +142,16 @@ TEST_CASE_METHOD(common_tests, "Use and into", "[core][into]")
         CHECK(str == "Hello, SOCI!");
     }
 
+    SECTION("Round trip works for C string")
+    {
+        char helloSOCI[] = "Hello, SOCI!";
+        sql << "insert into soci_test(str) values(:s)", use(helloSOCI);
+
+        char buf[16];
+        sql << "select str from soci_test", into(buf, sizeof(buf));
+        CHECK(std::string(buf) == "Hello, SOCI!");
+    }
+
     SECTION("Round trip works for short")
     {
         short three(3);

I don't know if this worked before and got broken or never worked in the first place. I also have limited (none, to be honest) use for C strings in my own code, so I don't plan to fix this, but we probably should at least remove the into() overload to avoid confusion.

Of course, if somebody is motivated to allow this to compile and work, please don't hesitate to submit PRs doing this.

[Innokentiy-Alaytsev]

I don't have a use for C-strings either. I stumbled upon this during an unrelated investigation.