feat: PRSDM-10268 embed themes in binary

Author: Quantumplate

Dockerfile.test

@@ -5,14 +5,14 @@
 FROM golang:1.25-alpine AS builder
 
 # Install build dependencies
-RUN apk add --no-cache git gcc g++ musl-dev
+RUN apk add --no-cache git gcc g++ musl-dev make
 
 # Copy source code
 WORKDIR /build
 COPY . .
 
-# Build presidium binary
-RUN go build -tags extended -o presidium .
+# Build presidium binary (prepare-themes renames go.mod files so they can be embedded)
+RUN make prepare-themes && go build -tags extended -o presidium .
 
 # Stage 2: Test without network access
 FROM golang:1.25-alpine AS test

Makefile

@@ -6,6 +6,11 @@ DOCSDIR=docs
 help: ## Display available targets
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "  %-18s %s\n", $$1, $$2}'
 
+update-themes: ## Update theme submodules to their latest versions
+	@echo "Updating theme submodules to latest..."
+	@git submodule update --remote themes/presidium-styling-base themes/presidium-layouts-base themes/presidium-layouts-blog
+	@echo "Theme submodules updated."
+
 prepare-themes: ## Prepare themes for embedding (rename go.mod to make embeddable)
 	@echo "Preparing themes for embedding..."
 	@for theme in themes/presidium-*; do \
@@ -33,17 +38,17 @@ restore-themes: ## Restore theme go.mod files to original names
 	done
 
 build: prepare-themes ## Build the presidium binary
-	go build -tags extended -o $(FILENAME) .
+	go build -tags extended -o $(FILENAME) . ; status=$$? ; $(MAKE) restore-themes ; exit $$status
 
 test: prepare-themes ## Run tests with coverage
 	@mkdir -p reports
-	go test -race -timeout 120s ./... -coverprofile=reports/tests-cov.out
+	go test -race -timeout 120s ./... -coverprofile=reports/tests-cov.out ; status=$$? ; $(MAKE) restore-themes ; exit $$status
 
 fmt: ## Format Go source files
 	go fmt ./...
 
 vet: prepare-themes ## Run go vet
-	go vet ./...
+	go vet ./... ; status=$$? ; $(MAKE) restore-themes ; exit $$status
 
 tidy: ## Tidy and verify module dependencies
 	go mod tidy && go mod verify
@@ -55,13 +60,12 @@ coverage_report: ## Open coverage report in browser
 	@go tool cover -html=reports/tests-cov.out
 
 dist: prepare-themes ## Build distribution binary
-	mkdir -p "dist"
-	go build -trimpath -o "dist/presidium" --tags extended
+	mkdir -p "dist" && go build -trimpath -o "dist/presidium" --tags extended ; status=$$? ; $(MAKE) restore-themes ; exit $$status
 
 checks: clean tidy fmt vet lint test build
 
 serve-docs:
 	cd $(DOCSDIR) && make serve
 
 lint: prepare-themes ## Run golangci-lint
-	golangci-lint run --timeout 10m
+	golangci-lint run --timeout 10m ; status=$$? ; $(MAKE) restore-themes ; exit $$status

pkg/domain/service/hugo/hugo_test.go

@@ -57,9 +57,18 @@ func TestExecute_CleansUpEnvironment(t *testing.T) {
 	// Execute a command that will quickly fail (invalid command)
 	_ = svc.Execute("nonexistent-command-xyz")
 
-	// Check that the environment variable was cleaned up
-	if value, exists := os.LookupEnv(envVarName); exists {
-		t.Errorf("HUGO_MODULE_REPLACEMENTS was not cleaned up, value: %s", value)
+	// Check that the environment variable was cleaned up or restored appropriately
+	value, exists := os.LookupEnv(envVarName)
+	if hadOriginal {
+		if !exists {
+			t.Errorf("HUGO_MODULE_REPLACEMENTS was not restored; expected it to exist with original value %q", originalValue)
+		} else if value != originalValue {
+			t.Errorf("HUGO_MODULE_REPLACEMENTS value was not restored; got %q, want %q", value, originalValue)
+		}
+	} else {
+		if exists {
+			t.Errorf("HUGO_MODULE_REPLACEMENTS was not cleaned up; expected it to be unset, got value: %q", value)
+		}
 	}
 }
 

pkg/domain/service/themes/themes.go

@@ -60,13 +60,14 @@ func findModuleRoot() (string, error) {
 	if err != nil {
 		return "", fmt.Errorf("unable to determine working directory: %w", err)
 	}
+	startDir := dir
 	for {
 		if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
 			return dir, nil
 		}
 		parent := filepath.Dir(dir)
 		if parent == dir {
-			return ".", nil
+			return "", fmt.Errorf("no go.mod found when searching upwards from %s", startDir)
 		}
 		dir = parent
 	}