feat: PRSDM-10368 incl themes in binary PR feedback

Author: Quantumplate

.github/workflows/release.yml

@@ -14,10 +14,13 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
+          submodules: true
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
           go-version: 1.25.x
+      - name: Prepare themes for embedding
+        run: make prepare-themes
       - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v6
         with:

pkg/domain/service/hugo/hugo.go

@@ -5,6 +5,7 @@ import (
 	"os"
 
 	"github.com/SPANDigital/presidium-hugo/pkg/domain/service/themes"
+	"github.com/SPANDigital/presidium-hugo/pkg/filesystem"
 	"github.com/SPANDigital/presidium-hugo/pkg/log"
 	"github.com/gohugoio/hugo/commands"
 )
@@ -36,7 +37,7 @@ func (s Service) Execute(args ...string) error {
 
 	// Ensure cleanup happens regardless of how Hugo execution ends
 	defer func() {
-		os.RemoveAll(tmpDir)
+		_ = filesystem.AFS.RemoveAll(tmpDir)
 		if hadPrevReplacements {
 			os.Setenv("HUGO_MODULE_REPLACEMENTS", prevReplacements)
 		} else {

pkg/domain/service/themes/themes.go

@@ -75,12 +75,12 @@ func findModuleRoot() (string, error) {
 }
 
 // Extract extracts all embedded themes to a temporary directory and returns:
-// - tmpDir: the temporary directory path (caller must clean up with os.RemoveAll)
+// - tmpDir: the temporary directory path (caller must clean up)
 // - replacements: comma-separated string for HUGO_MODULE_REPLACEMENTS env var
 // - err: any error encountered during extraction
 func (s Service) Extract() (tmpDir string, replacements string, err error) {
 	// Create a temporary directory for themes
-	tmpDir, err = os.MkdirTemp("", "presidium-themes-*")
+	tmpDir, err = filesystem.AFS.TempDir("", "presidium-themes-*")
 	if err != nil {
 		return "", "", fmt.Errorf("creating temp directory: %w", err)
 	}
@@ -97,8 +97,8 @@ func (s Service) Extract() (tmpDir string, replacements string, err error) {
 		themeName := moduleMap[modulePath]
 		// Create the theme directory in temp
 		themeDir := filepath.Join(tmpDir, themeName)
-		if err := os.MkdirAll(themeDir, 0755); err != nil {
-			os.RemoveAll(tmpDir)
+		if err := filesystem.AFS.MkdirAll(themeDir, 0755); err != nil {
+			_ = filesystem.AFS.RemoveAll(tmpDir)
 			return "", "", fmt.Errorf("creating theme directory %s: %w", themeName, err)
 		}
 
@@ -146,7 +146,7 @@ func (s Service) Extract() (tmpDir string, replacements string, err error) {
 		})
 
 		if err != nil {
-			os.RemoveAll(tmpDir)
+			_ = filesystem.AFS.RemoveAll(tmpDir)
 			return "", "", fmt.Errorf("extracting theme %s: %w", themeName, err)
 		}
 

pkg/domain/service/themes/themes_test.go

@@ -6,6 +6,8 @@ import (
 	"strings"
 	"testing"
 	"testing/fstest"
+
+	"github.com/SPANDigital/presidium-hugo/pkg/filesystem"
 )
 
 func TestNew_WithEmbeddedFS(t *testing.T) {
@@ -70,23 +72,23 @@ func TestExtract_WritesFilesAndProducesReplacements(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Extract() returned unexpected error: %v", err)
 	}
-	defer os.RemoveAll(tmpDir)
+	defer func() { _ = filesystem.AFS.RemoveAll(tmpDir) }()
 
 	// Verify go.mod.tmpl was renamed to go.mod on disk
 	goModPath := filepath.Join(tmpDir, "presidium-styling-base", "go.mod")
-	if _, err := os.Stat(goModPath); os.IsNotExist(err) {
+	if exists, _ := filesystem.AFS.Exists(goModPath); !exists {
 		t.Error("Expected go.mod.tmpl to be extracted as go.mod, but file does not exist")
 	}
 
 	// Verify go.sum.tmpl was renamed to go.sum on disk
 	goSumPath := filepath.Join(tmpDir, "presidium-styling-base", "go.sum")
-	if _, err := os.Stat(goSumPath); os.IsNotExist(err) {
+	if exists, _ := filesystem.AFS.Exists(goSumPath); !exists {
 		t.Error("Expected go.sum.tmpl to be extracted as go.sum, but file does not exist")
 	}
 
 	// Verify config.yml was extracted
 	configPath := filepath.Join(tmpDir, "presidium-styling-base", "config.yml")
-	if _, err := os.Stat(configPath); os.IsNotExist(err) {
+	if exists, _ := filesystem.AFS.Exists(configPath); !exists {
 		t.Error("Expected config.yml to be extracted, but file does not exist")
 	}
 
@@ -127,7 +129,7 @@ func TestExtract_EmptyTheme(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Extract() returned unexpected error: %v", err)
 	}
-	defer os.RemoveAll(tmpDir)
+	defer func() { _ = filesystem.AFS.RemoveAll(tmpDir) }()
 
 	if replacements == "" {
 		t.Error("Expected non-empty replacements string")