attempt to fix #84

Added a directory access check everytime a user adds a new scripting directory to a config, and added a logging action everytime a user changes config and the editor could not access one of its dirs to parse the includes, listing it in the log box.

Author: maxijabase

SourcepawnCondenser/SourcepawnCondenser/SourcemodDefinition/SMDefinition.cs

@@ -60,8 +60,9 @@ public void Sort()
             } //racing condition on save when the thread closes first or not..
         }
 
-        public void AppendFiles(IEnumerable<string> paths)
+        public void AppendFiles(IEnumerable<string> paths, out List<string> rejectedPaths)
         {
+            rejectedPaths = new();
             foreach (var path in paths)
             {
                 if (Directory.Exists(path))
@@ -86,13 +87,11 @@ public void AppendFiles(IEnumerable<string> paths)
                     }
                     catch (UnauthorizedAccessException)
                     {
-                        // ignored
+                        rejectedPaths.Add(path);
                     }
                 }
             }
 
-            // var editor = Program.MainWindow.GetCurrentEditorElement();
-
             Sort();
             ProduceStringArrays();
         }

UI/MainWindow/MainWindowConfigHandler.cs

@@ -1,4 +1,6 @@
-using System.Windows;
+using System.Linq;
+using System.Text;
+using System.Windows;
 using System.Windows.Controls;
 using SPCode.Interop;
 using SPCode.UI.Components;
@@ -41,7 +43,7 @@ private void Item_Click(object sender, RoutedEventArgs e)
         {
             var name = (string)((MenuItem)sender).Header;
             ChangeConfig(name);
-            LoggingControl.LogAction($"Changed to config \"{name}\".");
+            LoggingControl.LogAction($"Changed to config \"{name}\".", 2);
         }
 
         /// <summary>
@@ -54,14 +56,30 @@ public void ChangeConfig(int index)
             {
                 return;
             }
+
             Program.Configs[index].LoadSMDef();
+
+            if (Program.Configs[index].RejectedPaths.Any())
+            {
+                var sb = new StringBuilder();
+                sb.Append("SPCode was unauthorized to access the following directories to parse their includes: \n");
+                foreach (var path in Program.Configs[index].RejectedPaths)
+                {
+                    sb.Append($"  - {path}\n");
+                }
+
+                LoggingControl.LogAction(sb.ToString());
+            }
+
             var name = Program.Configs[index].Name;
             for (var i = 0; i < ConfigMenu.Items.Count - 2; ++i)
             {
                 ((MenuItem)ConfigMenu.Items[i]).IsChecked = name == (string)((MenuItem)ConfigMenu.Items[i]).Header;
             }
+
             Program.SelectedConfig = index;
             Program.OptionsObject.Program_SelectedConfig = Program.Configs[Program.SelectedConfig].Name;
+
             var editors = GetAllEditorElements();
             if (editors != null)
             {
@@ -72,6 +90,7 @@ public void ChangeConfig(int index)
                     editor.InvalidateVisual();
                 }
             }
+
             OBDirList.ItemsSource = Program.Configs[index].SMDirectories;
             OBDirList.Items.Refresh();
             OBDirList.SelectedIndex = 0;

UI/Windows/ConfigWindow.xaml.cs

@@ -209,13 +209,27 @@ private void AddSMDirButton_Click(object sender, RoutedEventArgs e)
             {
                 IsFolderPicker = true
             };
+
             if (dialog.ShowDialog() == CommonFileDialogResult.Ok)
             {
                 var c = Program.Configs[ConfigListBox.SelectedIndex];
+
                 if (c.SMDirectories.Contains(dialog.FileName))
                 {
                     return;
                 }
+
+                try
+                {
+                    Directory.GetAccessControl(dialog.FileName);
+                }
+                catch (UnauthorizedAccessException)
+                {
+                    this.ShowMessageAsync("Access error", 
+                        "The directory you just specified could not be accessed properly by SPCode. You might have trouble using the includes from this directory.", 
+                        MessageDialogStyle.Affirmative, Program.MainWindow.MetroDialogOptions);
+                }
+
                 c.SMDirectories.Add(dialog.FileName);
                 C_SMDir.Items.Refresh();
                 NeedsSMDefInvalidation = true;

Utils/Models/Config.cs

@@ -1,6 +1,9 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
+using System.Text;
 using SourcepawnCondenser.SourcemodDefinition;
+using SPCode.Interop;
 
 namespace SPCode.Utils
 {
@@ -39,6 +42,7 @@ public class Config
         private SMDefinition SMDef;
 
         public List<string> SMDirectories;
+        public List<string> RejectedPaths = new();
 
         public bool Standard;
         public int VerboseLevel = 1;
@@ -68,12 +72,18 @@ public void LoadSMDef()
             try
             {
                 var def = new SMDefinition();
-                def.AppendFiles(SMDirectories);
+                def.AppendFiles(SMDirectories, out var rejectedPaths);
+
+                if (rejectedPaths.Any())
+                {
+                    rejectedPaths.ForEach(x => RejectedPaths.Add(x));
+                }
+
                 SMDef = def;
             }
             catch (Exception)
             {
-                SMDef = new SMDefinition(); //this could be dangerous...
+                SMDef = new SMDefinition();
             }
         }
     }