added check for duplicated and empty config names

Author: maxijabase

Interop/TranslationProvider.cs

@@ -314,6 +314,9 @@ private void FillToEnglishDefaults()
             language.Add("JavaDownErrorTitle", "Java download error");
             language.Add("JavaDownErrorMessage", "SPCode could not download Java by itself. Would you like to download it manually?");
             language.Add("JavaOpenedBrowser", "Java download link opened in browser");
+            language.Add("ErrorSavingConfigs", "Could not save the current configs state");
+            language.Add("DuplicateConfigNames", "You cannot have 2 configs or more with the same name.");
+            language.Add("EmptyConfigNames", "You cannot have configs with an empty name.");
         }
     }
 }

UI/Windows/ConfigWindow.xaml

@@ -4,7 +4,7 @@
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
              xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" 
              Width="1085" Height="625" ResizeMode="NoResize" WindowStartupLocation="CenterOwner" GlowBrush="{DynamicResource AccentColorBrush}"
-                      Title="Configurations" ShowTitleBar="False" Closed="MetroWindow_Closed">
+                      Title="Configurations" ShowTitleBar="False" Closing="MetroWindow_Closing">
     <controls:MetroWindow.Resources>
         <ResourceDictionary>
             <ResourceDictionary.MergedDictionaries>

UI/Windows/ConfigWindow.xaml.cs

@@ -3,6 +3,7 @@
 using System.Diagnostics;
 using System.Globalization;
 using System.IO;
+using System.Linq;
 using System.Text;
 using System.Windows;
 using System.Windows.Controls;
@@ -461,8 +462,9 @@ private void C_RConCmds_TextChanged(object sender, RoutedEventArgs e)
             Program.Configs[ConfigListBox.SelectedIndex].RConCommands = C_RConCmds.Text;
         }
 
-        private void MetroWindow_Closed(object sender, EventArgs e)
+        private void MetroWindow_Closing(object sender, System.ComponentModel.CancelEventArgs e)
         {
+            // TODO: find out what is this for
             if (NeedsSMDefInvalidation)
             {
                 foreach (var config in Program.Configs)
@@ -471,6 +473,40 @@ private void MetroWindow_Closed(object sender, EventArgs e)
                 }
             }
 
+            // Fill a list with all configs from the ListBox
+
+            var configsList = new List<string>();
+
+            for (int i = 0; i < ConfigListBox.Items.Count; i++)
+            {
+                configsList.Add(((ListBoxItem)ConfigListBox.Items[i]).Content.ToString());
+            }
+
+            // Check for empty named configs and disallow saving configs
+
+            foreach (var cfg in configsList)
+            {
+                if (cfg == string.Empty)
+                {
+                    e.Cancel = true;
+                    this.ShowMessageAsync(Program.Translations.GetLanguage("ErrorSavingConfigs"),
+                        Program.Translations.GetLanguage("EmptyConfigNames"), MessageDialogStyle.Affirmative,
+                        MetroDialogOptions);
+                    return;
+                }
+            }
+
+            // Check for duplicate names in the config list and disallow saving configs
+
+            if (configsList.Count != configsList.Distinct().Count())
+            {
+                e.Cancel = true;
+                this.ShowMessageAsync(Program.Translations.GetLanguage("ErrorSavingConfigs"),
+                    Program.Translations.GetLanguage("DuplicateConfigNames"), MessageDialogStyle.Affirmative,
+                    MetroDialogOptions);
+                return;
+            }
+
             Program.MainWindow.FillConfigMenu();
             Program.MainWindow.ChangeConfig(Program.SelectedConfig);
             var outString = new StringBuilder();