fixed hotkeys file not updating when a new hotkey was implemented

Author: maxijabase

Interop/HotkeyControl.cs

@@ -1,4 +1,7 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.Linq;
 using System.Xml;
 using SPCode.Utils;
 
@@ -52,18 +55,51 @@ public class HotkeyControl
         };
 
         /// <summary>
-        /// Buffers the hotkeys to an array in memory.
+        /// Checks if there are new Hotkeys that haven't been added to the Hotkeys file <br>
+        /// and buffers all Hotkeys to an array in memory.
         /// </summary>
-        public static void BufferHotkeys()
+        public static void CheckAndBufferHotkeys()
         {
-            // Buffer hotkeys in global HotkeyInfo list
-            Program.HotkeysList = new();
-            var document = new XmlDocument();
-            document.Load(Constants.HotkeysFile);
+            try
+            {
+                // Load the current Hotkeys file
+                Program.HotkeysList = new();
+                var document = new XmlDocument();
+                document.Load(Constants.HotkeysFile);
+
+                // Compare with the default hotkeys to check for new commands
+                var xmlNodes = document.ChildNodes[0].ChildNodes.Cast<XmlNode>().ToList();
+                var defaultHksCount = DefaultHotkeys.Count;
+
+                // If the count is not equal, there's a new hotkey to be added to the file
+                if (xmlNodes.Count != defaultHksCount)
+                {
+                    // Regular for to get the index
+                    for (var i = 0; i < defaultHksCount; i++)
+                    {
+                        var currentHk = DefaultHotkeys.ElementAt(i);
+                        if (!xmlNodes.Any(x => x.Name.Equals(DefaultHotkeys.ElementAt(i).Key)))
+                        {
+                            var element = document.CreateElement(string.Empty, currentHk.Key, string.Empty);
+                            var text = document.CreateTextNode(currentHk.Value);
+                            element.AppendChild(text);
+                            document.ChildNodes[0].InsertBefore(element, document.ChildNodes[0].ChildNodes[i]);
+                        }
+                    }
+                    document.Save(Constants.HotkeysFile);
+                    xmlNodes = document.ChildNodes[0].ChildNodes.Cast<XmlNode>().ToList();
+                }
 
-            foreach (XmlNode node in document.ChildNodes[0].ChildNodes)
+                xmlNodes.ForEach(x =>
+                {
+                    var hki = new HotkeyInfo(new Hotkey(x.InnerText), x.Name);
+                    Program.HotkeysList.Add(hki);
+                });
+
+            }
+            catch (Exception ex)
             {
-                Program.HotkeysList.Add(new HotkeyInfo(new Hotkey(node.InnerText), node.Name));
+                throw new Exception("Error while checking and buffering the hotkeys", ex);
             }
         }
 
@@ -72,29 +108,36 @@ public static void BufferHotkeys()
         /// </summary>
         public static void CreateDefaultHotkeys()
         {
-            // Create the XML document
-            var document = new XmlDocument();
+            try
+            {
+                // Create the XML document
+                var document = new XmlDocument();
 
-            var rootElement = document.CreateElement(string.Empty, "Hotkeys", string.Empty);
-            document.AppendChild(rootElement);
+                var rootElement = document.CreateElement(string.Empty, "Hotkeys", string.Empty);
+                document.AppendChild(rootElement);
 
-            // Fill it with the default hotkeys from the dictionary
-            foreach (var item in DefaultHotkeys)
-            {
-                var element = document.CreateElement(string.Empty, item.Key, string.Empty);
-                var text = document.CreateTextNode(item.Value);
-                element.AppendChild(text);
-                rootElement.AppendChild(element);
-            }
+                // Fill it with the default hotkeys from the dictionary
+                foreach (var item in DefaultHotkeys)
+                {
+                    var element = document.CreateElement(string.Empty, item.Key, string.Empty);
+                    var text = document.CreateTextNode(item.Value);
+                    element.AppendChild(text);
+                    rootElement.AppendChild(element);
+                }
+
+                // Buffer hotkeys in global HotkeyInfo list
+                Program.HotkeysList = new List<HotkeyInfo>();
+                foreach (XmlNode node in document.ChildNodes[0].ChildNodes)
+                {
+                    Program.HotkeysList.Add(new HotkeyInfo(new Hotkey(node.InnerText), node.Name));
+                }
 
-            // Buffer hotkeys in global HotkeyInfo list
-            Program.HotkeysList = new List<HotkeyInfo>();
-            foreach (XmlNode node in document.ChildNodes[0].ChildNodes)
+                document.Save(Constants.HotkeysFile);
+            }
+            catch (Exception ex)
             {
-                Program.HotkeysList.Add(new HotkeyInfo(new Hotkey(node.InnerText), node.Name));
+                throw new Exception("Error while creating the default hotkeys", ex);
             }
-
-            document.Save(Constants.HotkeysFile);
         }
     }
 }

Program.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.IO;
 using System.Reflection;
@@ -81,7 +82,7 @@ public static void Main(string[] args)
                     }
                     else
                     {
-                        HotkeyControl.BufferHotkeys();
+                        HotkeyControl.CheckAndBufferHotkeys();
                     }
 
                     // Delete the default Ctrl+D hotkey to assign manually
@@ -275,6 +276,7 @@ private static void App_Startup(object sender, StartupEventArgs e)
                 ThemeManager.GetAppTheme("BaseDark")); // or appStyle.Item1
         }
 
+        [SuppressMessage("CodeQuality", "IDE0051:Remove unused private members")]
         private static string BuildExceptionString(Exception e, string SectionName)
         {
             var outString = new StringBuilder();