Mitigate memory-leak

Author: Hexer10

SourcepawnCondenser/SourcepawnCondenser/SourcemodDefinition/SMDefinition.cs

@@ -180,12 +180,12 @@ private void ProduceStringArrays(int caret = -1, List<SMFunction> currentFunctio
             }
         }
 
-        public List<ACNode> ProduceACNodes()
+        public void ProduceACNodes(List<ACNode> nodes)
         {
-            var nodes = new List<ACNode>
-            {
-                Capacity = Enums.Count + Structs.Count + ConstVariables.Count + Functions.Count
-            };
+            
+            nodes.Clear();
+            
+            nodes.Capacity = Enums.Count + Structs.Count + ConstVariables.Count + Functions.Count;
             nodes.AddRange(ACNode.ConvertFromStringArray(FunctionStrings, true, "▲ "));
             nodes.AddRange(ACNode.ConvertFromStringList(TypeStrings, false, "♦ "));
             nodes.AddRange(ACNode.ConvertFromStringList(Constants, false, "• "));
@@ -196,8 +196,6 @@ public List<ACNode> ProduceACNodes()
 
             //nodes = nodes.Distinct(new ACNodeEqualityComparer()).ToList(); Methodmaps and Functions can and will be the same.
             nodes.Sort((a, b) => string.CompareOrdinal(a.EntryName, b.EntryName));
-
-            return nodes;
         }
 
         public void MergeDefinitions(SMDefinition def)
@@ -341,9 +339,9 @@ public int GetHashCode(ACNode node)
 
     public class ACNode
     {
+        private string Prefix;
         public string EntryName;
         public bool IsExecutable;
-        private string _name;
 
         public static List<ACNode> ConvertFromStringArray(string[] strings, bool executable, string prefix = "")
         {
@@ -352,7 +350,7 @@ public static List<ACNode> ConvertFromStringArray(string[] strings, bool executa
             for (var i = 0; i < length; ++i)
             {
                 nodeList.Add(
-                    new ACNode {_name = prefix + strings[i], EntryName = strings[i], IsExecutable = executable});
+                    new ACNode {Prefix = prefix, EntryName = strings[i], IsExecutable = executable});
             }
 
             return nodeList;
@@ -361,9 +359,9 @@ public static List<ACNode> ConvertFromStringArray(string[] strings, bool executa
         public static IEnumerable<ACNode> ConvertFromStringList(IEnumerable<string> strings, bool executable,
             string prefix = "", bool addSpace = false)
         {
-            return strings.Select(e => new ACNode {_name = prefix + e, EntryName = e, IsExecutable = executable});
+            return strings.Select(e => new ACNode {Prefix = prefix, EntryName = e, IsExecutable = executable});
         }
 
-        public override string ToString() => _name;
+        public override string ToString() => Prefix + EntryName;
     }
 }

UI/Components/EditorElement/EditorElementIntellisenseController.cs

@@ -135,7 +135,8 @@ public void LoadAutoCompletes()
             }
 
             _smDef = Program.Configs[Program.SelectedConfig].GetSMDef();
-            _acEntries = _smDef.ProduceACNodes();
+            _acEntries = new List<ACNode>();
+            _smDef.ProduceACNodes(_acEntries);
 
 
             AutoCompleteBox.ItemsSource = _acEntries;
@@ -148,10 +149,10 @@ public void LoadAutoCompletes()
         /// <param name="smDef"> The SMDefinition </param>
         private void InterruptLoadAutoCompletes(SMDefinition smDef)
         {
-            var acNodes = smDef.ProduceACNodes();
+            smDef.ProduceACNodes(_acEntries);
             Dispatcher?.Invoke(() =>
             {
-                _acEntries = acNodes;
+                _acEntries = _acEntries;
                 AutoCompleteBox.ItemsSource = _acEntries;
                 PreProcAutocompleteBox.ItemsSource = PreProcNodes;
                 _smDef = smDef;
@@ -430,7 +431,6 @@ private bool ComputeAutoComplete(string text, int lineOffset, int quoteCount)
                     }
 
 
-
                     // If the preprocessor stmt found close the dialog.
                     if (statement.Length != 0 && PreProcList.Contains(statement.Trim()))
                     {
@@ -521,6 +521,7 @@ private bool ComputeAutoComplete(string text, int lineOffset, int quoteCount)
                     {
                         return false;
                     }
+
                     int len = 0;
                     for (var i = classOffset; i >= 0; --i)
                     {
@@ -581,7 +582,8 @@ private bool ComputeAutoComplete(string text, int lineOffset, int quoteCount)
                 var match = NewRegex.Match(text.Substring(0, lineOffset));
                 if (match.Success)
                 {
-                    var isNodes = ACNode.ConvertFromStringList(_smDef.Methodmaps.Select(e => e.Name), true, "• ").ToList();
+                    var isNodes = ACNode.ConvertFromStringList(_smDef.Methodmaps.Select(e => e.Name), true, "• ")
+                        .ToList();
 
                     if (!isNodes.SequenceEqual(_methodACEntries, ISEqualityComparer))
                     {