fixed compile warnings being logged as errors

Author: maxijabase

UI/MainWindow/MainWindowSPCompiler.cs

@@ -49,15 +49,17 @@ private async void Compile_SPScripts(bool compileAll = true)
             NonUploadedFiles.Clear();
 
             // Grabs current config
-            var c = Program.Configs[Program.SelectedConfig];
+            var currentConfig = Program.Configs[Program.SelectedConfig];
 
             // Creates flags
             FileInfo spCompInfo = null;
             var SpCompFound = false;
             var PressedEscape = false;
+            var hadError = false;
+            var warnings = 0;
 
             // Searches for the spcomp.exe compiler
-            foreach (var dir in c.SMDirectories)
+            foreach (var dir in currentConfig.SMDirectories)
             {
                 spCompInfo = new FileInfo(Path.Combine(dir, "spcomp.exe"));
                 if (spCompInfo.Exists)
@@ -169,7 +171,7 @@ await this.ShowMessageAsync(Program.Translations.GetLanguage("Error"),
                         }
 
                         var includeDirectories = new StringBuilder();
-                        foreach (var dir in c.SMDirectories)
+                        foreach (var dir in currentConfig.SMDirectories)
                         {
                             includeDirectories.Append(" -i=\"" + dir + "\"");
                         }
@@ -178,9 +180,9 @@ await this.ShowMessageAsync(Program.Translations.GetLanguage("Error"),
 
                         process.StartInfo.Arguments =
                             "\"" + fileInfo.FullName + "\" -o=\"" + outFile + "\" -e=\"" + errorFile + "\"" +
-                            includeStr + " -O=" + c.OptimizeLevel + " -v=" + c.VerboseLevel;
+                            includeStr + " -O=" + currentConfig.OptimizeLevel + " -v=" + currentConfig.VerboseLevel;
                         progressTask.SetProgress((i + 1 - 0.5d) / compileCount);
-                        var execResult = ExecuteCommandLine(c.PreCmd, fileInfo.DirectoryName, c.CopyDirectory,
+                        var execResult = ExecuteCommandLine(currentConfig.PreCmd, fileInfo.DirectoryName, currentConfig.CopyDirectory,
                             fileInfo.FullName, fileInfo.Name, outFile, destinationFileName);
                         if (!string.IsNullOrWhiteSpace(execResult))
                         {
@@ -205,6 +207,8 @@ await this.ShowMessageAsync(Program.Translations.GetLanguage("SPCompNotStarted")
 
                         if (File.Exists(errorFile))
                         {
+                            warnings = 0;
+                            hadError = false;
                             var errorStr = File.ReadAllText(errorFile);
                             stringOutput.AppendLine(errorStr.Trim('\n', '\r'));
                             var mc = errorFilterRegex.Matches(errorStr);
@@ -217,14 +221,25 @@ await this.ShowMessageAsync(Program.Translations.GetLanguage("SPCompNotStarted")
                                     Type = mc[j].Groups["Type"].Value.Trim(),
                                     Details = mc[j].Groups["Details"].Value.Trim()
                                 });
+                                if (mc[j].Groups["Type"].Value.Contains("error"))
+                                {
+                                    hadError = true;
+                                }
+                                if (mc[j].Groups["Type"].Value.Contains("warning"))
+                                {
+                                    warnings++;
+                                }
                             }
+                            File.Delete(errorFile);
+                        }
 
+                        if (hadError)
+                        {
                             LoggingControl.LogAction(fileInfo.Name + " (error)");
-                            File.Delete(errorFile);
                         }
                         else
                         {
-                            LoggingControl.LogAction(fileInfo.Name);
+                            LoggingControl.LogAction($"{fileInfo.Name}{(warnings > 0 ? $" ({warnings} warnings)" : "")}");
                             compiledSuccess++;
                         }
 
@@ -235,8 +250,8 @@ await this.ShowMessageAsync(Program.Translations.GetLanguage("SPCompNotStarted")
                             CompiledFileNames.Add(destinationFileName);
                         }
 
-                        var execResult_Post = ExecuteCommandLine(c.PostCmd, fileInfo.DirectoryName,
-                            c.CopyDirectory, fileInfo.FullName, fileInfo.Name, outFile, destinationFileName);
+                        var execResult_Post = ExecuteCommandLine(currentConfig.PostCmd, fileInfo.DirectoryName,
+                            currentConfig.CopyDirectory, fileInfo.FullName, fileInfo.Name, outFile, destinationFileName);
                         if (!string.IsNullOrWhiteSpace(execResult_Post))
                         {
 
@@ -249,29 +264,29 @@ await this.ShowMessageAsync(Program.Translations.GetLanguage("SPCompNotStarted")
 
                 if (compiledSuccess > 0)
                 {
-                    LoggingControl.LogAction($"Compiled {compiledSuccess} {(compileAll ? "plugins" : "plugin")}.", 2);
+                    LoggingControl.LogAction($"Compiled {compiledSuccess} {(compiledSuccess > 1 ? "plugins" : "plugin")}.", 2);
                 }
 
                 if (!PressedEscape)
                 {
                     progressTask.SetProgress(1.0);
-                    if (c.AutoCopy)
+                    if (currentConfig.AutoCopy)
                     {
                         progressTask.SetTitle(Program.Translations.GetLanguage("CopyingFiles"));
                         progressTask.SetIndeterminate();
                         await Task.Run(() => Copy_Plugins());
                         progressTask.SetProgress(1.0);
                     }
 
-                    if (c.AutoUpload)
+                    if (currentConfig.AutoUpload)
                     {
                         progressTask.SetTitle(Program.Translations.GetLanguage("FTPUploading"));
                         progressTask.SetIndeterminate();
                         await Task.Run(FTPUpload_Plugins);
                         progressTask.SetProgress(1.0);
                     }
 
-                    if (c.AutoRCON)
+                    if (currentConfig.AutoRCON)
                     {
                         progressTask.SetTitle(Program.Translations.GetLanguage("RCONCommand"));
                         progressTask.SetIndeterminate();