fixed copy errors button copying old errors

Author: maxijabase

UI/MainWindow/MainWindowErrorStatus.cs

@@ -42,7 +42,7 @@ private void Status_WarningButton_Clicked(object sender, RoutedEventArgs e)
 
         private void Status_CopyErrorsButton_Click(object sender, RoutedEventArgs e)
         {
-            if (CurrentErrorString != null)
+            if (!string.IsNullOrEmpty(CurrentErrorString))
             {
                 Clipboard.SetText(CurrentErrorString);
             }

UI/MainWindow/MainWindowSPCompiler.cs

@@ -22,8 +22,8 @@ public partial class MainWindow
         private readonly List<string> CompiledFileNames = new();
         private readonly List<string> CompiledFiles = new();
         private readonly List<string> NonUploadedFiles = new();
-        private List<ErrorDataGridRow> CurrentErrors = new();
-        private List<ErrorDataGridRow> CurrentWarnings = new();
+        private readonly List<ErrorDataGridRow> CurrentErrors = new();
+        private readonly List<ErrorDataGridRow> CurrentWarnings = new();
 
         public int TotalErrors;
         public int TotalWarnings;
@@ -70,6 +70,7 @@ private async void Compile_SPScripts(bool compileAll = true)
             var hadError = false;
             TotalErrors = 0;
             TotalWarnings = 0;
+            CurrentErrorString = string.Empty;
 
             // Searches for the spcomp.exe compiler
             foreach (var dir in currentConfig.SMDirectories)

UI/MainWindow/MainWindowTranslations.cs

@@ -88,6 +88,7 @@ public void Language_Translate(bool Initial = false)
             BtExpandCollapse.ToolTip = Translate(OBExpanded ? "ExpandAllDirs" : "CollapseAllDirs");
             BtRefreshDir.ToolTip = Translate("RefreshOB");
 
+            // Leaving a space at the end here because it makes the button look better
             Status_ErrorText.Text = $"0 {Translate("Errors")} ";
             Status_WarningText.Text = $"0 {Translate("Warnings")} ";
             Status_CopyErrorsButton.Content = Translate("CopyErrors");