fixing mod encoding

Author: SQLJames

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## Changelog
 
+### V2.2.1
+
+#### Non-Breaking Changes
+
+- Fixing mod download script to encode spaces properly, fixes [Issue 42](https://github.com/SQLJames/factorio-server-charts/issues/42)
+
 ### V2.2.0
 
 #### Non-Breaking Changes

charts/factorio-server-charts/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 2.2.0
+version: 2.2.1
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

charts/factorio-server-charts/templates/deployment.yaml

@@ -85,10 +85,14 @@ spec:
           imagePullPolicy:  {{ .Values.image.pullPolicy }}
           command:
             - /bin/bash
-            - -ec
+            - -ecx
             - |
               mkdir -p /factorio/mods
+              ls -alth /scripts
+              echo "Running mod-downloader.sh script..."
               bash /scripts/mod-downloader.sh
+              echo "Finished mod-downloader.sh script"
+              ls -althR /factorio/mods
           {{- with .Values.securityContext }}
           securityContext:
             {{- toYaml . | nindent 12 }}

charts/factorio-server-charts/templates/mod-downloader-configmap.yaml

@@ -39,6 +39,8 @@ data:
         cd $modDir;curl -L -o $2 $1
     }
     function downloadofficial() {
+        MOD_NAME="$1"
+        MOD_NAME_ENCODED="${1// /%20}"
         if [[ -z ${USERNAME:-} ]]; then
           USERNAME="$(cat /account/username)"
         fi
@@ -54,7 +56,7 @@ data:
         if [[ -z ${TOKEN:-} ]]; then
           echo "You need to provide your Factorio token to update mods."
         fi
-        MOD_INFO_URL="$MOD_BASE_URL/api/mods/$1"
+        MOD_INFO_URL="$MOD_BASE_URL/api/mods/$MOD_NAME_ENCODED"
         MOD_INFO_JSON=$(curl --silent "$MOD_INFO_URL")
     #    echo "$MOD_INFO_URL $MOD_INFO_JSON"
         if ! echo "$MOD_INFO_JSON" | jq -e .name >/dev/null; then