Skip to content

Commit 415b4b2

Browse files
authored
Remove secrets from public workflow (#899)
1 parent 8c39017 commit 415b4b2

File tree

4 files changed

+9
-52
lines changed

4 files changed

+9
-52
lines changed

.github/workflows/build_windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: windows-latest
1717
env:
1818
USERNAME: ${{ github.actor }}
19-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
19+
GITHUB_TOKEN: ${{ github.token }}
2020
steps:
2121
- name: Checkout
2222
uses: actions/checkout@v4

.github/workflows/dependency_graph.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
contents: write
1818
env:
1919
USERNAME: ${{ github.actor }}
20-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
20+
GITHUB_TOKEN: ${{ github.token }}
2121
steps:
2222
- name: Checkout
2323
uses: actions/checkout@v4
@@ -28,5 +28,3 @@ jobs:
2828
distribution: 'temurin'
2929
- name: Submit dependency graph
3030
uses: gradle/actions/dependency-submission@v4
31-
with:
32-
cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}

.github/workflows/quality.yml

Lines changed: 6 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -12,39 +12,12 @@ concurrency:
1212
cancel-in-progress: true
1313

1414
jobs:
15-
build:
16-
name: Build
17-
runs-on: ubuntu-latest
18-
env:
19-
USERNAME: ${{ github.actor }}
20-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
21-
steps:
22-
- name: Checkout
23-
uses: actions/checkout@v4
24-
- name: Set up Java
25-
uses: actions/setup-java@v4
26-
with:
27-
java-version: '17'
28-
distribution: 'temurin'
29-
- name: Set up Gradle
30-
uses: gradle/actions/setup-gradle@v4
31-
with:
32-
cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
33-
- name: Build modules
34-
run: >
35-
./gradlew
36-
:pillarbox-demo:assembleProdDebug
37-
:pillarbox-demo-cast:assembleDebug
38-
:pillarbox-demo-tv:assembleDebug
39-
:pillarbox-player-testutils:assembleDebug
40-
4115
android-lint:
4216
name: Android Lint
4317
runs-on: ubuntu-latest
44-
needs: build
4518
env:
4619
USERNAME: ${{ github.actor }}
47-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
20+
GITHUB_TOKEN: ${{ github.token }}
4821
steps:
4922
- name: Checkout
5023
uses: actions/checkout@v4
@@ -55,8 +28,6 @@ jobs:
5528
distribution: 'temurin'
5629
- name: Set up Gradle
5730
uses: gradle/actions/setup-gradle@v4
58-
with:
59-
cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
6031
- name: Run Android Lint
6132
run: >
6233
./gradlew
@@ -74,10 +45,9 @@ jobs:
7445
detekt:
7546
name: Detekt
7647
runs-on: ubuntu-latest
77-
needs: build
7848
env:
7949
USERNAME: ${{ github.actor }}
80-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
50+
GITHUB_TOKEN: ${{ github.token }}
8151
steps:
8252
- name: Checkout
8353
uses: actions/checkout@v4
@@ -88,8 +58,6 @@ jobs:
8858
distribution: 'temurin'
8959
- name: Set up Gradle
9060
uses: gradle/actions/setup-gradle@v4
91-
with:
92-
cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
9361
- name: Run Detekt
9462
run: ./gradlew detekt
9563
- name: Upload Detekt results
@@ -102,10 +70,9 @@ jobs:
10270
dependency-analysis:
10371
name: Dependency Analysis
10472
runs-on: ubuntu-latest
105-
needs: build
10673
env:
10774
USERNAME: ${{ github.actor }}
108-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
75+
GITHUB_TOKEN: ${{ github.token }}
10976
steps:
11077
- name: Checkout
11178
uses: actions/checkout@v4
@@ -116,20 +83,17 @@ jobs:
11683
distribution: 'temurin'
11784
- name: Set up Gradle
11885
uses: gradle/actions/setup-gradle@v4
119-
with:
120-
cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
12186
- name: Run Dependency Analysis
12287
run: ./gradlew buildHealth
12388

12489
unit-test:
12590
name: Unit Tests
12691
runs-on: ubuntu-latest
127-
needs: build
12892
permissions:
12993
pull-requests: write
13094
env:
13195
USERNAME: ${{ github.actor }}
132-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
96+
GITHUB_TOKEN: ${{ github.token }}
13397
steps:
13498
- name: Checkout
13599
uses: actions/checkout@v4
@@ -140,8 +104,6 @@ jobs:
140104
distribution: 'temurin'
141105
- name: Set up Gradle
142106
uses: gradle/actions/setup-gradle@v4
143-
with:
144-
cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
145107
- name: Run Unit Tests
146108
run: >
147109
./gradlew
@@ -157,7 +119,7 @@ jobs:
157119
uses: madrapps/[email protected]
158120
with:
159121
paths: ${{ github.workspace }}/**/build/reports/kover/**.xml
160-
token: ${{ secrets.GITHUB_TOKEN }}
122+
token: ${{ github.token }}
161123
min-coverage-overall: 0
162124
min-coverage-changed-files: 0
163125
update-comment: true
@@ -168,10 +130,9 @@ jobs:
168130
android-tests:
169131
name: Android Tests
170132
runs-on: ubuntu-latest
171-
needs: build
172133
env:
173134
USERNAME: ${{ github.actor }}
174-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
135+
GITHUB_TOKEN: ${{ github.token }}
175136
strategy:
176137
matrix:
177138
api-level: [ 26 ]
@@ -191,8 +152,6 @@ jobs:
191152
distribution: 'temurin'
192153
- name: Set up Gradle
193154
uses: gradle/actions/setup-gradle@v4
194-
with:
195-
cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
196155
- name: Run Android Tests
197156
uses: reactivecircus/android-emulator-runner@v2
198157
with:

gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12.1-all.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

0 commit comments

Comments
 (0)