SDAP: fix discarded-qualifiers warning in are_sids_from_same_dom()

claude · claude · commit e0fa18d5428f · 2026-02-19T08:16:21.000Z
Make rid1 and rid2 `const char *` since they only hold strrchr()
results from const input strings and are used for pointer arithmetic.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/providers/ldap/sdap_async_groups.c b/src/providers/ldap/sdap_async_groups.c
@@ -742,7 +742,7 @@ are_sids_from_same_dom(const char *sid1, const char *sid2, bool *_result)
 {
     size_t len_prefix_sid1;
     size_t len_prefix_sid2;
-    char *rid1, *rid2;
+    const char *rid1, *rid2;
     bool result;
 
     rid1 = strrchr(sid1, '-');

Original file line number	Diff line number	Diff line change
`@@ -742,7 +742,7 @@ are_sids_from_same_dom(const char sid1, const char sid2, bool *_result)`
`742`	`742`	`{`
`743`	`743`	`size_t len_prefix_sid1;`
`744`	`744`	`size_t len_prefix_sid2;`
`745`		`- char rid1, rid2;`
	`745`	`+ const char rid1, rid2;`
`746`	`746`	`bool result;`
`747`	`747`
`748`	`748`	`rid1 = strrchr(sid1, '-');`