XS⚠️ ◾ Moved MCP types to shared folder (#656)

moved types to shared

Author: babakamyljanovssw

src/backend/services/mcp/mcp-server-manager.ts

@@ -147,7 +147,7 @@ export class MCPServerManager {
     }
 
     let options: CreateClientOptions | undefined;
-    if (config.transport === "inMemory" && "inMemoryServerId" in config) {
+    if (config.transport === "inMemory" && config.inMemoryServerId) {
       const transport = MCPServerManager.internalClientTransports.get(config.inMemoryServerId);
       if (!transport) {
         throw new Error(

src/backend/services/mcp/types.ts

@@ -1,41 +1,8 @@
-import type { IOType } from "node:child_process";
-import type Stream from "node:stream";
-
-interface MCPBaseConfig {
-  id: string;
-  name: string;
-  description?: string;
-  transport: "streamableHttp" | "stdio" | "inMemory";
-  builtin?: boolean; // True for internal/built-in servers
-  toolWhitelist?: string[];
-  enabled?: boolean;
-}
-
-interface MCPHttpServerConfig extends MCPBaseConfig {
-  transport: "streamableHttp";
-  url: string; // For HTTP-based transports
-  headers?: Record<string, string>;
-  version?: string;
-  timeoutMs?: number;
-}
-
-interface MCPStdioServerConfig extends MCPBaseConfig {
-  transport: "stdio";
-  command: string; // For stdio transport
-  args?: string[];
-  env?: Record<string, string>;
-  stderr?: IOType | Stream | number;
-  cwd?: string;
-}
-
-interface MCPInMemoryServerConfig extends MCPBaseConfig {
-  transport: "inMemory";
-  inMemoryServerId: string; // Identifier for the in-memory server implementation
-}
-
-export type MCPServerConfig = MCPHttpServerConfig | MCPStdioServerConfig | MCPInMemoryServerConfig;
-
-export interface MCPToolSummary {
-  name: string;
-  description?: string;
-}
+export type {
+  MCPHttpServerConfig,
+  MCPInMemoryServerConfig,
+  MCPServerConfig,
+  MCPStdioServerConfig,
+  MCPToolSummary,
+  Transport,
+} from "../../../shared/types/mcp";

src/shared/types/mcp.ts

@@ -25,3 +25,45 @@ export interface MCPStep {
   timestamp?: number;
   autoApproveAt?: number;
 }
+
+export type Transport = "streamableHttp" | "stdio" | "inMemory";
+
+export interface MCPBaseConfig {
+  id: string;
+  name: string;
+  description?: string;
+  transport: Transport;
+  builtin?: boolean; // True for internal/built-in servers
+  toolWhitelist?: string[];
+  enabled?: boolean;
+}
+
+export interface MCPHttpServerConfig extends MCPBaseConfig {
+  transport: "streamableHttp";
+  url: string; // For HTTP-based transports
+  headers?: Record<string, string>;
+  version?: string;
+  timeoutMs?: number;
+}
+
+export interface MCPStdioServerConfig extends MCPBaseConfig {
+  transport: "stdio";
+  command: string; // For stdio transport
+  args?: string[];
+  env?: Record<string, string>;
+  stderr?: "inherit" | "ignore" | "pipe";
+  cwd?: string;
+}
+
+export interface MCPInMemoryServerConfig extends MCPBaseConfig {
+  transport: "inMemory";
+  inMemoryServerId?: string; // Identifier for the in-memory server implementation
+  builtin?: true;
+}
+
+export type MCPServerConfig = MCPHttpServerConfig | MCPStdioServerConfig | MCPInMemoryServerConfig;
+
+export interface MCPToolSummary {
+  name: string;
+  description?: string;
+}

src/ui/src/components/settings/mcp/McpServerForm.tsx

@@ -1,4 +1,5 @@
 import { zodResolver } from "@hookform/resolvers/zod";
+import type { MCPServerConfig, Transport } from "@shared/types/mcp";
 import { type UseFormReturn, useForm } from "react-hook-form";
 import { z } from "zod";
 import { Accordion, AccordionContent, AccordionItem, AccordionTrigger } from "../../ui/accordion";
@@ -16,41 +17,7 @@ import { Input } from "../../ui/input";
 import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "../../ui/select";
 import { Textarea } from "../../ui/textarea";
 
-export type Transport = "streamableHttp" | "stdio" | "inMemory";
-
-type MCPBaseConfig = {
-  id: string | null;
-  name: string;
-  description?: string;
-  transport: Transport;
-  builtin?: boolean;
-  toolWhitelist?: string[];
-  enabled?: boolean;
-};
-
-type MCPHttpServerConfig = MCPBaseConfig & {
-  transport: "streamableHttp";
-  url: string;
-  headers?: Record<string, string>;
-  version?: string;
-  timeoutMs?: number;
-};
-
-type MCPStdioServerConfig = MCPBaseConfig & {
-  transport: "stdio";
-  command: string;
-  args?: string[];
-  env?: Record<string, string>;
-  cwd?: string;
-  stderr?: "inherit" | "ignore" | "pipe";
-};
-
-type MCPInternalServerConfig = MCPBaseConfig & {
-  transport: "inMemory";
-  builtin: true;
-};
-
-export type MCPServerConfig = MCPHttpServerConfig | MCPStdioServerConfig | MCPInternalServerConfig;
+export type { MCPServerConfig, Transport };
 
 export const mcpServerSchema = z
   .object({
@@ -468,7 +435,7 @@ export function McpServerFormWrapper({
       }
 
       const config: MCPServerConfig = {
-        id: initialData?.id ?? null,
+        id: initialData?.id ?? "",
         name: data.name.trim(),
         transport: "streamableHttp",
         url: data.url?.trim() ?? "",
@@ -477,7 +444,6 @@ export function McpServerFormWrapper({
         version: data.version?.trim() || undefined,
         timeoutMs: typeof data.timeoutMs === "number" ? data.timeoutMs : undefined,
       };
-
       await onSubmit(config);
       return;
     }
@@ -546,7 +512,7 @@ export function McpServerFormWrapper({
     const command = sanitizeSegment(data.command ?? "");
 
     const config: MCPServerConfig = {
-      id: initialData?.id ?? null,
+      id: initialData?.id ?? "",
       name: data.name.trim(),
       transport: "stdio",
       command,