Skip to content

Commit 8952a93

Browse files
committed
remove active related dead codes
1 parent c79f97b commit 8952a93

File tree

7 files changed

+6
-50
lines changed

7 files changed

+6
-50
lines changed

src/backend/ipc/channels.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,10 @@ export const IPC_CHANNELS = {
6363

6464
// Settings
6565
SETTINGS_GET_ALL_PROMPTS: "settings:get-all-prompts",
66-
SETTINGS_GET_ACTIVE_PROMPT: "settings:get-active-prompt",
6766
SETTINGS_GET_TEMPLATES: "settings:get-templates",
6867
SETTINGS_ADD_PROMPT: "settings:add-prompt",
6968
SETTINGS_UPDATE_PROMPT: "settings:update-prompt",
7069
SETTINGS_DELETE_PROMPT: "settings:delete-prompt",
71-
SETTINGS_SET_ACTIVE_PROMPT: "settings:set-active-prompt",
7270
SETTINGS_CLEAR_CUSTOM_PROMPTS: "settings:clear-custom-prompts",
7371
SETTINGS_HOTKEY_UPDATE: "settings:hotkey-update",
7472

src/backend/ipc/custom-prompt-settings-handlers.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export class CustomPromptSettingsIPCHandlers {
99
constructor() {
1010
ipcMain.handle(IPC_CHANNELS.SETTINGS_GET_ALL_PROMPTS, () => this.store.getAllPrompts());
1111
ipcMain.handle(IPC_CHANNELS.SETTINGS_GET_TEMPLATES, () => this.store.getTemplates());
12-
ipcMain.handle(IPC_CHANNELS.SETTINGS_GET_ACTIVE_PROMPT, () => this.store.getActivePrompt());
1312
ipcMain.handle(
1413
IPC_CHANNELS.SETTINGS_ADD_PROMPT,
1514
(_, prompt: Omit<CustomPrompt, "id" | "createdAt" | "updatedAt">) =>
@@ -23,9 +22,6 @@ export class CustomPromptSettingsIPCHandlers {
2322
ipcMain.handle(IPC_CHANNELS.SETTINGS_DELETE_PROMPT, (_, id: string) =>
2423
this.store.deletePrompt(id),
2524
);
26-
ipcMain.handle(IPC_CHANNELS.SETTINGS_SET_ACTIVE_PROMPT, (_, id: string) =>
27-
this.store.setActivePrompt(id),
28-
);
2925
ipcMain.handle(IPC_CHANNELS.SETTINGS_CLEAR_CUSTOM_PROMPTS, () =>
3026
this.store.clearCustomPrompts(),
3127
);

src/backend/ipc/process-video-handlers.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { TranscriptionModelProvider } from "../services/mcp/transcription-model-
1414
import { SendWorkItemDetailsToPortal, WorkItemDtoSchema } from "../services/portal/actions";
1515
import type { ProjectDto } from "../services/prompt/prompt-manager";
1616
import { ShaveService } from "../services/shave/shave-service";
17-
import { CustomPromptStorage } from "../services/storage/custom-prompt-storage";
1817
import { VideoMetadataBuilder } from "../services/video/video-metadata-builder";
1918
import { YouTubeDownloadService } from "../services/video/youtube-service";
2019
import { McpWorkflowAdapter } from "../services/workflow/mcp-workflow-adapter";
@@ -44,7 +43,6 @@ export const TranscriptSummarySchema = z.object({
4443
export class ProcessVideoIPCHandlers {
4544
private readonly youtube = YouTubeClient.getInstance();
4645
private ffmpegService = FFmpegService.getInstance();
47-
private readonly customPromptStorage = CustomPromptStorage.getInstance();
4846
private readonly metadataBuilder: VideoMetadataBuilder;
4947
private readonly youtubeDownloadService = YouTubeDownloadService.getInstance();
5048
private lastVideoFilePath: string | undefined;
@@ -109,8 +107,7 @@ export class ProcessVideoIPCHandlers {
109107
workflowManager.startStage(WorkflowProgressStage.EXECUTING_TASK);
110108
notify(ProgressStage.EXECUTING_TASK);
111109

112-
const customPrompt = await this.customPromptStorage.getActivePrompt();
113-
const serverFilter = customPrompt?.selectedMcpServerIds;
110+
const serverFilter = projectDetails?.selectedMcpServerIds;
114111

115112
const filePath =
116113
this.lastVideoFilePath && fs.existsSync(this.lastVideoFilePath)
@@ -323,8 +320,7 @@ export class ProcessVideoIPCHandlers {
323320

324321
notify(ProgressStage.EXECUTING_TASK, { transcriptText, intermediateOutput });
325322

326-
const customPrompt = await this.customPromptStorage.getActivePrompt();
327-
const serverFilter = customPrompt?.selectedMcpServerIds;
323+
const serverFilter = projectDetails?.selectedMcpServerIds;
328324

329325
const mcpAdapter = new McpWorkflowAdapter(workflowManager, {
330326
transcriptText,

src/backend/preload.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,10 @@ const IPC_CHANNELS = {
8181

8282
// Settings
8383
SETTINGS_GET_ALL_PROMPTS: "settings:get-all-prompts",
84-
SETTINGS_GET_ACTIVE_PROMPT: "settings:get-active-prompt",
8584
SETTINGS_GET_TEMPLATES: "settings:get-templates",
8685
SETTINGS_ADD_PROMPT: "settings:add-prompt",
8786
SETTINGS_UPDATE_PROMPT: "settings:update-prompt",
8887
SETTINGS_DELETE_PROMPT: "settings:delete-prompt",
89-
SETTINGS_SET_ACTIVE_PROMPT: "settings:set-active-prompt",
9088
SETTINGS_CLEAR_CUSTOM_PROMPTS: "settings:clear-custom-prompts",
9189

9290
// General User Settings
@@ -270,15 +268,12 @@ const electronAPI = {
270268
},
271269
settings: {
272270
getAllPrompts: () => ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_GET_ALL_PROMPTS),
273-
getActivePrompt: () => ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_GET_ACTIVE_PROMPT),
274271
getTemplates: () => ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_GET_TEMPLATES),
275272
addPrompt: (prompt: { name: string; content: string }) =>
276273
ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_ADD_PROMPT, prompt),
277274
updatePrompt: (id: string, updates: { name?: string; content?: string }) =>
278275
ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_UPDATE_PROMPT, id, updates),
279276
deletePrompt: (id: string) => ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_DELETE_PROMPT, id),
280-
setActivePrompt: (id: string) =>
281-
ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_SET_ACTIVE_PROMPT, id),
282277
clearCustomPrompts: () => ipcRenderer.invoke(IPC_CHANNELS.SETTINGS_CLEAR_CUSTOM_PROMPTS),
283278
},
284279
userInteraction: {

src/backend/services/prompt/prompt-manager.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export interface PromptSummary {
99
id: string;
1010
name: string;
1111
description?: string;
12-
isActive: boolean;
1312
source: "local" | "remote";
1413
}
1514

@@ -36,6 +35,7 @@ export interface ProjectDto {
3635
gitHubProjectId?: string;
3736
placeItemOnTopOfProductBacklog: boolean;
3837
desktopAgentProjectPrompt?: string;
38+
selectedMcpServerIds?: string[];
3939
}
4040

4141
export class PromptManager {
@@ -79,8 +79,7 @@ export class PromptManager {
7979
id: p.id,
8080
name: p.name,
8181
description: p.description,
82-
isActive: true,
83-
source: "local",
82+
source: "local" as const,
8483
}));
8584
} catch (error) {
8685
console.error("Failed to fetch local prompts:", error);
@@ -160,8 +159,7 @@ export class PromptManager {
160159
id: item.id,
161160
name: item.title,
162161
description: item.description,
163-
isActive: true,
164-
source: "remote",
162+
source: "remote" as const,
165163
}));
166164
} catch (error) {
167165
console.error("Failed to fetch remote prompts:", error);
@@ -183,9 +181,8 @@ export class PromptManager {
183181
id: localPrompt.id,
184182
name: localPrompt.name,
185183
description: localPrompt.description,
186-
// Map local prompt content to desktopAgentProjectPrompt
187184
desktopAgentProjectPrompt: localPrompt.content,
188-
// Set defaults for other required fields
185+
selectedMcpServerIds: localPrompt.selectedMcpServerIds,
189186
videoHostType: "SharePoint", // Default
190187
recentWorkItemsCount: 0,
191188
allowWebhooks: false,

src/backend/services/storage/custom-prompt-storage.ts

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export interface CustomPrompt {
1515

1616
interface CustomPromptData {
1717
prompts: CustomPrompt[];
18-
activePromptId: string | null;
1918
}
2019

2120
const SETTINGS_FILE = "custom-settings.enc";
@@ -32,7 +31,6 @@ const TEMPLATE_PROMPT: CustomPrompt = {
3231

3332
const DEFAULT_SETTINGS: CustomPromptData = {
3433
prompts: [TEMPLATE_PROMPT],
35-
activePromptId: "default",
3634
};
3735

3836
export class CustomPromptStorage extends BaseSecureStorage {
@@ -103,12 +101,6 @@ export class CustomPromptStorage extends BaseSecureStorage {
103101
return settings.prompts.filter((p) => p.isTemplate);
104102
}
105103

106-
async getActivePrompt(): Promise<CustomPrompt | null> {
107-
const settings = await this.loadSettings();
108-
if (!settings.activePromptId) return null;
109-
return settings.prompts.find((p) => p.id === settings.activePromptId) || null;
110-
}
111-
112104
async getPromptById(id: string): Promise<CustomPrompt | null> {
113105
const settings = await this.loadSettings();
114106
return settings.prompts.find((p) => p.id === id) || null;
@@ -160,21 +152,6 @@ export class CustomPromptStorage extends BaseSecureStorage {
160152

161153
settings.prompts = settings.prompts.filter((p) => p.id !== id);
162154

163-
// If deleted prompt was active, switch to default
164-
if (settings.activePromptId === id) {
165-
settings.activePromptId = "default";
166-
}
167-
168-
await this.saveSettings(settings);
169-
return true;
170-
}
171-
172-
async setActivePrompt(id: string): Promise<boolean> {
173-
const settings = await this.loadSettings();
174-
const prompt = settings.prompts.find((p) => p.id === id);
175-
if (!prompt) return false;
176-
177-
settings.activePromptId = id;
178155
await this.saveSettings(settings);
179156
return true;
180157
}
@@ -183,7 +160,6 @@ export class CustomPromptStorage extends BaseSecureStorage {
183160
const settings = await this.loadSettings();
184161

185162
settings.prompts = [TEMPLATE_PROMPT];
186-
settings.activePromptId = TEMPLATE_PROMPT.id;
187163

188164
await this.saveSettings(settings);
189165
}

src/ui/src/services/ipc-client.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ declare global {
139139
};
140140
settings: {
141141
getAllPrompts: () => Promise<Array<CustomPrompt>>;
142-
getActivePrompt: () => Promise<CustomPrompt | null>;
143142
getTemplates: () => Promise<Array<CustomPrompt>>;
144143
addPrompt: (prompt: {
145144
name: string;
@@ -157,7 +156,6 @@ declare global {
157156
},
158157
) => Promise<boolean>;
159158
deletePrompt: (id: string) => Promise<boolean>;
160-
setActivePrompt: (id: string) => Promise<boolean>;
161159
clearCustomPrompts: () => Promise<void>;
162160
};
163161
userInteraction: {

0 commit comments

Comments
 (0)