fix: Updating non-selected text and other fixes (#298)

## Description

Updating the default text when no category/related rule is selected.
We are unable to set the selected items as the title, must be the URI

SSWConsulting/SSW.Rules#2150
SSWConsulting/SSW.Rules#2153

Author: jakebayliss

tina/collection/category.tsx

@@ -2,8 +2,8 @@ import React from "react";
 import { Collection, wrapFieldsWithMeta } from "tinacms";
 import { embedTemplates } from "@/components/embeds";
 import { generateGuid } from "@/utils/guidGenerationUtils";
-import { PaginatedRuleSelectorInput } from "../fields/paginatedRuleSelector";
 import { ReadonlyUriInput } from "../fields/ReadonlyUriInput";
+import { RuleSelector } from "../fields/RuleSelector";
 import { historyBeforeSubmit, historyFields } from "./shared/historyFields";
 import { toolbarFields } from "./shared/toolbarFields";
 
@@ -210,9 +210,7 @@ const Category: Collection = {
           description:
             "Note: The rules listed here are only used for sorting on the category page. To assign a category, open the specific rule and select the category there. This list updates automatically based on those assignments, but any rule added directly to this list will not update on its own.",
           ui: {
-            itemProps: (item) => ({
-              label: item.rule?.split("/").at(-2) || "Rule is not selected",
-            }),
+            itemProps: (item) => ({ label: item.rule?.split("/").at(-2) || "Select a Rule" }),
             max: -1, // this disable the rules to be added to the category
           },
           fields: [
@@ -222,7 +220,7 @@ const Category: Collection = {
               name: "rule",
               collections: ["rule"],
               ui: {
-                component: PaginatedRuleSelectorInput,
+                component: RuleSelector,
               },
             },
           ],

tina/collection/rule.tsx

@@ -5,14 +5,14 @@ import { generateGuid } from "@/utils/guidGenerationUtils";
 import { countEndIntro } from "@/utils/mdxNodeUtils";
 import { CategorySelectorInput } from "../fields/CategorySelector";
 import { ConditionalHiddenField } from "../fields/ConditionalHiddenField";
-import { PaginatedRuleSelectorInput } from "../fields/paginatedRuleSelector";
 import { ReadonlyUriInput } from "../fields/ReadonlyUriInput";
+import { RuleSelector } from "../fields/RuleSelector";
 import { historyBeforeSubmit, historyFields } from "./shared/historyFields";
 import { toolbarFields } from "./shared/toolbarFields";
 
 const Rule: Collection = {
   name: "rule",
-  label: "Rule",
+  label: "Rules",
   path: "public/uploads/rules",
   format: "mdx",
   match: {
@@ -69,14 +69,11 @@ const Rule: Collection = {
       type: "object",
       name: "categories",
       label: "Categories",
-      description: "Assigns one or more categories to the rule",
+      description: "Assigns one or more categories to the rule.",
       list: true,
       searchable: false,
       ui: {
-        itemProps: (item) => {
-          const categoryTitle = item?.category ? `🔗 ${item?.category?.split("/").at(-1)?.replace(".mdx", "")}` : "Unselected Category";
-          return { label: categoryTitle };
-        },
+        itemProps: (item) => ({ label: item?.category ? `📂 ${item?.category?.split("/").at(-1)?.replace(".mdx", "")}` : "Select a Category" }),
         component: ConditionalHiddenField,
       },
       fields: [
@@ -100,9 +97,7 @@ const Rule: Collection = {
       list: true,
       searchable: false,
       ui: {
-        itemProps: (item) => {
-          return { label: "👤 " + (item?.title ?? "Author") };
-        },
+        itemProps: (item) => ({ label: "👤 " + (item?.title ?? "Author") }),
         defaultItem: {
           title: "Bob Northwind",
           url: "https://ssw.com.au/people/bob-northwind",
@@ -136,7 +131,7 @@ const Rule: Collection = {
       searchable: false,
       ui: {
         itemProps: (item) => ({
-          label: item.rule?.split("/").at(-2) || "Rule is not selected",
+          label: item.rule?.split("/").at(-2) || "Select a Related Rule",
         }),
         component: ConditionalHiddenField,
       },
@@ -148,7 +143,7 @@ const Rule: Collection = {
           description: "This rule list may not include newly created rules for up to one hour. It is updated based on the main branch after that time.",
           collections: ["rule"],
           ui: {
-            component: PaginatedRuleSelectorInput,
+            component: RuleSelector,
           },
         },
       ],

tina/fields/paginatedRuleSelector.tsx tina/fields/RuleSelector.tsxtina/fields/paginatedRuleSelector.tsx renamed to tina/fields/RuleSelector.tsx

@@ -16,7 +16,7 @@ interface Rule {
 const MIN_SEARCH_LENGTH = 2;
 const INITIAL_RULES_COUNT = 20;
 
-export const PaginatedRuleSelectorInput: React.FC<any> = ({ input }) => {
+export const RuleSelector: React.FC<any> = ({ input }) => {
   const [filter, setFilter] = useState("");
   const [allRules, setAllRules] = useState<Rule[]>([]);
   const [filteredRules, setFilteredRules] = useState<Rule[]>([]);
@@ -203,9 +203,6 @@ export const PaginatedRuleSelectorInput: React.FC<any> = ({ input }) => {
                                     <div className="font-medium text-gray-900 text-sm leading-5 truncate">{rule.title}</div>
                                     <div className="text-xs text-gray-500 leading-4 truncate">{rule.uri}</div>
                                   </div>
-                                  <div className="text-xs text-gray-500 leading-4 whitespace-nowrap text-right">
-                                    Last updated: {formatLastUpdated(rule.lastUpdated)}
-                                  </div>
                                 </div>
                               </button>
                             );