Skip to content

Commit c2a4770

Browse files
Yannick Fertrefourmone
authored andcommitted
drm/stm: lvds: remove clock enable/disable
This issue rarely occurs when requesting to enable/disable the LVDS pixel clock. The LVDS driver enables/disables the reference and peripheral clocks. This is not necessary, as the clock framework does this itself (the reference clock is the parent of the LVDS pixel clock). Change-Id: I4289ce9d3636e4b3fbeef32572af7ef8634c439c Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com> Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/458856 ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
1 parent b4b02e5 commit c2a4770

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

drivers/gpu/drm/stm/lvds.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -558,19 +558,6 @@ static int lvds_pixel_clk_enable(struct clk_hw *hw)
558558
int ret;
559559
u32 reg;
560560

561-
ret = clk_prepare_enable(lvds->pclk);
562-
if (ret) {
563-
DRM_ERROR("Failed to enable pclk: %d\n", ret);
564-
return ret;
565-
}
566-
567-
ret = clk_prepare_enable(lvds->pllref_clk);
568-
if (ret) {
569-
clk_disable_unprepare(lvds->pclk);
570-
DRM_ERROR("Failed to enable pllref_clk: %d\n", ret);
571-
return ret;
572-
}
573-
574561
/* In case we are operating in dual link the second PHY is set before the primary PHY. */
575562
if (lvds->secondary) {
576563
phy = lvds->secondary;
@@ -637,9 +624,6 @@ static void lvds_pixel_clk_disable(struct clk_hw *hw)
637624
lvds_clear(lvds, lvds->secondary->base + lvds->secondary->ofs.GCR,
638625
PHY_GCR_DIV_RSTN | PHY_GCR_RSTZ);
639626
}
640-
641-
clk_disable_unprepare(lvds->pllref_clk);
642-
clk_disable_unprepare(lvds->pclk);
643627
}
644628

645629
static unsigned long lvds_pixel_clk_recalc_rate(struct clk_hw *hw,

0 commit comments

Comments
 (0)