Fix misuse of STM32MP_METADATA_NAME #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ENABLE_FLASHLAYOUT_CONFIG_FWUP is disabled (set to 0)
STM32MP_METADATA_NAME variable will be empty and this
causes an endless parsing WARNING:
WARNING: <..>.bb: Variable key FLASHLAYOUT_PARTITION_ENABLE:${STM32MP_SSBL1_PROGRAMMER_NAME} (-)
replaces original key FLASHLAYOUT_PARTITION_ENABLE: (${@bb.utils.contains('MACHINE_FEATURES', 'fw-update', 'PD', 'PED', d)})
what happens when STM32MP_METADATA_NAME is empty, the following
FLASHLAYOUT_PARTITION_ENABLE:${STM32MP_METADATA_NAME} will be just:
FLASHLAYOUT_PARTITION_ENABLE:
which triggers these errors saying that other variants replaces it with other content.
This commit sets the default metadata variable and introduces a new variable
to simply tell if it needs to be enabled in the flashlayout or not based on:
ENABLE_FLASHLAYOUT_CONFIG_FWUP.
This also fixes another line:
ENABLE_FLASHLAYOUT_CONFIG_FWUP ?= "${@bb.utils.contains('MACHINE_FEATURES', 'fw-update', '1', '0', d)}"
which was commented and "1" is forced.
Signed-off-by: Talel BELHAJSALEM <[email protected]>
Contributor
|
Many thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ENABLE_FLASHLAYOUT_CONFIG_FWUPis disabled (set to 0) thenSTM32MP_METADATA_NAMEvariable will be empty and this causes an endless parsingWARNING:what happens when
STM32MP_METADATA_NAMEis empty, the followingFLASHLAYOUT_PARTITION_ENABLE:${STM32MP_METADATA_NAME}will be justFLASHLAYOUT_PARTITION_ENABLE:which triggers these errors saying that other variants replaces it with other content.
This commit sets the default metadata variable and introduces a new variable to simply tell if it needs to be enabled in the flashlayout or not based on
ENABLE_FLASHLAYOUT_CONFIG_FWUP.This also fixes another line:
ENABLE_FLASHLAYOUT_CONFIG_FWUP ?= "${@bb.utils.contains('MACHINE_FEATURES', 'fw-update', '1', '0', d)}"which was commented and
1is forced.