Include of stm32h7xx_hal_eth_ex_legacy.h added in stm32h7xx_hal_eth_legacy.h

[aschlueter-dev]

Describe the set-up

• Board: NUCLEO-H743ZI2
• IDE/Compiler: SEGGER Embedded Studio 8.24 / SEGGER Compiler

Describe the bug
A change was made to the file Inc/Legacy/stm32h7xx_hal_eth_legacy.h at line 1561:

#include "stm32h7xx_hal_eth_ex_legacy.h"

This line was added to the file.

How To Reproduce

1. Build the project for NUCLEO-H743ZI2 using SEGGER Embedded Studio 8.24 and the SEGGER Compiler.
2. Observe the effect of the new include directive in stm32h7xx_hal_eth_legacy.h.

Additional context
Please review whether this modification is correct and if any additional changes are required for compatibility or functionality.

Screenshots
N/A

[ALABSTM]

Hello @aschlueter-dev,

Its been around 3 years that this change has been made. Would you please mind sharing a description of the "effect" you mentioned, logs, warnings or error messages, if any?

With regards,

[aschlueter-dev]

Hello @ALABSTM,

I didn't express myself clearly in my message.

I am using the STM32CubeH7 v1.12.1 module.
According to STM32CubeMX version 6.15.0, this is the current version.
It contains the sub-module stm32h7xx-hal-driver with version 1.11.5.

In stm32h7xx-hal-driver, the folder /Inc/Legacy contains the file stm32h7xx_hal_eth_legacy.h.

stm32h7xx_hal_eth_legacy.h has the following include in line 1561:

#include "stm32h7xx_hal_eth_ex.h"

When I compile the project, I get the following error messages:

7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:135:19: error: conflicting types for 'HAL_ETHEx_SetL4FilterConfig'; have 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  ETH_L4FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  ETH_L4FilterConfigTypeDef *)'}
7>   135 | HAL_StatusTypeDef HAL_ETHEx_SetL4FilterConfig(ETH_HandleTypeDef *heth, uint32_t Filter , ETH_L4FilterConfigTypeDef *pL4FilterConfig)
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> In file included from C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/Legacy/stm32h7xx_hal_eth_legacy.h:1561,
7>                  from C:/Users/as/projects/p21/e_app/aif/projects/CUBE_METL100_V1_1/Core/Inc/stm32h7xx_hal_conf.h:291,
7>                  from C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal.h:29,
7>                  from C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:21:
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:323:19: note: previous declaration of 'HAL_ETHEx_SetL4FilterConfig' with type 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  const ETH_L4FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  const ETH_L4FilterConfigTypeDef *)'}
7>   323 | HAL_StatusTypeDef HAL_ETHEx_SetL4FilterConfig(ETH_HandleTypeDef *heth, uint32_t Filter,
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:174:19: error: conflicting types for 'HAL_ETHEx_GetL4FilterConfig'; have 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  ETH_L4FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  ETH_L4FilterConfigTypeDef *)'}
7>   174 | HAL_StatusTypeDef HAL_ETHEx_GetL4FilterConfig(ETH_HandleTypeDef *heth, uint32_t Filter, ETH_L4FilterConfigTypeDef *pL4FilterConfig)
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:319:19: note: previous declaration of 'HAL_ETHEx_GetL4FilterConfig' with type 'HAL_StatusTypeDef(const ETH_HandleTypeDef *, uint32_t,  ETH_L4FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(const ETH_HandleTypeDef *, long unsigned int,  ETH_L4FilterConfigTypeDef *)'}
7>   319 | HAL_StatusTypeDef HAL_ETHEx_GetL4FilterConfig(const ETH_HandleTypeDef *heth, uint32_t Filter,
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:206:19: error: conflicting types for 'HAL_ETHEx_SetL3FilterConfig'; have 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  ETH_L3FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  ETH_L3FilterConfigTypeDef *)'}
7>   206 | HAL_StatusTypeDef HAL_ETHEx_SetL3FilterConfig(ETH_HandleTypeDef *heth, uint32_t Filter, ETH_L3FilterConfigTypeDef *pL3FilterConfig)
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:321:19: note: previous declaration of 'HAL_ETHEx_SetL3FilterConfig' with type 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  const ETH_L3FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  const ETH_L3FilterConfigTypeDef *)'}
7>   321 | HAL_StatusTypeDef HAL_ETHEx_SetL3FilterConfig(ETH_HandleTypeDef *heth, uint32_t Filter,
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:259:19: error: conflicting types for 'HAL_ETHEx_GetL3FilterConfig'; have 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  ETH_L3FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  ETH_L3FilterConfigTypeDef *)'}
7>   259 | HAL_StatusTypeDef HAL_ETHEx_GetL3FilterConfig(ETH_HandleTypeDef *heth, uint32_t Filter, ETH_L3FilterConfigTypeDef *pL3FilterConfig)
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:317:19: note: previous declaration of 'HAL_ETHEx_GetL3FilterConfig' with type 'HAL_StatusTypeDef(const ETH_HandleTypeDef *, uint32_t,  ETH_L3FilterConfigTypeDef *)' {aka 'HAL_StatusTypeDef(const ETH_HandleTypeDef *, long unsigned int,  ETH_L3FilterConfigTypeDef *)'}
7>   317 | HAL_StatusTypeDef HAL_ETHEx_GetL3FilterConfig(const ETH_HandleTypeDef *heth, uint32_t Filter,
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:320:19: error: conflicting types for 'HAL_ETHEx_GetRxVLANConfig'; have 'HAL_StatusTypeDef(ETH_HandleTypeDef *, ETH_RxVLANConfigTypeDef *)'
7>   320 | HAL_StatusTypeDef HAL_ETHEx_GetRxVLANConfig(ETH_HandleTypeDef *heth, ETH_RxVLANConfigTypeDef *pVlanConfig)
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:329:19: note: previous declaration of 'HAL_ETHEx_GetRxVLANConfig' with type 'HAL_StatusTypeDef(const ETH_HandleTypeDef *, ETH_RxVLANConfigTypeDef *)'
7>   329 | HAL_StatusTypeDef HAL_ETHEx_GetRxVLANConfig(const ETH_HandleTypeDef *heth, ETH_RxVLANConfigTypeDef *pVlanConfig);
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~
7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:392:19: error: conflicting types for 'HAL_ETHEx_GetTxVLANConfig'; have 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  ETH_TxVLANConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  ETH_TxVLANConfigTypeDef *)'}
7>   392 | HAL_StatusTypeDef HAL_ETHEx_GetTxVLANConfig(ETH_HandleTypeDef *heth, uint32_t VLANTag ,ETH_TxVLANConfigTypeDef *pVlanConfig)
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:332:19: note: previous declaration of 'HAL_ETHEx_GetTxVLANConfig' with type 'HAL_StatusTypeDef(const ETH_HandleTypeDef *, uint32_t,  ETH_TxVLANConfigTypeDef *)' {aka 'HAL_StatusTypeDef(const ETH_HandleTypeDef *, long unsigned int,  ETH_TxVLANConfigTypeDef *)'}
7>   332 | HAL_StatusTypeDef HAL_ETHEx_GetTxVLANConfig(const ETH_HandleTypeDef *heth, uint32_t VLANTag,
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~
7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:426:19: error: conflicting types for 'HAL_ETHEx_SetTxVLANConfig'; have 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  ETH_TxVLANConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  ETH_TxVLANConfigTypeDef *)'}
7>   426 | HAL_StatusTypeDef HAL_ETHEx_SetTxVLANConfig(ETH_HandleTypeDef *heth, uint32_t VLANTag ,ETH_TxVLANConfigTypeDef *pVlanConfig)
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:334:19: note: previous declaration of 'HAL_ETHEx_SetTxVLANConfig' with type 'HAL_StatusTypeDef(ETH_HandleTypeDef *, uint32_t,  const ETH_TxVLANConfigTypeDef *)' {aka 'HAL_StatusTypeDef(ETH_HandleTypeDef *, long unsigned int,  const ETH_TxVLANConfigTypeDef *)'}
7>   334 | HAL_StatusTypeDef HAL_ETHEx_SetTxVLANConfig(ETH_HandleTypeDef *heth, uint32_t VLANTag,
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~
7> C:\Users\as\projects\p21\e_bsp\stm32-fw-h7-drivers\STM32H7xx_HAL_Driver\Src\Legacy\stm32h7xx_hal_eth_ex.c:533:10: error: conflicting types for 'HAL_ETHEx_GetMACLPIEvent'; have 'uint32_t(ETH_HandleTypeDef *)' {aka 'long unsigned int(ETH_HandleTypeDef *)'}
7>   533 | uint32_t HAL_ETHEx_GetMACLPIEvent(ETH_HandleTypeDef *heth)
7>       |          ^~~~~~~~~~~~~~~~~~~~~~~~
7> C:/Users/as/projects/p21/e_bsp/stm32-fw-h7-drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_eth_ex.h:342:19: note: previous declaration of 'HAL_ETHEx_GetMACLPIEvent' with type 'uint32_t(const ETH_HandleTypeDef *)' {aka 'long unsigned int(const ETH_HandleTypeDef *)'}
7>   342 | uint32_t          HAL_ETHEx_GetMACLPIEvent(const ETH_HandleTypeDef *heth);
7>       |                   ^~~~~~~~~~~~~~~~~~~~~~~~
7> Build failed, exit status 0x1

If I modify this include as follows, it works without errors:

#include "stm32h7xx_hal_eth_ex_legacy.h"

It looks to me like they forgot to adjust this include when the ETH files became legacy and the file names were renamed.

[ASAHSTM]

ST Internal Reference: 221220

[ASAHSTM]

Hello @aschlueter-dev,

Thank you for your report.

However, on our side, we are unable to reproduce the problem. The project works without errors with either inclusion of #include "stm32h7xx_hal_eth_ex_legacy.h" or #include "stm32h7xx_hal_eth_ex.h" since the two files do not have differences that cause errors.

Could you please specify how you implemented the legacy file after project generation so that we can assist you further?

With Regards,