|
| 1 | +# NOT READY FOR REVIEW |
| 2 | +- (Edit the above to reflect status) |
| 3 | + |
| 4 | +# Summary |
| 5 | +- TL;DR - what's this PR for? |
| 6 | + |
| 7 | +# Review By (Date) |
| 8 | +- When does this need to be reviewed by? |
| 9 | + |
| 10 | +# Criticality |
| 11 | +- How critical is this PR on a 1-10 scale? Also see [Severity Assessment](https://stanfordits.atlassian.net/browse/D8CORE-1705). |
| 12 | +- E.g., it affects one site, or every site and product? |
| 13 | + |
| 14 | +# Urgency |
| 15 | +- How urgent is this? (Normal, High) |
| 16 | + |
| 17 | +# Review Tasks |
| 18 | + |
| 19 | +## Setup tasks and/or behavior to test |
| 20 | + |
| 21 | +1. Check out this branch |
| 22 | +2. Rebuild Cache and import config `drush cr ; drush ci` |
| 23 | +3. Navigate to... |
| 24 | +4. Verify... |
| 25 | + |
| 26 | +### Site Configuration Sync |
| 27 | + |
| 28 | +- Is there a config:export in this PR that changes the config sync directory? |
| 29 | + |
| 30 | +## Front End Validation |
| 31 | +- [ ] Design is approved by @ user? |
| 32 | +- [ ] HTML validation: Is the markup using the appropriate semantic tags and [passes validation](https://validator.w3.org/nu/)? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)? |
| 33 | +- [ ] Cross-browser testing: Has been performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)? |
| 34 | +- [ ] Automated accessibility: Scans performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)? |
| 35 | +- [ ] Manual accessibility: Manually tested? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)? |
| 36 | + |
| 37 | +## Backend / Functional Validation |
| 38 | +### Code |
| 39 | +- [ ] Are the naming conventions following our standards? |
| 40 | +- [ ] Does the code have sufficient inline comments? |
| 41 | +- [ ] Is there anything in this code that would be hidden or hard to discover through the UI? |
| 42 | +- [ ] Are there any [code smells](https://blog.codinghorror.com/code-smells/)? |
| 43 | +- [ ] Are tests provided? eg (unit, behat, or codeception) |
| 44 | + |
| 45 | +### Code security |
| 46 | +- [ ] Are all [forms properly sanitized](https://www.drupal.org/docs/8/security/drupal-8-sanitizing-output)? |
| 47 | +- [ ] Any obvious [security flaws or new areas for attack](https://www.drupal.org/docs/8/security)? |
| 48 | + |
| 49 | +## General |
| 50 | +- [ ] Is there anything included in this PR that is not related to the problem it is trying to solve? |
| 51 | +- [ ] Is the approach to the problem appropriate? |
| 52 | + |
| 53 | +# Affected Projects or Products |
| 54 | +- Does this PR impact any particular projects, products, or modules? |
| 55 | + |
| 56 | +# Associated Issues and/or People |
| 57 | +- JIRA ticket(s) |
| 58 | +- Other PRs |
| 59 | +- Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.) |
| 60 | +- Anyone who should be notified? (`@mention` them here) |
| 61 | + |
| 62 | +# Resources |
| 63 | +- [AMP Tool](https://stanford.levelaccess.net/index.php) |
| 64 | +- [Accessibility Manual Test Script](https://docs.google.com/document/d/1ZXJ9RIUNXsS674ow9j3qJ2g1OAkCjmqMXl0Gs8XHEPQ/edit?usp=sharing) |
| 65 | +- [HTML Validator](https://validator.w3.org/) |
| 66 | +- [Browserstack](https://live.browserstack.com/dashboard) and link to [Browserstack Credentials](https://asconfluence.stanford.edu/confluence/display/SWS/External+Account+Credentials) |
0 commit comments