Fix trivial ansible lint warnings

Remove no more used playbook, fix ansible-lint version used in the
github workflow, tune the yamllint to be compliant with Ansible
(remove warning about it reported by ansible-lint),
add global exception about role-name[path] as it require project folder
structure change, and last but not least fix some warnings.

Author: mpagot

.ansible-lint

@@ -3,3 +3,5 @@ exclude_paths:
   - ansible/playbooks/registration_role.yaml
   - ansible/playbooks/vars/hana_media.yaml
   - ansible/playbooks/vars/hana_vars.yaml
+warn_list:
+  - role-name[path]

.github/workflows/ansible.yml

@@ -21,7 +21,8 @@ jobs:
       - name: Install all requirements
         run: |
           python3 -m pip install --upgrade -r requirements.txt
-          python3 -m pip install ansible-lint==25.6.1
+          # 25.1.3 is the newes version that support ansible-core 2.16.8 we are using right now
+          python3 -m pip install ansible-lint==25.1.3
           ansible-galaxy install -r requirements.yml
 
       - name: Run ansible static tests

.yamllint.yaml

@@ -1,4 +1,13 @@
 extends: default
 
 rules:
-  line-length: disable
+  line-length: disable
+  comments:
+    min-spaces-from-content: 1
+  comments-indentation: false
+  braces:
+    max-spaces-inside: 1
+  octal-values:
+    forbid-implicit-octal: true
+    forbid-explicit-octal: true
+

ansible/playbooks/additional_fence_agent_tasks.yaml

@@ -11,15 +11,14 @@
     ptf_dir: "/tmp/ptf_dir"
 
   tasks:
-
     - name: Create directory for PTF installation
-      file:
+      ansible.builtin.file:
         path: "{{ ptf_dir }}"
         state: directory
         mode: '0755'
 
     - name: Convert comma-separated string to list
-      set_fact:
+      ansible.builtin.set_fact:
         az_blobs: "{{ ptf_files | split(',') }}"
       when: sas_token is defined
 
@@ -38,46 +37,49 @@
       with_items: "{{ az_blobs }}"
       when: sas_token is defined
 
-    - name: Download PTF files recursively with wget
-      command: "wget --no-directories --recursive --reject 'index.html*' --user={{ ptf_user }} --password={{ ptf_password }} --no-parent {{ ptf_url }}"
+    - name: Download PTF files recursively with wget  # noqa: command-instead-of-module
+      ansible.builtin.command: "wget --no-directories --recursive --reject 'index.html*' --user={{ ptf_user }} --password={{ ptf_password }} --no-parent {{ ptf_url }}"
       args:
         chdir: "{{ ptf_dir }}"
+      register: wget_ret
+      changed_when: wget_ret.rc == 0
       when:
         - sas_token is not defined
         - ptf_user is defined
         - ptf_password is defined
         - ptf_url is defined
 
     - name: List downloaded files
-      command: "ls -la"
+      ansible.builtin.command: "ls -la"
       args:
         chdir: "{{ ptf_dir }}"
+      changed_when: false
       register: download_list
 
     - name: Display downloaded files
-      debug:
+      ansible.builtin.debug:
         var: download_list.stdout_lines
 
     - name: Find downloaded RPM files
-      find:
+      ansible.builtin.find:
         paths: "{{ ptf_dir }}"
         patterns: "*.rpm"
       register: rpm_files
 
     - name: Display found RPM files
-      debug:
+      ansible.builtin.debug:
         var: rpm_files.files
 
     - name: Filter out src.rpm files
-      set_fact:
+      ansible.builtin.set_fact:
         filtered_rpm_files: "{{ rpm_files.files | selectattr('path', 'search', '^(?!.*src\\.rpm$).*') | list }}"
 
     - name: Display filtered RPM files
-      debug:
+      ansible.builtin.debug:
         var: filtered_rpm_files
 
     - name: Install PTF RPM packages
-      zypper:
+      community.general.zypper:
         name: "{{ item.path }}"
         state: present
         disable_gpg_check: true

ansible/playbooks/ptf_installation.yaml

@@ -21,15 +21,17 @@
         -o tsv
       delegate_to: 127.0.0.1
       no_log: true
-      run_once: true
+      run_once: true  # noqa: run-once[task] fine to ignore as not using
       register: az_account_key
+      changed_when: az_account_key.rc == 0
       when: az_sas_token is not defined or az_sas_token == ""
 
     - name: "Set expiry"
       ansible.builtin.command: "date -u +'%Y-%m-%dT%H:%MZ' -d '+3 hours'"
       delegate_to: 127.0.0.1
-      run_once: true
+      run_once: true  # noqa: run-once[task] fine to ignore as not using
       register: expiry
+      changed_when: true
       when: az_sas_token is not defined or az_sas_token == ""
 
     - name: Generate SAS token
@@ -44,15 +46,15 @@
       delegate_to: 127.0.0.1
       changed_when: false
       no_log: true
-      run_once: true
+      run_once: true  # noqa: run-once[task] fine to ignore as not using
       register: az_sas_token_output
       when: az_sas_token is not defined or az_sas_token == ""
 
     - name: Set az_sas_token fact
       ansible.builtin.set_fact:
         az_sas_token: "{{ az_sas_token_output.stdout }}"
       delegate_to: 127.0.0.1
-      run_once: true
+      run_once: true  # noqa: run-once[task] fine to ignore as not using
       when: az_sas_token is not defined or az_sas_token == ""
 
     - name: Create software directory
@@ -61,7 +63,7 @@
         state: directory
         owner: root
         group: root
-        mode: 0755
+        mode: "0755"
       become: true
       become_user: root
 
@@ -71,7 +73,7 @@
         dest: "{{ hana_download_path + '/' + item | split('/') | last }}"
         owner: root
         group: root
-        mode: 0600
+        mode: "0600"
         timeout: "{{ url_timeout }}"
       register: result
       until: result is succeeded

ansible/playbooks/sap-hana-download-media.yaml

@@ -1,12 +1,13 @@
 ---
-- hosts: hana
+- name: SAP Hana System Replication Hooks
+  hosts: hana
   remote_user: cloudadmin
   become: true
   become_user: root
 
   pre_tasks:
     - name: Source hana install variables
-      include_vars: ./vars/hana_vars.yaml
+      ansible.builtin.include_vars: ./vars/hana_vars.yaml
 
   vars:
     is_primary: "{{ ansible_play_hosts[0] == inventory_hostname }}"
@@ -26,22 +27,17 @@
           {{ __sapcontrol }}
           -nr {{ sap_hana_install_instance_number }}
           -function StopWait 600 10
+      register: stopwait
+      changed_when: stopwait.rc == 0  # Sucessfull output is like "\n24.06.2025 23:38:21\nStop\nOK\n\n24.06.2025 23:38:41\nStopWait\nOK"
 
-    - name: Start HANA Primary
+    - name: Start HANA
       ansible.builtin.command:  # StartWait will timeout after 600 seconds.
         cmd: >-
           {{ __sapcontrol }}
           -nr {{ sap_hana_install_instance_number }}
           -function StartWait 600 10
-      when: is_primary
-
-    - name: Start HANA Secondary
-      ansible.builtin.command:  # StartWait will timeout after 600 seconds.
-        cmd: >-
-          {{ __sapcontrol }}
-          -nr {{ sap_hana_install_instance_number }}
-          -function StartWait 600 10
-      when: not is_primary
+      register: startwait
+      changed_when: startwait.rc == 0  # Sucessfull output is like "\n24.06.2025 23:38:42\nStart\nOK\n\n24.06.2025 23:39:52\nStartWait\nOK"
 
   tasks:
     - name: Assert that required variables are defined

ansible/playbooks/sap-hana-system-replication-hooks.yaml

@@ -1,5 +1,6 @@
 ---
-- hosts: hana
+- name: SAP Hana System Replication
+  hosts: hana
   remote_user: cloudadmin
   become: true
   become_user: root
@@ -11,7 +12,7 @@
       when: ansible_play_hosts | length != 2
 
     - name: Load HANA vars
-      include_vars: ./vars/hana_vars.yaml
+      ansible.builtin.include_vars: ./vars/hana_vars.yaml
 
   vars:
     install_path: /var/lib/qedep
@@ -52,7 +53,7 @@
 
     - name: Execute hana system replication role
       ansible.builtin.include_role:
-        role: ../roles/sap_ha_install_hana_hsr
+        name: ../roles/sap_ha_install_hana_hsr
       when: hsr_configured == 'absent'
 
     - name: Write status file

ansible/playbooks/sap-hana-system-replication.yaml

@@ -60,7 +60,7 @@
     sap_storage_cloud_type: 'generic'
     sap_storage_sap_type: 'sap_hana'
     sap_storage_action: 'prepare'
-  include_role:
+  ansible.buildin.include_role:
     name: ../roles/qe_sap_storage
 
 - name: Configure HANA SBD target