Skip to content

Commit 88f70cd

Browse files
authored
Fix: Avoid exceptions from Deployment.__del__ (#170)
Fixes #169
1 parent 92a65d4 commit 88f70cd

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/swerex/deployment/abstract.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ def __del__(self):
4545
"""Stops the runtime when the object is deleted."""
4646
# Need to be check whether we are in an async event loop or not
4747
# https://stackoverflow.com/questions/54770360/
48-
self.logger.debug("Ensuring deployment is stopped because object is deleted")
48+
msg = "Ensuring deployment is stopped because object is deleted"
49+
try:
50+
self.logger.debug(msg)
51+
except Exception:
52+
print(msg)
4953
try:
5054
loop = asyncio.get_event_loop()
5155
if loop.is_running():

src/swerex/deployment/docker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ async def stop(self):
267267
if self._container_process is not None:
268268
try:
269269
subprocess.check_call(
270-
["docker", "kill", self._container_name],
270+
["docker", "kill", self._container_name], # type: ignore
271271
stdout=subprocess.DEVNULL,
272272
stderr=subprocess.DEVNULL,
273273
timeout=10,

0 commit comments

Comments
 (0)