Add tests for Ruby modifiers, property analysis, and profiles

40 tests: 29 modifier tests (parametrized remove and guard clause tests,
deterministic seeds, specific content assertions), 4 property analysis
tests via conftest fixture, 11 profile tests covering both log parsers,
parser delegation, eval_sets, and RSpec test path detection.

Author: cosgroveb

tests/bug_gen/adapters/test_ruby_properties.py

@@ -0,0 +1,89 @@
+import pytest
+from swesmith.bug_gen.adapters.ruby import get_entities_from_file_rb
+
+
+@pytest.fixture
+def ruby_test_file_entities(test_file_ruby):
+    entities = []
+    get_entities_from_file_rb(entities, test_file_ruby)
+    assert len(entities) == 12
+    return entities
+
+
+def test_parse_query_properties(ruby_test_file_entities):
+    """Test that parse_query entity has expected property tags."""
+    entity_map = {e.name: e for e in ruby_test_file_entities}
+    entity = entity_map["parse_query"]
+
+    assert entity.is_function is True
+    assert entity.has_if is True
+    assert entity.has_if_else is True
+    assert entity.has_assignment is True
+    assert entity.has_binary_op is True
+    assert entity.has_function_call is True
+
+
+def test_normalize_params_properties(ruby_test_file_entities):
+    """Test that _normalize_params entity has expected property tags."""
+    entity_map = {e.name: e for e in ruby_test_file_entities}
+    entity = entity_map["_normalize_params"]
+
+    assert entity.is_function is True
+    assert entity.has_if is True
+    assert entity.has_if_else is True
+    assert entity.has_return is True
+    assert entity.has_assignment is True
+    assert entity.has_binary_op is True
+    assert entity.has_function_call is True
+
+
+def test_make_params_properties(ruby_test_file_entities):
+    """Test that make_params entity (simple method) has minimal tags."""
+    entity_map = {e.name: e for e in ruby_test_file_entities}
+    entity = entity_map["make_params"]
+
+    assert entity.is_function is True
+    assert entity.has_if is False
+    assert entity.has_loop is False
+    assert entity.has_binary_op is False
+
+
+def test_comprehensive_ruby_properties(tmp_path):
+    """Test _analyze_properties with a comprehensive Ruby function."""
+    comprehensive_ruby_code = """\
+def comprehensive_method(arr, threshold)
+  return nil if arr.nil?
+  sum = 0
+  arr.each do |item|
+    if item > threshold && item < 1000
+      sum += item
+    elsif item <= threshold
+      sum -= item
+    end
+  end
+  result = sum > 0 ? sum * 2 : 0
+  process = ->(x) { x + 1 }
+  process.call(result)
+end
+"""
+
+    test_file = tmp_path / "comprehensive.rb"
+    test_file.write_text(comprehensive_ruby_code)
+
+    entities = []
+    get_entities_from_file_rb(entities, test_file)
+
+    assert len(entities) == 1
+    entity = entities[0]
+
+    assert entity.is_function is True
+    assert entity.has_if is True
+    assert entity.has_if_else is True
+    assert entity.has_return is True
+    assert entity.has_assignment is True
+    assert entity.has_binary_op is True
+    assert entity.has_bool_op is True
+    assert entity.has_off_by_one is True
+    assert entity.has_function_call is True
+    assert entity.has_lambda is True
+    assert entity.has_ternary is True

tests/bug_gen/procedural/ruby/__init__.py

@@ -0,0 +1,124 @@
+import pytest
+
+from swesmith.bug_gen.adapters.ruby import get_entities_from_file_rb
+from swesmith.bug_gen.procedural.ruby.control_flow import (
+    ControlIfElseInvertModifier,
+    ControlShuffleLinesModifier,
+    GuardClauseInvertModifier,
+)
+
+
+def test_control_if_else_invert(tmp_path):
+    src = """\
+def check(x, y)
+  z = x + y
+  if x > 0
+    if y > 0
+      "both positive"
+    else
+      "mixed"
+    end
+  else
+    "non-positive"
+  end
+end
+"""
+    f = tmp_path / "test.rb"
+    f.write_text(src)
+    entities = []
+    get_entities_from_file_rb(entities, f)
+    assert len(entities) == 1
+
+    pm = ControlIfElseInvertModifier(likelihood=1.0, seed=42)
+    assert pm.can_change(entities[0])
+
+    modified = pm.modify(entities[0])
+    assert modified is not None
+    # Outer if/else swapped: "non-positive" now in then-branch
+    assert '"non-positive"' in modified.rewrite.split("if x > 0")[1].split("else")[0]
+
+
+def test_control_if_else_invert_no_else(tmp_path):
+    src = """\
+def check(x)
+  if x > 0
+    "positive"
+  end
+end
+"""
+    f = tmp_path / "test.rb"
+    f.write_text(src)
+    entities = []
+    get_entities_from_file_rb(entities, f)
+    assert len(entities) == 1
+
+    pm = ControlIfElseInvertModifier(likelihood=1.0, seed=42)
+    assert not pm.can_change(entities[0])
+
+
+def test_control_shuffle_lines(tmp_path):
+    src = """\
+def setup
+  @name = "test"
+  @count = 0
+  @ready = true
+  while @count < 10
+    @count += 1
+  end
+end
+"""
+    f = tmp_path / "test.rb"
+    f.write_text(src)
+    entities = []
+    get_entities_from_file_rb(entities, f)
+    assert len(entities) == 1
+
+    pm = ControlShuffleLinesModifier(likelihood=1.0, seed=42)
+    assert pm.can_change(entities[0])
+
+    modified = pm.modify(entities[0])
+    assert modified is not None
+    # Statements reordered: @ready appears before @count
+    lines = modified.rewrite.strip().split("\n")
+    ready_idx = next(i for i, line in enumerate(lines) if "@ready" in line)
+    count_idx = next(i for i, line in enumerate(lines) if "@count = 0" in line)
+    assert ready_idx < count_idx
+
+
+@pytest.mark.parametrize("src,expected_keyword", [
+    (
+        """\
+def process(x)
+  return if x.nil?
+  y = x + 1
+  z = y * 2
+  z
+end
+""",
+        "return unless x.nil?",
+    ),
+    (
+        """\
+def process(x)
+  raise unless x.valid?
+  y = x + 1
+  z = y * 2
+  x.perform(z)
+end
+""",
+        "raise if x.valid?",
+    ),
+])
+def test_guard_clause_invert(tmp_path, src, expected_keyword):
+    f = tmp_path / "test.rb"
+    f.write_text(src)
+    entities = []
+    get_entities_from_file_rb(entities, f)
+    assert len(entities) == 1
+
+    pm = GuardClauseInvertModifier(likelihood=1.0, seed=42)
+    assert pm.can_change(entities[0])
+
+    modified = pm.modify(entities[0])
+    assert modified is not None
+    assert expected_keyword in modified.rewrite