Skip to content

Commit 93799a8

Browse files
authored
chore(0.74): Remove @definitelytyped/dtslint dependency (microsoft#2670)
This PR gets rid of the dependency on @definitelytyped/dtslint in order to mitigate CVE-2025-7783. We are essentially cherry-picking the following commits from facebook upstream. - facebook@2e0c2c6 - facebook@67a6380
1 parent 6c8eabd commit 93799a8

File tree

4 files changed

+182
-1017
lines changed

4 files changed

+182
-1017
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
"test-e2e-local-clean": "node ./scripts/release-testing/test-e2e-local-clean.js",
3636
"test-e2e-local": "node ./scripts/release-testing/test-e2e-local.js",
3737
"test-ios": "./scripts/objc-test.sh test",
38-
"test-typescript-offline": "dtslint --localTs node_modules/typescript/lib packages/react-native/types",
39-
"test-typescript": "dtslint packages/react-native/types",
38+
"test-typescript": "tsc -p packages/react-native/types/tsconfig.json",
4039
"test": "jest",
4140
"trigger-react-native-release": "node ./scripts/releases-local/trigger-react-native-release.js",
4241
"update-lock": "npx yarn-deduplicate"
@@ -55,7 +54,6 @@
5554
"@babel/plugin-transform-regenerator": "^7.20.0",
5655
"@babel/preset-env": "^7.20.0",
5756
"@babel/preset-flow": "^7.20.0",
58-
"@definitelytyped/dtslint": "^0.0.127",
5957
"@jest/create-cache-key-function": "^29.6.3",
6058
"@pkgjs/parseargs": "^0.11.0",
6159
"@react-native/metro-babel-transformer": "0.74.89",

packages/react-native/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,4 +187,4 @@
187187
}
188188
]
189189
}
190-
}
190+
}

scripts/run-ci-javascript-tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ try {
9494
}
9595

9696
describe('Test: TypeScript tests');
97-
if (exec(`${YARN_BINARY} run test-typescript-offline`).code) {
97+
if (exec(`${YARN_BINARY} run test-typescript`).code) {
9898
echo('Failed to run TypeScript tests.');
9999
exitCode = 1;
100100
throw Error(exitCode);

0 commit comments

Comments
 (0)