forked from microsoft/react-native-macos
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from microsoft:main #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
962
commits into
Saadnajmi:main
Choose a base branch
from
microsoft:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync rendering (facebook#49509) Summary: Pull Request resolved: facebook#49509 Currently if we hit a deadlock in sync rendering due to a TurboModule initialization that requires main queue setup we don't get any information about which TurboModule caused the issue. To help us know which TurboModules we need to fix, this instead will crash with the name of the TurboModule. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D69805065 fbshipit-source-id: f75df44f9a603a5f53a008382d32b2b5285c1162
Summary: Pull Request resolved: facebook#49545 During tokenization we use 32 bit integers to store the digits before and after a decimal place. Code interpolating strings may produce float strings with the part after digits being greater than max int, in which case we encounter integer overflow caught by UBSAN. I was curious how libc functions for decoding floats handled this, and musl libc goes really out there, storing each intermediate digit in an array of 128 or more digits, and later using `long double`, in a shockingly complicated function. https://github.com/kraj/musl/blob/1880359b54ff7dd9f5016002bfdae4b136007dde/src/internal/floatscan.c#L63 We... probably don't need to go that far, but storing these intermediate digits as doubles should be precise enough and allow large enough values in the vast majority of cases. Changelog: [Internal] Reviewed By: sammy-SC, jorge-cab Differential Revision: D69881560 fbshipit-source-id: b2158ce2c5d85157426cea9850c7f62c2eee5611
…jects (facebook#49546) Summary: Pull Request resolved: facebook#49546 Right now we rely on the ViewConfig processor to fire an invariant if the values are incorrect. We really don't want to redbox in the future on invalid properties, and this won't be around for the native CSS parsing path. This code has some problems, like... radian parsing allowing potential out-of-bounds reads, firing a native assert for valid 9 digit matrices, or the layers in conjunction treating `0.5r.degoggos00` as a valid way to say 0.5 radians. Wheeee! This change mostly just ports over the checks from `processTransform` to validate parameters before we use them, treating the whole transform list as invalid if any part of it is broken. I moved radian and percentage parsing the the CSS data type parsers as well. I avoided changing props structures again here. Changelog: [General][Changed] - Add validation to Fabric parsing for transform options Reviewed By: javache Differential Revision: D69823064 fbshipit-source-id: 87c6da448a4b55e0507382b98aabd62ce3e4587f
) Summary: Pull Request resolved: facebook#49535 changelog: [internal] Add a unit test to cover scenario where ScrollView's parent has a transform Reviewed By: NickGerleman Differential Revision: D69860855 fbshipit-source-id: 1b64665c5b15ad2e5e068d4c6d56f9694ac7cf03
Summary: Pull Request resolved: facebook#49514 This attemps to enable Config Caching on CI. I'm curious to see how much time this is going to save. There might be some problems with nigthlies so I want to make sure this is running for some days before the branch cut. Changelog: [Internal] [Changed] - Reviewed By: NickGerleman Differential Revision: D69846848 fbshipit-source-id: 0d5c292e65a6107df62f6494a1aae9abd0e8b6cc
Summary: Pull Request resolved: facebook#49524 If there is already an XCFramework in the current location. xcodebuild fails to create and override the xcframework. This change allows us to override an old xcframework and to iterate more quickly. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D69851428 fbshipit-source-id: 723b3035cec008e2bd177da4f960f2bb085ff493
Summary: Pull Request resolved: facebook#49523 There was a typo when checking the configuration. The default parameter is `all`, not `All`. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D69851429 fbshipit-source-id: 7f16f5f89c90824ceb57f9980bc38a31be33ccfe
Summary: Pull Request resolved: facebook#49522 While testing the script, sometime I obtained undesired results because I was passing the wrong values for the arguments. This change add a simple validation function to inform the user when the arguments that are passed are not valid. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D69851416 fbshipit-source-id: c378a3ca5db942cca5178274204a0d01d1eefdf7
Summary: Pull Request resolved: facebook#49550 Align remaining packages. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D69916099 fbshipit-source-id: d6f5c19c8b33e91ff0e2adac20cfe625a15e96b5
…k during sync rendering" (facebook#49554) Summary: Pull Request resolved: facebook#49554 For some reason, this diff completely breaks the linker on iOS. I tried to look for a fix forward, but unsuccessfully. I'm reverting this diff to get CI green again, but this requires more investigation. ## Changelog: [Internal] - Revert D69805065 Reviewed By: sammy-SC, huntie Differential Revision: D69920338 fbshipit-source-id: 8e1d34b5314d8ead51c127208ae2d2250f7d3724
Summary: Pull Request resolved: facebook#49553 The new React-renderercss pod is an header only pod. These are not allowed by Cocoapods, because it will not materialize the framework when building with then turned on. the solution is to just add an empty source file to frorce cocoapods to materialize the .framework file and solve the dependency graph properly. ## Changelog: [Internal] - Add dummy file to React-renderercss Reviewed By: huntie Differential Revision: D69920318 fbshipit-source-id: e5cc092a480f7c86eeb295ed966f85b6f55fdc54
Summary: Migrate com.facebook.react.uimanager.StateWrapper to Kotlin ## Changelog: [INTERNAL] - Migrate com.facebook.react.uimanager.StateWrapper to Kotlin Pull Request resolved: facebook#49544 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cortinico, NickGerleman Differential Revision: D69890013 Pulled By: Abbondanzo fbshipit-source-id: 859ae727167638a0ef7fa6158d27f5429921a9f9
…49551) Summary: Pull Request resolved: facebook#49551 changelog: [internal] in recent commit, facebook@470bc40, use of KVO was removed. But `removeObserver` when `addObserver` was not called leads to a crash and must be removed as well. Reviewed By: cipolleschi Differential Revision: D69918158 fbshipit-source-id: ad65273e74545eba77ab35c5e22c28bddf072f9f
…acebook#48578) Summary: When building `react-native-windows` our code analysis tools complained about an implicit `double` to `PointerIdentifier` in NativeDOM.cpp. This PR adds an explicit cast. Temporary downstream patch: microsoft/react-native-windows@5957d0a ## Changelog: [GENERAL] [FIXED] - Add explicit casts for pointerIds for PointerEvents in NativeDOM Pull Request resolved: facebook#48578 Test Plan: React Native Windows builds with this change and no more warnings. Reviewed By: rubennorte Differential Revision: D69920656 Pulled By: cipolleschi fbshipit-source-id: 1d81f1fbfd91fadfb676d3e65c3c9cb729c1d3dd
…feArea to prevent potential race (facebook#49515) Summary: Pull Request resolved: facebook#49515 changelog: [internal] _currentSafeAreaInsets should be initialised as part of `startObservingSafeArea` to make sure it is set before accessed. Even though, right now _currentSafeAreaInsets is always set before it is read because notification RCTUserInterfaceStyleDidChangeNotification fires eagerly, it might change in the future and introduce a bug. Reviewed By: lenaic Differential Revision: D69846681 fbshipit-source-id: f8be8a53e82020112abd170b9f20429bf7ba7011
Summary: Pull Request resolved: facebook#49471 Changelog: [Internal] Reviewed By: huntie Differential Revision: D69747254 fbshipit-source-id: 70bfe94d0950d31e7f4f3c3bc4df47121e8be9c1
Summary: Pull Request resolved: facebook#49552 Changelog: [General][Internal] - expand debugger events to have DebuggerSessionIDs Also moved the handling of these to a shared function Reviewed By: huntie Differential Revision: D69917817 fbshipit-source-id: 2374ac5b5dc0040b0e15028ab89fbe78026bc296
Summary: This upstreams a change from [RNTV](https://github.com/react-native-tvos/react-native-tvos/) to allow the glog prepare script to work on both iOS and tvOS. ## Changelog: [Internal][Changed] make iOS glog script compatible with tvOS Pull Request resolved: facebook#49539 Test Plan: - This change works well on the TV repo - CI should pass, and iOS compilation and operation should be unchanged Reviewed By: cortinico Differential Revision: D69928586 Pulled By: cipolleschi fbshipit-source-id: b5fec438151e659e98834a83effbc7e166df6aa5
…book#49568) Summary: Pull Request resolved: facebook#49568 The goal of this annotation processor is to generate a file with all the types that belong to Legacy Architecture of React Native changelog: [internal] internal Reviewed By: cortinico Differential Revision: D69929876 fbshipit-source-id: c21bf1a868258b20be91721006d7fc8fa85adcd1
Summary: Pull Request resolved: facebook#49569 In this diff I'm annotating a subset of bridge classes with LegacyArchitecture The goal is to test the annotation processor in next diffs changelog: [internal] internal Reviewed By: cortinico, Abbondanzo Differential Revision: D69929878 fbshipit-source-id: 8be4d010f6519617d334da361983dce0fa66e3b4
…49570) Summary: Pull Request resolved: facebook#49570 This diff creates a initial version of the annotation processor to output the list of types that are annotated with LegacyArchitecture changelog: [internal] internal Reviewed By: cortinico Differential Revision: D69929875 fbshipit-source-id: 90a8d299f4667ab8d103c061d287991dbdb291df
Summary: Pull Request resolved: facebook#49571 Migrate ReactLegacyArchitectureProcessor to kotlin changelog: [internal] internal Reviewed By: cortinico Differential Revision: D69929877 fbshipit-source-id: 448c8de54cbb1f72eeee747edaf4cbb2a5fd365d
…ook#49579) Summary: Pull Request resolved: facebook#49579 Introduce script to generate list of legacy architecture types changelog: [internal] internal Reviewed By: shwanton Differential Revision: D69937113 fbshipit-source-id: 54ba2a982128dab402acec1c40d833c71df2fabb
Summary: Pull Request resolved: facebook#49586 Reverting facebook#49413 as it was causing a crash with assertion failure in ReactViewGroup.addViewWithSubviewClippingEnabled() Changelog: [INTERNAL] revert Kotlin conversion due to crash Reviewed By: sbuggay Differential Revision: D69953848 fbshipit-source-id: b438fb928a4849f3dbad6a9d59d0f48449035fd6
…k#49574) Summary: Pull Request resolved: facebook#49574 Changelog: [General][Internal] add the event tracking when connection to debugger is closed Reviewed By: huntie Differential Revision: D69917816 fbshipit-source-id: 4a15288333c0d5b7fb821d046fa9c615bb25223e
…ook#49572) Summary: Pull Request resolved: facebook#49572 Changelog: [internal] This adds a test to verify the behavior of 2 feature flags: synchronous state updates and UI consistency. Reviewed By: javache Differential Revision: D69932313 fbshipit-source-id: 341cfff3fa533503a293f6ccd0282442ba63d430
…es (facebook#49529) Summary: Pull Request resolved: facebook#49529 Changelog: [Internal] - Added TouchableWithoutFeedback to buildTypes and aligned Flow with TS types Reviewed By: huntie Differential Revision: D69855221 fbshipit-source-id: a1de660e02a90f8e1c181b8e0c5dfdbaa4d2c75c
…ook#49561) Summary: Pull Request resolved: facebook#49561 Changelog: [Internal] - Added TouchableNativeFeedback to buildTypes and aligned Flow types Reviewed By: huntie Differential Revision: D69858177 fbshipit-source-id: 4bd55cba9a9eb1a1d304911cf929b363205a20d5
…tions (facebook#49560) Summary: Pull Request resolved: facebook#49560 Changelog: [Internal] - Added TouchableHighlight to buildTypes and moved comments from TS definitions Reviewed By: huntie Differential Revision: D69919248 fbshipit-source-id: 66b615df60862a53132bd7b2ae9f54065c444e22
Summary: Pull Request resolved: facebook#49589 We should not be attempting to compile anything related to the annotation processor in either Kotlin or Java. This excludes those folders from the Kotlin compilation task as the CI is currently red because of it. Changelog: [Internal] [Changed] - Reviewed By: huntie Differential Revision: D69981620 fbshipit-source-id: 7e2d534023ab1c00e5aadf8546440a4cc4c01ec0
…#2594) ## Summary: RCTUILabel doesn't like it if we set message to nil, which we accidentally did by loading our viewController into a window (which calls viewDidLoad, which creates our label and sets message) before we have set our property. Simple fix to call code in the right order. ## Test Plan: <img width="1392" height="860" alt="image" src="https://github.com/user-attachments/assets/c6158b2c-4f8f-4348-9eb0-e863ec72a9e1" />
## Summary: In our version action, we overrode `afterAllProjectsVersioned` without calling the base one. The base one updated our Yarn lock. Let's make sure to call the base one.
## Summary: With #2560 and followup changes, we call `yarn npm publish` directly instead of `nx release publish` (Which indirectly used npm publish). Yarn's NPM publish command grabs its auth token from `.yarnrc.yml`, not `.npmrc`. Let's update our CI steps that set this. ## Test Plan: Tested that I can call `yarn config set / unset` to set and unset these values.
## Summary: Our `prepublish-check` assumed we used a `.npmrc` file to publish. However, we're now using Yarn V4 which uses its' `.yarnrc.yml` to set your registry and auth token. Update the check to handle both.
…oid (#2624) ## Summary: Only set the keyboard event handlers on macOS. This matches what React Native Windows does. While here, update our pod file lock and pbxproj. ## Test Plan: Fixes a bug where <Text> had the keyboard handlers on it set, which red boxed since the handlers don't exist in their native components. --------- Co-authored-by: Tommy Nguyen <[email protected]>
## Summary: Last round of publishes failed on the `.npmrc` file not being created. Let's just pass the values directly to the npm publish command like we do in `0.74-stable`.
## Summary: Cherry pick facebook@ef7f714 , so we can merge this separately from #2620 and not block the CI there. ``` Summary: Pull Request resolved: facebook#48670 The `LICENSE-docs` was needed when this repo was also containing the reactnative.dev docs. As this is not the case anymore, this file is unncessary. Changelog: [Internal] [Changed] - Remove unnecessary LICENSE-docs Reviewed By: cipolleschi Differential Revision: D68156336 fbshipit-source-id: 489bf2cb95916c20eb61bfb00e34b8e271bc08e3 ``` Co-authored-by: Nicola Corti <[email protected]>
## Summary: Previously, we always centered the window, which got a bit annoying during debugging when I'd like to have it remember the last position as I relaunch it. This is probably a good thing to do in general, so let's do it in `RCTAppDelegate`. ## Test Plan: Removed any saved frame by running `defaults delete Microsoft.RNTester-macOS`: window is centered Resize window and move it and close and relaunch: old position is remembered.
## Summary: Fix a couple of static view config validation warnings by adding `focusable` to the macOS view config. ## Test Plan: Less warnings in RNTester when I launch it.
## Summary: In general, we prefer to use `RCTPlatformView` (`#define NSView`) over `RCTUIView` (subclass of NSView for iOS interop) as it tends to have less "Expected NSView, but got subclass of NSView" style errors. This changes fixes one of those errors
## Summary: This was added for an old internal use case that is no longer valid. Let's remove it.
## Summary: Add a Contributiong and Release guide to the website, so that the knowledge of how to do releases is public. --------- Co-authored-by: Adam Gleitman <[email protected]>
## Summary: Merge up to the first commit on `0.79-stable` branch from upstream (81e4901). <details> <summary>Full list files where conflicts had to be manually resolved</summary> - .gitignore - Gemfile - Gemfile.lock - README.md - package.json - packages/assets/package.json - packages/babel-plugin-codegen/package.json - packages/community-cli-plugin/package.json - packages/core-cli-utils/package.json - packages/debugger-frontend/package.json - packages/dev-middleware/package.json - packages/eslint-config-react-native/package.json - packages/eslint-plugin-react-native/package.json - packages/eslint-plugin-specs/package.json - packages/gradle-plugin/package.json - packages/helloworld/Gemfile - packages/metro-config/package.json - packages/normalize-color/package.json - packages/polyfills/package.json - packages/react-native-babel-preset/package.json - packages/react-native-babel-transformer/package.json - packages/react-native-codegen-typescript-test/package.json - packages/react-native-codegen/package.json - packages/react-native-fantom/package.json - packages/react-native-popup-menu-android/package.json - packages/react-native-test-library/package.json - packages/react-native/Libraries/Alert/Alert.js - packages/react-native/Libraries/AppDelegate/RCTAppDelegate.h - packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm - packages/react-native/Libraries/Components/Button.js - packages/react-native/Libraries/Components/Pressable/Pressable.js - packages/react-native/Libraries/Components/ScrollView/ScrollView.js - packages/react-native/Libraries/Components/TextInput/TextInput.flow.js - packages/react-native/Libraries/Components/TextInput/TextInput.js - packages/react-native/Libraries/Components/TextInput/TextInputNativeCommands.js - packages/react-native/Libraries/Components/Touchable/Touchable.js - packages/react-native/Libraries/Components/Touchable/TouchableWithoutFeedback.js - packages/react-native/Libraries/Components/View/ViewPropTypes.js - packages/react-native/Libraries/Core/setUpAlert.js - packages/react-native/Libraries/Image/ImageProps.js - packages/react-native/Libraries/Lists/FillRateHelper.js - packages/react-native/Libraries/Lists/FlatList.js - packages/react-native/Libraries/Lists/SectionList.js - packages/react-native/Libraries/Lists/SectionListModern.js - packages/react-native/Libraries/Lists/ViewabilityHelper.js - packages/react-native/Libraries/Lists/VirtualizeUtils.js - packages/react-native/Libraries/Lists/VirtualizedList.js - packages/react-native/Libraries/Lists/VirtualizedListContext.js - packages/react-native/Libraries/Lists/VirtualizedSectionList.js - packages/react-native/Libraries/Modal/Modal.js - packages/react-native/Libraries/Network/RCTDataRequestHandler.mm - packages/react-native/Libraries/Network/RCTFileRequestHandler.mm - packages/react-native/Libraries/Pressability/Pressability.js - packages/react-native/Libraries/Text/TextInput/RCTBackedTextInputViewProtocol.h - packages/react-native/Libraries/Text/TextInput/Singleline/RCTUITextField.mm - packages/react-native/Libraries/Text/TextProps.js - packages/react-native/Libraries/Types/CoreEventTypes.js - packages/react-native/Libraries/Utilities/Platform.flow.js - packages/react-native/Libraries/Utilities/ReactNativeTestTools.js - packages/react-native/Libraries/Utilities/__tests__/Platform-test.js - packages/react-native/Libraries/WebSocket/WebSocket.js - packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap - packages/react-native/React/CoreModules/RCTAccessibilityManager.mm - packages/react-native/React/CoreModules/RCTAppearance.mm - packages/react-native/React/CoreModules/RCTDevSettings.mm - packages/react-native/React/CoreModules/RCTDeviceInfo.mm - packages/react-native/React/CoreModules/RCTPlatform.mm - packages/react-native/React/CoreModules/RCTStatusBarManager.mm - packages/react-native/React/DevSupport/RCTInspectorDevServerHelper.mm - packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm - packages/react-native/React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm - packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm - packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputUtils.mm - packages/react-native/React/Fabric/Utils/RCTBoxShadow.mm - packages/react-native/React/Fabric/Utils/RCTLinearGradient.mm - packages/react-native/React/UIUtils/RCTUIUtils.h - packages/react-native/React/UIUtils/RCTUIUtils.m - packages/react-native/ReactCommon/react/renderer/components/textinput/platform/ios/react/renderer/components/iostextinput/propsConversions.h - packages/react-native/ReactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.mm - packages/react-native/ReactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/RCTPlatformColorUtils.h - packages/react-native/ReactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/RCTPlatformColorUtils.mm - packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.mm - packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextPrimitivesConversions.h - packages/react-native/index.js - packages/react-native/package.json - packages/react-native/scripts/cocoapods/new_architecture.rb - packages/react-native/src/private/inspector/NetworkOverlay.js - packages/react-native/src/private/specs_DEPRECATED/modules/NativeAlertManager.js - packages/rn-tester/Gemfile - packages/rn-tester/Podfile.lock - packages/rn-tester/RNTester/AppDelegate.h - packages/rn-tester/RNTester/AppDelegate.mm - packages/rn-tester/js/examples/FlatList/FlatList-basic.js - packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js - packages/rn-tester/js/types/RNTesterTypes.js - packages/rn-tester/package.json - packages/typescript-config/package.json - packages/virtualized-lists/Lists/VirtualizedListProps.js - packages/virtualized-lists/package.json - yarn.lock </details> ## Test Plan: Run RNTester locally <img width="1392" height="888" alt="image" src="https://github.com/user-attachments/assets/3a60d6b4-44ea-497d-9e63-cb04607cd7c3" /> --------- Co-authored-by: Jakub Piasecki <[email protected]> Co-authored-by: Iwo Plaza <[email protected]> Co-authored-by: Mateo Guzmán <[email protected]> Co-authored-by: Nicola Corti <[email protected]> Co-authored-by: Dawid Małecki <[email protected]> Co-authored-by: Pieter De Baets <[email protected]> Co-authored-by: Samuel Susla <[email protected]> Co-authored-by: Joe Vilches <[email protected]> Co-authored-by: David Vacca <[email protected]> Co-authored-by: Sam Zhou <[email protected]> Co-authored-by: Nick Gerleman <[email protected]> Co-authored-by: Riccardo Cipolleschi <[email protected]> Co-authored-by: Vitali Zaidman <[email protected]> Co-authored-by: Andrew Datsenko <[email protected]> Co-authored-by: Rob Hogan <[email protected]> Co-authored-by: Dark Knight <> Co-authored-by: chrsmys <[email protected]> Co-authored-by: Shawn Dempsey <[email protected]> Co-authored-by: Eric Rozell <[email protected]> Co-authored-by: Marc Rousavy <[email protected]> Co-authored-by: Liron Yahdav <[email protected]> Co-authored-by: Fabrizio Cucci <[email protected]> Co-authored-by: Jon Thysell <[email protected]> Co-authored-by: Douglas Lowder <[email protected]> Co-authored-by: Alan Lee <[email protected]> Co-authored-by: Rubén Norte <[email protected]> Co-authored-by: Phil Pluckthun <[email protected]> Co-authored-by: Samat Osmonov <[email protected]> Co-authored-by: Janic Duplessis <[email protected]> Co-authored-by: Henry Garant <[email protected]> Co-authored-by: Jack Pope <[email protected]> Co-authored-by: Devan Buggay <[email protected]> Co-authored-by: Jakub Piasecki <[email protected]> Co-authored-by: zhongwuzw <[email protected]> Co-authored-by: Olivier Bouillet <[email protected]> Co-authored-by: Ruslan Lesiutin <[email protected]> Co-authored-by: Rick Hanlon <[email protected]> Co-authored-by: Shawn Dempsey <[email protected]> Co-authored-by: Maddie Lord <[email protected]> Co-authored-by: Soe Lynn <[email protected]> Co-authored-by: Julian Tigler <[email protected]> Co-authored-by: Parsa Nasirimehr <[email protected]> Co-authored-by: Peter Hsieh <[email protected]> Co-authored-by: Intl Scheduler <[email protected]> Co-authored-by: Oskar Kwaśniewski <[email protected]> Co-authored-by: Joanna Qu <[email protected]> Co-authored-by: Christian Falch <[email protected]> Co-authored-by: Nick Lefever <[email protected]> Co-authored-by: Kudo Chien <[email protected]> Co-authored-by: Alex Taylor (alta) <[email protected]> Co-authored-by: Jorge Cabiedes Acosta <[email protected]> Co-authored-by: generatedunixname89002005232357 <[email protected]> Co-authored-by: Alex Hunt <[email protected]> Co-authored-by: Saad Najmi <[email protected]>
…rkspaces instead of dependencies (#2652)
## Summary: Mitigate GHSA-cxm3-wv7p-598c
## Summary: On older stable branches, our Github repo ruleset looked for a job named "PR", which we have now named "all" in Github Actions. Let's rename the GHA job so that Azure Pipelines and GHA both report success on the same job and we don't need to fork our ruleset. ## Test Plan: Testing in #2650
This PR gets rid of the dependency on @definitelytyped/dtslint in order to mitigate CVE-2025-7783. We are essentially cherry-picking the following commits from facebook upstream. - facebook@2e0c2c6 - facebook@67a6380 --------- Co-authored-by: Saad Najmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )