Bound overlay checking in GetV4Version

mnadareski · mnadareski · commit 2c0885383ec6 · 2025-09-19T11:35:36.000-04:00
diff --git a/BinaryObjectScanner/Protection/SecuROM.cs b/BinaryObjectScanner/Protection/SecuROM.cs
@@ -157,7 +157,7 @@ public List<string> CheckDirectoryPath(string path, List<string>? files)
             // Search for the "AddD" string in the overlay
             bool found = false;
             int index = 0;
-            for (; index < 0x100; index++)
+            for (; index < 0x100 && index + 4 < overlayData.Length; index++)
             {
                 int temp = index;
                 byte[] overlaySample = overlayData.ReadBytes(ref temp, 0x04);

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ public List<string> CheckDirectoryPath(string path, List<string>? files)`
`157`	`157`	`// Search for the "AddD" string in the overlay`
`158`	`158`	`bool found = false;`
`159`	`159`	`int index = 0;`
`160`		`- for (; index < 0x100; index++)`
	`160`	`+ for (; index < 0x100 && index + 4 < overlayData.Length; index++)`
`161`	`161`	`{`
`162`	`162`	`int temp = index;`
`163`	`163`	`byte[] overlaySample = overlayData.ReadBytes(ref temp, 0x04);`