Clean up holdover logic

Author: mnadareski

BinaryObjectScanner/FileType/Executable.cs

@@ -74,12 +74,10 @@ protected IDictionary<IContentCheck, string> RunContentChecks(string? file, Stre
         /// Handle a single file based on all executable check implementations
         /// </summary>
         /// <param name="file">Name of the source file of the executable, for tracking</param>
-        /// <param name="exe">Executable to scan</param>
         /// <param name="checks">Set of checks to use</param>
-        /// <param name="scanner">Scanner for handling recursive protections</param>
         /// <param name="includeDebug">True to include debug data, false otherwise</param>
         /// <returns>Set of protections in file, empty on error</returns>
-        protected IDictionary<U, string> RunExecutableChecks<U>(string file, T exe, U[] checks, bool includeDebug)
+        protected IDictionary<U, string> RunExecutableChecks<U>(string file, U[] checks, bool includeDebug)
             where U : IExecutableCheck<T>
         {
             // Create the output dictionary
@@ -89,7 +87,7 @@ protected IDictionary<U, string> RunExecutableChecks<U>(string file, T exe, U[]
             checks.IterateWithAction(checkClass =>
             {
                 // Get the protection for the class, if possible
-                var protection = checkClass.CheckExecutable(file, exe, includeDebug);
+                var protection = checkClass.CheckExecutable(file, _wrapper, includeDebug);
                 if (string.IsNullOrEmpty(protection))
                     return;
 

BinaryObjectScanner/FileType/LinearExecutable.cs

@@ -27,7 +27,7 @@ public LinearExecutable(SabreTools.Serialization.Wrappers.LinearExecutable wrapp
 
             // Standard checks
             var subProtections
-                = RunExecutableChecks(file, _wrapper, StaticChecks.LinearExecutableCheckClasses, includeDebug);
+                = RunExecutableChecks(file, StaticChecks.LinearExecutableCheckClasses, includeDebug);
             protections.Append(file, subProtections.Values);
 
             // If there are no protections

BinaryObjectScanner/FileType/MSDOS.cs

@@ -27,7 +27,7 @@ public MSDOS(SabreTools.Serialization.Wrappers.MSDOS wrapper) : base(wrapper) {
 
             // Standard checks
             var subProtections
-                = RunExecutableChecks(file, _wrapper, StaticChecks.MSDOSExecutableCheckClasses, includeDebug);
+                = RunExecutableChecks(file, StaticChecks.MSDOSExecutableCheckClasses, includeDebug);
             protections.Append(file, subProtections.Values);
 
             // If there are no protections

BinaryObjectScanner/FileType/NewExecutable.cs

@@ -27,7 +27,7 @@ public NewExecutable(SabreTools.Serialization.Wrappers.NewExecutable wrapper) :
 
             // Standard checks
             var subProtections
-                = RunExecutableChecks(file, _wrapper, StaticChecks.NewExecutableCheckClasses, includeDebug);
+                = RunExecutableChecks(file, StaticChecks.NewExecutableCheckClasses, includeDebug);
             protections.Append(file, subProtections.Values);
 
             // If there are no protections

BinaryObjectScanner/FileType/PortableExecutable.cs

@@ -27,7 +27,7 @@ public PortableExecutable(SabreTools.Serialization.Wrappers.PortableExecutable w
 
             // Standard checks
             var subProtections
-                = RunExecutableChecks(file, _wrapper, StaticChecks.PortableExecutableCheckClasses, includeDebug);
+                = RunExecutableChecks(file, StaticChecks.PortableExecutableCheckClasses, includeDebug);
             protections.Append(file, subProtections.Values);
 
             // If there are no protections