Fix MS-CAB writing

mnadareski · mnadareski · commit 677f66f98d10 · 2024-12-13T14:58:25.000-05:00
diff --git a/BinaryObjectScanner/FileType/MicrosoftCAB.cs b/BinaryObjectScanner/FileType/MicrosoftCAB.cs
@@ -58,7 +58,7 @@ public bool Extract(Stream? stream, string file, string outDir, bool includeDebu
                         // Uncompressed data
                         if ((folder.CompressionType & CompressionType.TYPE_NONE) != 0)
                         {
-                            ms.Write(db.CompressedData);
+                            ms.Write(db.CompressedData, 0, db.CompressedData.Length);
                             ms.Flush();
                         }
 
@@ -75,7 +75,7 @@ public bool Extract(Stream? stream, string file, string outDir, bool includeDebu
                             uint windowBits = (uint)(((ushort)folder.CompressionType >> 8) & 0x1f);
                             var decomp = SabreTools.Compression.Quantum.Decompressor.Create(db.CompressedData, windowBits);
                             byte[] data = decomp.Process();
-                            ms.Write(data);
+                            ms.Write(data, 0, data.Length);
                             ms.Flush();
                         }
 
@@ -118,7 +118,7 @@ public bool Extract(Stream? stream, string file, string outDir, bool includeDebu
                                 Directory.CreateDirectory(directoryName);
 
                             using var of = File.OpenWrite(tempFile);
-                            of.Write(fileData);
+                            of.Write(fileData, 0, fileData.Length);
                             of.Flush();
                         }
                         catch (Exception ex)

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public bool Extract(Stream? stream, string file, string outDir, bool includeDebu`
`58`	`58`	`// Uncompressed data`
`59`	`59`	`if ((folder.CompressionType & CompressionType.TYPE_NONE) != 0)`
`60`	`60`	`{`
`61`		`- ms.Write(db.CompressedData);`
	`61`	`+ ms.Write(db.CompressedData, 0, db.CompressedData.Length);`
`62`	`62`	`ms.Flush();`
`63`	`63`	`}`
`64`	`64`
`@@ -75,7 +75,7 @@ public bool Extract(Stream? stream, string file, string outDir, bool includeDebu`
`75`	`75`	`uint windowBits = (uint)(((ushort)folder.CompressionType >> 8) & 0x1f);`
`76`	`76`	`var decomp = SabreTools.Compression.Quantum.Decompressor.Create(db.CompressedData, windowBits);`
`77`	`77`	`byte[] data = decomp.Process();`
`78`		`- ms.Write(data);`
	`78`	`+ ms.Write(data, 0, data.Length);`
`79`	`79`	`ms.Flush();`
`80`	`80`	`}`
`81`	`81`
`@@ -118,7 +118,7 @@ public bool Extract(Stream? stream, string file, string outDir, bool includeDebu`
`118`	`118`	`Directory.CreateDirectory(directoryName);`
`119`	`119`
`120`	`120`	`using var of = File.OpenWrite(tempFile);`
`121`		`- of.Write(fileData);`
	`121`	`+ of.Write(fileData, 0, fileData.Length);`
`122`	`122`	`of.Flush();`
`123`	`123`	`}`
`124`	`124`	`catch (Exception ex)`