Add note for Advanced Installer

mnadareski · mnadareski · commit 7e7d166ed880 · 2025-09-25T21:02:54.000-04:00
diff --git a/BinaryObjectScanner/Packer/AdvancedInstaller.cs b/BinaryObjectScanner/Packer/AdvancedInstaller.cs
@@ -5,6 +5,12 @@ namespace BinaryObjectScanner.Packer
 {
     // TODO: Add extraction
     // TODO: Verify that all versions are detected
+    // Using the file "ds-1.0.6-patch.exe", it seems like the way that AdvancedInstaller
+    // works is by packing all of the files sequentially in the overlay and referencing
+    // them somehow. This has the unfortunate effect that, if any of these files are
+    // executables, then every single file appears embedded in the first's overlay.
+    // While this technically extracts the data, it does so improperly. It may require
+    // using the size of image and headers for overlay-extracted data.
     public class AdvancedInstaller : IExecutableCheck<PortableExecutable>
     {
         /// <inheritdoc/>

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,12 @@ namespace BinaryObjectScanner.Packer`
`5`	`5`	`{`
`6`	`6`	`// TODO: Add extraction`
`7`	`7`	`// TODO: Verify that all versions are detected`
	`8`	`+ // Using the file "ds-1.0.6-patch.exe", it seems like the way that AdvancedInstaller`
	`9`	`+ // works is by packing all of the files sequentially in the overlay and referencing`
	`10`	`+ // them somehow. This has the unfortunate effect that, if any of these files are`
	`11`	`+ // executables, then every single file appears embedded in the first's overlay.`
	`12`	`+ // While this technically extracts the data, it does so improperly. It may require`
	`13`	`+ // using the size of image and headers for overlay-extracted data.`
`8`	`14`	`public class AdvancedInstaller : IExecutableCheck<PortableExecutable>`
`9`	`15`	`{`
`10`	`16`	`/// <inheritdoc/>`