Skip to content

Commit 9be63e9

Browse files
Change version output for protectdisc iso scan (#410)
Existing one was found to be inaccurate
1 parent 5779749 commit 9be63e9

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

BinaryObjectScanner/Protection/ProtectDISC.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,14 @@ public class ProtectDISC : IDiskImageCheck<ISO9660>, IExecutableCheck<PortableEx
5252
// 7.5.0.61324 and 9.0.1119. ProtectDiSC versioning is very confusing, so this is not the "actual" version
5353
// number and should not be printed.
5454
// Previous versions just have spaces here, so it doesn't need to be validated beyond that.
55-
var abstractIdentifierString = pvd.AbstractFileIdentifier.ReadNullTerminatedAnsiString(ref offset);
55+
// Some ProtectDiSC 6 discs also have version number, such as RID 114936 having 1.1.2286.18916, and
56+
// 131176 having 1.1.2162.19023. The below check is commented out because there's likely something that
57+
// can be done with it, it's just difficult to do anything while ProtectDiSC versioning is still unclear.
58+
/*var abstractIdentifierString = pvd.AbstractFileIdentifier.ReadNullTerminatedAnsiString(ref offset);
5659
if (abstractIdentifierString is null || abstractIdentifierString.Trim().Length == 0)
57-
return "ProtectDiSC 6-7.x";
60+
return "ProtectDiSC 6-7.x";*/
5861

59-
return "ProtectDiSC 7.x+";
62+
return "ProtectDiSC 6+";
6063
}
6164

6265
/// <inheritdoc/>

0 commit comments

Comments
 (0)