Disallow some fields from being null

Author: mnadareski

SabreTools.RedumpLib.Test/BuilderTests.cs

@@ -26,102 +26,6 @@ public void CreateFromFileTest(string filename, bool expectNull)
             Assert.Equal(expectNull, si == null);
         }
 
-        [Fact]
-        public void EnsureAllSections_Null_Filled()
-        {
-            SubmissionInfo? si = null;
-            var actual = Builder.EnsureAllSections(si);
-
-            Assert.NotNull(actual);
-            Assert.NotNull(actual.CommonDiscInfo);
-            Assert.NotNull(actual.CommonDiscInfo.CommentsSpecialFields);
-            Assert.NotNull(actual.CommonDiscInfo.ContentsSpecialFields);
-            Assert.NotNull(actual.VersionAndEditions);
-            Assert.NotNull(actual.EDC);
-            Assert.NotNull(actual.ParentCloneRelationship);
-            Assert.NotNull(actual.Extras);
-            Assert.NotNull(actual.CopyProtection);
-            Assert.NotNull(actual.DumpersAndStatus);
-            Assert.NotNull(actual.TracksAndWriteOffsets);
-            Assert.NotNull(actual.SizeAndChecksums);
-            Assert.NotNull(actual.DumpingInfo);
-            Assert.NotNull(actual.Artifacts);
-        }
-
-        [Fact]
-        public void EnsureAllSections_Empty_Filled()
-        {
-            SubmissionInfo? si = new SubmissionInfo
-            {
-                CommonDiscInfo = null,
-                VersionAndEditions = null,
-                EDC = null,
-                ParentCloneRelationship = null,
-                Extras = null,
-                CopyProtection = null,
-                DumpersAndStatus = null,
-                TracksAndWriteOffsets = null,
-                SizeAndChecksums = null,
-                DumpingInfo = null,
-                Artifacts = null,
-            };
-            var actual = Builder.EnsureAllSections(si);
-
-            Assert.NotNull(actual);
-            Assert.NotNull(actual.CommonDiscInfo);
-            Assert.NotNull(actual.CommonDiscInfo.CommentsSpecialFields);
-            Assert.NotNull(actual.CommonDiscInfo.ContentsSpecialFields);
-            Assert.NotNull(actual.VersionAndEditions);
-            Assert.NotNull(actual.EDC);
-            Assert.NotNull(actual.ParentCloneRelationship);
-            Assert.NotNull(actual.Extras);
-            Assert.NotNull(actual.CopyProtection);
-            Assert.NotNull(actual.DumpersAndStatus);
-            Assert.NotNull(actual.TracksAndWriteOffsets);
-            Assert.NotNull(actual.SizeAndChecksums);
-            Assert.NotNull(actual.DumpingInfo);
-            Assert.NotNull(actual.Artifacts);
-        }
-
-        [Fact]
-        public void EnsureAllSections_Filled_Filled()
-        {
-            SubmissionInfo? si = new SubmissionInfo
-            {
-                CommonDiscInfo = new CommonDiscInfoSection
-                {
-                    CommentsSpecialFields = [],
-                    ContentsSpecialFields = [],
-                },
-                VersionAndEditions = new VersionAndEditionsSection(),
-                EDC = new EDCSection(),
-                ParentCloneRelationship = new ParentCloneRelationshipSection(),
-                Extras = new ExtrasSection(),
-                CopyProtection = new CopyProtectionSection(),
-                DumpersAndStatus = new DumpersAndStatusSection(),
-                TracksAndWriteOffsets = new TracksAndWriteOffsetsSection(),
-                SizeAndChecksums = new SizeAndChecksumsSection(),
-                DumpingInfo = new DumpingInfoSection(),
-                Artifacts = [],
-            };
-            var actual = Builder.EnsureAllSections(si);
-
-            Assert.NotNull(actual);
-            Assert.NotNull(actual.CommonDiscInfo);
-            Assert.NotNull(actual.CommonDiscInfo.CommentsSpecialFields);
-            Assert.NotNull(actual.CommonDiscInfo.ContentsSpecialFields);
-            Assert.NotNull(actual.VersionAndEditions);
-            Assert.NotNull(actual.EDC);
-            Assert.NotNull(actual.ParentCloneRelationship);
-            Assert.NotNull(actual.Extras);
-            Assert.NotNull(actual.CopyProtection);
-            Assert.NotNull(actual.DumpersAndStatus);
-            Assert.NotNull(actual.TracksAndWriteOffsets);
-            Assert.NotNull(actual.SizeAndChecksums);
-            Assert.NotNull(actual.DumpingInfo);
-            Assert.NotNull(actual.Artifacts);
-        }
-    
         [Fact]
         public void InjectSubmissionInformation_BothNull_Null()
         {
@@ -188,4 +92,4 @@ public void ReplaceHtmlWithSiteCodes_OutdatedCode_Replaced()
             Assert.Equal(expected, actual);
         }
     }
-}
+}

SabreTools.RedumpLib.Test/ValidatorTests.cs

@@ -28,7 +28,7 @@ public void NormalizeDiscType_InvalidSizeChecksums_Untouched()
             SubmissionInfo si = new SubmissionInfo
             {
                 CommonDiscInfo = new CommonDiscInfoSection { Media = DiscType.CD },
-                SizeAndChecksums = null,
+                SizeAndChecksums = new(),
             };
 
             Validator.NormalizeDiscType(si);
@@ -301,4 +301,4 @@ public void NormalizeDiscType_UMDSL_Fixed(DiscType type)
             Assert.Equal(expected, si.CommonDiscInfo.Media);
         }
     }
-}
+}

SabreTools.RedumpLib/Builder.cs

@@ -253,8 +253,6 @@ public static class Builder
         /// <param name="includeAllData">True to include all pullable information, false to do bare minimum</param>
         public async static Task<bool> FillFromId(RedumpClient rc, SubmissionInfo info, int id, bool includeAllData)
         {
-            // Ensure that required sections exist
-            info = EnsureAllSections(info);
             var discData = await rc.DownloadSingleSiteID(id);
             if (string.IsNullOrEmpty(discData))
                 return false;
@@ -605,35 +603,6 @@ public async static Task<bool> FillFromId(RedumpClient rc, SubmissionInfo info,
             return true;
         }
 
-        /// <summary>
-        /// Ensure all required sections in a submission info exist
-        /// </summary>
-        /// <param name="info">SubmissionInfo object to verify</param>
-        public static SubmissionInfo EnsureAllSections(SubmissionInfo? info)
-        {
-            // If there's no info, create one
-            info ??= new SubmissionInfo();
-
-            // Ensure all sections
-            info.CommonDiscInfo ??= new CommonDiscInfoSection();
-            info.VersionAndEditions ??= new VersionAndEditionsSection();
-            info.EDC ??= new EDCSection();
-            info.ParentCloneRelationship ??= new ParentCloneRelationshipSection();
-            info.Extras ??= new ExtrasSection();
-            info.CopyProtection ??= new CopyProtectionSection();
-            info.DumpersAndStatus ??= new DumpersAndStatusSection();
-            info.TracksAndWriteOffsets ??= new TracksAndWriteOffsetsSection();
-            info.SizeAndChecksums ??= new SizeAndChecksumsSection();
-            info.DumpingInfo ??= new DumpingInfoSection();
-            info.Artifacts ??= [];
-
-            // Ensure special dictionaries
-            info.CommonDiscInfo.CommentsSpecialFields ??= [];
-            info.CommonDiscInfo.ContentsSpecialFields ??= [];
-
-            return info;
-        }
-
         /// <summary>
         /// Inject information from a seed SubmissionInfo into the existing one
         /// </summary>
@@ -645,62 +614,52 @@ public static SubmissionInfo EnsureAllSections(SubmissionInfo? info)
             if (seed == null)
                 return info;
 
-            // Ensure that required sections exist
-            info = EnsureAllSections(info);
-
             // Otherwise, inject information as necessary
-            if (info.CommonDiscInfo != null && seed.CommonDiscInfo != null)
-            {
-                // Info that only overwrites if supplied
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Title)) info.CommonDiscInfo.Title = seed.CommonDiscInfo.Title;
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.ForeignTitleNonLatin)) info.CommonDiscInfo.ForeignTitleNonLatin = seed.CommonDiscInfo.ForeignTitleNonLatin;
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.DiscNumberLetter)) info.CommonDiscInfo.DiscNumberLetter = seed.CommonDiscInfo.DiscNumberLetter;
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.DiscTitle)) info.CommonDiscInfo.DiscTitle = seed.CommonDiscInfo.DiscTitle;
-                if (seed.CommonDiscInfo.Category != null) info.CommonDiscInfo.Category = seed.CommonDiscInfo.Category;
-                if (seed.CommonDiscInfo.Region != null) info.CommonDiscInfo.Region = seed.CommonDiscInfo.Region;
-                if (seed.CommonDiscInfo.Languages != null) info.CommonDiscInfo.Languages = seed.CommonDiscInfo.Languages;
-                if (seed.CommonDiscInfo.LanguageSelection != null) info.CommonDiscInfo.LanguageSelection = seed.CommonDiscInfo.LanguageSelection;
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Serial)) info.CommonDiscInfo.Serial = seed.CommonDiscInfo.Serial;
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Barcode)) info.CommonDiscInfo.Barcode = seed.CommonDiscInfo.Barcode;
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Comments)) info.CommonDiscInfo.Comments = seed.CommonDiscInfo.Comments;
-                if (seed.CommonDiscInfo.CommentsSpecialFields != null) info.CommonDiscInfo.CommentsSpecialFields = seed.CommonDiscInfo.CommentsSpecialFields;
-                if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Contents)) info.CommonDiscInfo.Contents = seed.CommonDiscInfo.Contents;
-                if (seed.CommonDiscInfo.ContentsSpecialFields != null) info.CommonDiscInfo.ContentsSpecialFields = seed.CommonDiscInfo.ContentsSpecialFields;
-
-                // Info that always overwrites
-                info.CommonDiscInfo.Layer0MasteringRing = seed.CommonDiscInfo.Layer0MasteringRing;
-                info.CommonDiscInfo.Layer0MasteringSID = seed.CommonDiscInfo.Layer0MasteringSID;
-                info.CommonDiscInfo.Layer0ToolstampMasteringCode = seed.CommonDiscInfo.Layer0ToolstampMasteringCode;
-                info.CommonDiscInfo.Layer0MouldSID = seed.CommonDiscInfo.Layer0MouldSID;
-                info.CommonDiscInfo.Layer0AdditionalMould = seed.CommonDiscInfo.Layer0AdditionalMould;
-
-                info.CommonDiscInfo.Layer1MasteringRing = seed.CommonDiscInfo.Layer1MasteringRing;
-                info.CommonDiscInfo.Layer1MasteringSID = seed.CommonDiscInfo.Layer1MasteringSID;
-                info.CommonDiscInfo.Layer1ToolstampMasteringCode = seed.CommonDiscInfo.Layer1ToolstampMasteringCode;
-                info.CommonDiscInfo.Layer1MouldSID = seed.CommonDiscInfo.Layer1MouldSID;
-                info.CommonDiscInfo.Layer1AdditionalMould = seed.CommonDiscInfo.Layer1AdditionalMould;
-
-                info.CommonDiscInfo.Layer2MasteringRing = seed.CommonDiscInfo.Layer2MasteringRing;
-                info.CommonDiscInfo.Layer2MasteringSID = seed.CommonDiscInfo.Layer2MasteringSID;
-                info.CommonDiscInfo.Layer2ToolstampMasteringCode = seed.CommonDiscInfo.Layer2ToolstampMasteringCode;
-
-                info.CommonDiscInfo.Layer3MasteringRing = seed.CommonDiscInfo.Layer3MasteringRing;
-                info.CommonDiscInfo.Layer3MasteringSID = seed.CommonDiscInfo.Layer3MasteringSID;
-                info.CommonDiscInfo.Layer3ToolstampMasteringCode = seed.CommonDiscInfo.Layer3ToolstampMasteringCode;
-            }
-
-            if (info.VersionAndEditions != null && seed.VersionAndEditions != null)
-            {
-                // Info that only overwrites if supplied
-                if (!string.IsNullOrEmpty(seed.VersionAndEditions.Version)) info.VersionAndEditions.Version = seed.VersionAndEditions.Version;
-                if (!string.IsNullOrEmpty(seed.VersionAndEditions.OtherEditions)) info.VersionAndEditions.OtherEditions = seed.VersionAndEditions.OtherEditions;
-            }
+            info ??= new SubmissionInfo();
 
-            if (info.CopyProtection != null && seed.CopyProtection != null)
-            {
-                // Info that only overwrites if supplied
-                if (!string.IsNullOrEmpty(seed.CopyProtection.Protection)) info.CopyProtection.Protection = seed.CopyProtection.Protection;
-            }
+            // Info that only overwrites if supplied
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Title)) info.CommonDiscInfo.Title = seed.CommonDiscInfo.Title;
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.ForeignTitleNonLatin)) info.CommonDiscInfo.ForeignTitleNonLatin = seed.CommonDiscInfo.ForeignTitleNonLatin;
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.DiscNumberLetter)) info.CommonDiscInfo.DiscNumberLetter = seed.CommonDiscInfo.DiscNumberLetter;
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.DiscTitle)) info.CommonDiscInfo.DiscTitle = seed.CommonDiscInfo.DiscTitle;
+            if (seed.CommonDiscInfo.Category != null) info.CommonDiscInfo.Category = seed.CommonDiscInfo.Category;
+            if (seed.CommonDiscInfo.Region != null) info.CommonDiscInfo.Region = seed.CommonDiscInfo.Region;
+            if (seed.CommonDiscInfo.Languages != null) info.CommonDiscInfo.Languages = seed.CommonDiscInfo.Languages;
+            if (seed.CommonDiscInfo.LanguageSelection != null) info.CommonDiscInfo.LanguageSelection = seed.CommonDiscInfo.LanguageSelection;
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Serial)) info.CommonDiscInfo.Serial = seed.CommonDiscInfo.Serial;
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Barcode)) info.CommonDiscInfo.Barcode = seed.CommonDiscInfo.Barcode;
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Comments)) info.CommonDiscInfo.Comments = seed.CommonDiscInfo.Comments;
+            if (seed.CommonDiscInfo.CommentsSpecialFields != null) info.CommonDiscInfo.CommentsSpecialFields = seed.CommonDiscInfo.CommentsSpecialFields;
+            if (!string.IsNullOrEmpty(seed.CommonDiscInfo.Contents)) info.CommonDiscInfo.Contents = seed.CommonDiscInfo.Contents;
+            if (seed.CommonDiscInfo.ContentsSpecialFields != null) info.CommonDiscInfo.ContentsSpecialFields = seed.CommonDiscInfo.ContentsSpecialFields;
+
+            // Info that always overwrites
+            info.CommonDiscInfo.Layer0MasteringRing = seed.CommonDiscInfo.Layer0MasteringRing;
+            info.CommonDiscInfo.Layer0MasteringSID = seed.CommonDiscInfo.Layer0MasteringSID;
+            info.CommonDiscInfo.Layer0ToolstampMasteringCode = seed.CommonDiscInfo.Layer0ToolstampMasteringCode;
+            info.CommonDiscInfo.Layer0MouldSID = seed.CommonDiscInfo.Layer0MouldSID;
+            info.CommonDiscInfo.Layer0AdditionalMould = seed.CommonDiscInfo.Layer0AdditionalMould;
+
+            info.CommonDiscInfo.Layer1MasteringRing = seed.CommonDiscInfo.Layer1MasteringRing;
+            info.CommonDiscInfo.Layer1MasteringSID = seed.CommonDiscInfo.Layer1MasteringSID;
+            info.CommonDiscInfo.Layer1ToolstampMasteringCode = seed.CommonDiscInfo.Layer1ToolstampMasteringCode;
+            info.CommonDiscInfo.Layer1MouldSID = seed.CommonDiscInfo.Layer1MouldSID;
+            info.CommonDiscInfo.Layer1AdditionalMould = seed.CommonDiscInfo.Layer1AdditionalMould;
+
+            info.CommonDiscInfo.Layer2MasteringRing = seed.CommonDiscInfo.Layer2MasteringRing;
+            info.CommonDiscInfo.Layer2MasteringSID = seed.CommonDiscInfo.Layer2MasteringSID;
+            info.CommonDiscInfo.Layer2ToolstampMasteringCode = seed.CommonDiscInfo.Layer2ToolstampMasteringCode;
+
+            info.CommonDiscInfo.Layer3MasteringRing = seed.CommonDiscInfo.Layer3MasteringRing;
+            info.CommonDiscInfo.Layer3MasteringSID = seed.CommonDiscInfo.Layer3MasteringSID;
+            info.CommonDiscInfo.Layer3ToolstampMasteringCode = seed.CommonDiscInfo.Layer3ToolstampMasteringCode;
+
+            // Info that only overwrites if supplied
+            if (!string.IsNullOrEmpty(seed.VersionAndEditions.Version)) info.VersionAndEditions.Version = seed.VersionAndEditions.Version;
+            if (!string.IsNullOrEmpty(seed.VersionAndEditions.OtherEditions)) info.VersionAndEditions.OtherEditions = seed.VersionAndEditions.OtherEditions;
+
+            // Info that only overwrites if supplied
+            if (!string.IsNullOrEmpty(seed.CopyProtection.Protection)) info.CopyProtection.Protection = seed.CopyProtection.Protection;
 
             return info;
         }