Small fix just in case. (#25)

HeroponRikiBestest · web-flow · commit 2b9a527743b6 · 2025-09-27T12:59:02.000-04:00
diff --git a/SabreTools.Serialization/Wrappers/RAR.Extraction.cs b/SabreTools.Serialization/Wrappers/RAR.Extraction.cs
@@ -87,7 +87,10 @@ public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebu
                     }
                 }
 
-                if (isSolid)
+                // Still check SharpCompress's archive-level isSolid flag. Based on the way the check works on their
+                // end, it's possible that a multi-block solid archive might have the second (or more files) file not
+                // solid? It doesn't hurt to check either way.
+                if (isSolid || rarFile.IsSolid)
                     return ExtractSolid(rarFile, outputDirectory, includeDebug);
                 else
                     return ExtractNonSolid(rarFile, outputDirectory, includeDebug);
diff --git a/SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs b/SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs
@@ -86,7 +86,10 @@ public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebu
                     }
                 }
                 
-                if (isSolid)
+                // Still check SharpCompress's archive-level isSolid flag. Based on the way the check works on their
+                // end, it's possible that a multi-block solid archive might have the second (or more files) file not
+                // solid? It doesn't hurt to check either way.
+                if (isSolid || sevenZip.IsSolid)
                     return ExtractSolid(sevenZip, outputDirectory, includeDebug);
                 else
                     return ExtractNonSolid(sevenZip, outputDirectory, includeDebug);

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,10 @@ public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebu`
`87`	`87`	`}`
`88`	`88`	`}`
`89`	`89`
`90`		`- if (isSolid)`
	`90`	`+ // Still check SharpCompress's archive-level isSolid flag. Based on the way the check works on their`
	`91`	`+ // end, it's possible that a multi-block solid archive might have the second (or more files) file not`
	`92`	`+ // solid? It doesn't hurt to check either way.`
	`93`	`+ if (isSolid \|\| rarFile.IsSolid)`
`91`	`94`	`return ExtractSolid(rarFile, outputDirectory, includeDebug);`
`92`	`95`	`else`
`93`	`96`	`return ExtractNonSolid(rarFile, outputDirectory, includeDebug);`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,10 @@ public bool Extract(string outputDirectory, bool lookForHeader, bool includeDebu`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`- if (isSolid)`
	`89`	`+ // Still check SharpCompress's archive-level isSolid flag. Based on the way the check works on their`
	`90`	`+ // end, it's possible that a multi-block solid archive might have the second (or more files) file not`
	`91`	`+ // solid? It doesn't hurt to check either way.`
	`92`	`+ if (isSolid \|\| sevenZip.IsSolid)`
`90`	`93`	`return ExtractSolid(sevenZip, outputDirectory, includeDebug);`
`91`	`94`	`else`
`92`	`95`	`return ExtractNonSolid(sevenZip, outputDirectory, includeDebug);`