feat(gui): don't delete autogenerated annotations (#810)

* feat(gui): don't delete autogenerated annotations

* feat(gui): autogenerated annotations get visually deleted again

* feat(gui): autogenerated annotations get visually deleted again

* feat(gui): copy buttons for module

* feat(gui): copy buttons for module

* feat(gui): copy qualified name to clipboard

* feat(gui): don't send deleted annotations to backend

* fix(gui): heatmap annotation counts

* fix(gui): annotation statistics

* fix(gui): properly shadow delete autogenerated attribute/constant/optional/required annotations

* style: apply automatic fixes of linters

Co-authored-by: lars-reimann <[email protected]>

Author: lars-reimann

api-editor/gui/src/features/annotatedPackageData/model/AnnotatedPythonPackageBuilder.ts

@@ -172,13 +172,13 @@ export class AnnotatedPythonPackageBuilder {
         switch (annotationType) {
             case 'Attribute':
                 const attributeAnnotation = this.annotationStore.attributes[target];
-                if (attributeAnnotation) {
+                if (attributeAnnotation && !attributeAnnotation.isRemoved) {
                     return new InferableAttributeAnnotation(attributeAnnotation);
                 }
                 break;
             case 'Boundary':
                 const boundaryAnnotation = this.annotationStore.boundaries[target];
-                if (boundaryAnnotation) {
+                if (boundaryAnnotation && !boundaryAnnotation.isRemoved) {
                     return new InferableBoundaryAnnotation(boundaryAnnotation);
                 }
                 break;
@@ -187,18 +187,18 @@ export class AnnotatedPythonPackageBuilder {
                 if (!calledAfterAnnotations) {
                     break;
                 }
-                return Object.values(calledAfterAnnotations).map(
-                    (calledAfterAnnotation) => new InferableCalledAfterAnnotation(calledAfterAnnotation),
-                );
+                return Object.values(calledAfterAnnotations)
+                    .filter((it) => !it.isRemoved)
+                    .map((calledAfterAnnotation) => new InferableCalledAfterAnnotation(calledAfterAnnotation));
             case 'Constant':
                 const constantAnnotation = this.annotationStore.constants[target];
-                if (constantAnnotation) {
+                if (constantAnnotation && !constantAnnotation.isRemoved) {
                     return new InferableConstantAnnotation(constantAnnotation);
                 }
                 break;
             case 'Description':
                 const descriptionAnnotation = this.annotationStore.descriptions[target];
-                if (descriptionAnnotation) {
+                if (descriptionAnnotation && !descriptionAnnotation.isRemoved) {
                     return new InferableDescriptionAnnotation(descriptionAnnotation);
                 }
                 break;
@@ -207,54 +207,54 @@ export class AnnotatedPythonPackageBuilder {
                 if (!groupAnnotations) {
                     break;
                 }
-                return Object.values(groupAnnotations).map(
-                    (groupAnnotation) => new InferableGroupAnnotation(groupAnnotation),
-                );
+                return Object.values(groupAnnotations)
+                    .filter((it) => !it.isRemoved)
+                    .map((groupAnnotation) => new InferableGroupAnnotation(groupAnnotation));
             case 'Enum':
                 const enumAnnotation = this.annotationStore.enums[target];
-                if (enumAnnotation) {
+                if (enumAnnotation && !enumAnnotation.isRemoved) {
                     return new InferableEnumAnnotation(enumAnnotation);
                 }
                 break;
             case 'Move':
                 const moveAnnotation = this.annotationStore.moves[target];
-                if (moveAnnotation) {
+                if (moveAnnotation && !moveAnnotation.isRemoved) {
                     return new InferableMoveAnnotation(moveAnnotation);
                 }
                 break;
             case 'Optional':
                 const optionalAnnotation = this.annotationStore.optionals[target];
-                if (optionalAnnotation) {
+                if (optionalAnnotation && !optionalAnnotation.isRemoved) {
                     return new InferableOptionalAnnotation(optionalAnnotation);
                 }
                 break;
             case 'Pure':
                 const pureAnnotation = this.annotationStore.pures[target];
-                if (pureAnnotation) {
+                if (pureAnnotation && !pureAnnotation.isRemoved) {
                     return new InferablePureAnnotation();
                 }
                 break;
             case 'Remove':
                 const removeAnnotation = this.annotationStore.removes[target];
-                if (removeAnnotation) {
+                if (removeAnnotation && !removeAnnotation.isRemoved) {
                     return new InferableRemoveAnnotation();
                 }
                 break;
             case 'Rename':
                 const renameAnnotation = this.annotationStore.renamings[target];
-                if (renameAnnotation) {
+                if (renameAnnotation && !renameAnnotation.isRemoved) {
                     return new InferableRenameAnnotation(renameAnnotation);
                 }
                 break;
             case 'Required':
                 const requiredAnnotation = this.annotationStore.requireds[target];
-                if (requiredAnnotation) {
+                if (requiredAnnotation && !requiredAnnotation.isRemoved) {
                     return new InferableRequiredAnnotation();
                 }
                 break;
             case 'Todo':
                 const todoAnnotation = this.annotationStore.todos[target];
-                if (todoAnnotation) {
+                if (todoAnnotation && !todoAnnotation.isRemoved) {
                     return new InferableTodoAnnotation(todoAnnotation);
                 }
                 break;

api-editor/gui/src/features/annotations/AnnotationView.tsx

@@ -353,7 +353,7 @@ const AnnotationTag: React.FC<AnnotationTagProps> = function ({
                 @{type}
                 {name && (
                     <ChakraText as="span" fontWeight="normal" justifySelf="flex-end">
-                        : {name}
+                        : {name} {annotation.isRemoved}
                     </ChakraText>
                 )}
             </Button>

api-editor/gui/src/features/annotations/MinimalDataCopyButtons.tsx renamed to api-editor/gui/src/features/annotations/DataCopyButtons.tsx

@@ -12,7 +12,7 @@ interface MinimalDataButtonsProps {
     target: string;
 }
 
-export const MinimalDataCopyButtons: React.FC<MinimalDataButtonsProps> = function ({ target }) {
+export const DataCopyButtons: React.FC<MinimalDataButtonsProps> = function ({ target }) {
     const pythonPackage = useAppSelector(selectRawPythonPackage);
     const declaration = pythonPackage.getDeclarationById(target);
     const usages = useAppSelector(selectUsages);
@@ -22,6 +22,7 @@ export const MinimalDataCopyButtons: React.FC<MinimalDataButtonsProps> = functio
     const { onCopy: onCopyUsages } = useClipboard(
         details(jsonCode(buildMinimalUsagesStoreJson(usages, declaration)), `Minimal Usage Store for \`${target}\``),
     );
+    const { onCopy: onCopyQualifiedName } = useClipboard(declaration?.preferredQualifiedName() ?? '');
 
     return (
         <ButtonGroup size="sm" variant="outline" isAttached>
@@ -45,6 +46,16 @@ export const MinimalDataCopyButtons: React.FC<MinimalDataButtonsProps> = functio
                     Usages
                 </Button>
             </Tooltip>
+            <Tooltip label="Copy the qualified name of this declaration to the clipboard.">
+                <Button
+                    leftIcon={<FaClipboard />}
+                    onClick={() => {
+                        onCopyQualifiedName();
+                    }}
+                >
+                    Qualified Name
+                </Button>
+            </Tooltip>
         </ButtonGroup>
     );
 };