fix(gui): done filter not matching element if element had removed autogenerated annotations (#820)

lars-reimann · web-flow · commit 82345065c5b6 · 2022-06-30T13:27:55.000+02:00
fix(gui): done filter not matching element if it had removed autogenerated annotations
diff --git a/api-editor/gui/src/features/filter/model/DoneFilter.ts b/api-editor/gui/src/features/filter/model/DoneFilter.ts
@@ -39,7 +39,7 @@ export class DoneFilter extends AbstractPythonFilter {
         return (
             pythonDeclaration.id in annotations.completes &&
             this.getAnnotationsForTarget(pythonDeclaration.id, annotations).every(
-                (annotation) => (annotation.reviewers?.length ?? 0) > 0,
+                (annotation) => annotation.isRemoved || (annotation.reviewers?.length ?? 0) > 0,
             )
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ export class DoneFilter extends AbstractPythonFilter {`
`39`	`39`	`return (`
`40`	`40`	`pythonDeclaration.id in annotations.completes &&`
`41`	`41`	`this.getAnnotationsForTarget(pythonDeclaration.id, annotations).every(`
`42`		`- (annotation) => (annotation.reviewers?.length ?? 0) > 0,`
	`42`	`+ (annotation) => annotation.isRemoved \|\| (annotation.reviewers?.length ?? 0) > 0,`
`43`	`43`	`)`
`44`	`44`	`);`
`45`	`45`	`}`