Bryans suggestions

Author: andrewelamb

synapseclient/client.py

@@ -821,7 +821,7 @@ def login(
 
         # Check version before logging in
         if not self.skip_checks:
-            version_check()
+            version_check(self.logger)
 
         # Make sure to invalidate the existing session
         self.logout()

synapseclient/core/version_check.py

@@ -63,9 +63,14 @@ def version_check(
         ):
             return False
 
+    # Don't prevent the client from running if something goes wrong
     except Exception as e:
-        # Don't prevent the client from running if something goes wrong
-        sys.stderr.write(f"Exception in version check: {str(e)}\n")
+        msg = f"Exception in version check: {str(e)}\n"
+        if logger:
+            logger.info(msg)
+        else:
+            sys.stdout.write(msg)
+            sys.stdout.flush()
         return False
 
     return True

tests/integration/synapseclient/core/test_version_check.py

@@ -1,8 +1,8 @@
 """Integration tests for version checking"""
 
+import httpx
 from pytest_mock import MockerFixture
 
-import synapseclient.core.version_check
 from synapseclient.core.version_check import _get_version_info_from_pypi, version_check
 
 
@@ -14,8 +14,8 @@ async def test_version_check(mocker: MockerFixture):
     # Test out of date version
     assert not version_check(current_version="0.0.1")
 
-    # Assert _get_version_info_from_pypi called  when running version_check
-    spy = mocker.spy(synapseclient.core.version_check, "_get_version_info_from_pypi")
+    # Assert httpx.get called  when running version_check
+    spy = mocker.spy(httpx, "get")
     version_check()
     spy.assert_called_once()