Skip to content

Commit 61d68d5

Browse files
committed
Refactor build configuration for Synapse Desktop Client to streamline artifact naming and remove unused macOS build specifications
1 parent 4235378 commit 61d68d5

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -354,23 +354,14 @@ jobs:
354354
# Windows builds
355355
- os: windows-2022
356356
platform: windows
357-
arch: x64
358357
python-version: '3.11'
359358
artifact-name: synapse-desktop-client-windows-x64
360359

361-
# macOS builds - Intel
362-
- os: macos-13
363-
platform: macos
364-
arch: intel
365-
python-version: '3.11'
366-
artifact-name: synapse-desktop-client-macos-intel
367-
368-
# macOS builds - Apple Silicon (M1/M2)
360+
# macOS builds
369361
- os: macos-14
370362
platform: macos
371-
arch: apple-silicon
372363
python-version: '3.11'
373-
artifact-name: synapse-desktop-client-macos-apple-silicon
364+
artifact-name: synapse-desktop-client-macos
374365

375366
runs-on: ${{ matrix.os }}
376367

@@ -441,17 +432,6 @@ jobs:
441432
echo "No dist directory found"
442433
fi
443434
444-
- name: Upload desktop client artifacts
445-
uses: actions/upload-artifact@v4
446-
with:
447-
name: ${{ matrix.artifact-name }}
448-
path: |
449-
synapse-electron/dist/*.exe
450-
synapse-electron/dist/*.dmg
451-
synapse-electron/dist/*.AppImage
452-
synapse-electron/dist/*.deb
453-
synapse-electron/dist/*.pkg
454-
455435
- name: Upload to GitHub Release
456436
uses: softprops/action-gh-release@v1
457437
if: startsWith(github.ref, 'refs/tags/')
@@ -461,9 +441,6 @@ jobs:
461441
files: |
462442
synapse-electron/dist/*.exe
463443
synapse-electron/dist/*.dmg
464-
synapse-electron/dist/*.AppImage
465-
synapse-electron/dist/*.deb
466-
synapse-electron/dist/*.pkg
467444
468445
# re-download the built package to the appropriate pypi server.
469446
# we upload prereleases to test.pypi.org and releases to pypi.org.

synapse-electron/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
}
4646
],
4747
"icon": "assets/icon.ico",
48-
"verifyUpdateCodeSignature": false
48+
"verifyUpdateCodeSignature": false,
49+
"artifactName": "${productName} Setup ${version}-${os}.${ext}"
4950
},
5051
"mac": {
5152
"target": [
@@ -57,7 +58,8 @@
5758
]
5859
}
5960
],
60-
"icon": "assets/icon.icns"
61+
"icon": "assets/icon.icns",
62+
"artifactName": "${productName}-${version}-${arch}-${os}.${ext}"
6163
},
6264
"linux": {
6365
"target": [

0 commit comments

Comments
 (0)