Skip to content

Commit bd25790

Browse files
committed
Simplify nested logic
1 parent 86c03b3 commit bd25790

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

synapseclient/models/mixins/access_control.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1000,13 +1000,13 @@ async def main():
10001000
self, "sync_from_synapse_async"
10011001
)
10021002

1003-
if should_process_children and _progress_bar is None:
1004-
if recursive and not include_container_content:
1005-
raise ValueError(
1006-
"When recursive=True, include_container_content must also be True. "
1007-
"Setting recursive=True with include_container_content=False has no effect."
1008-
)
1003+
if should_process_children and (recursive and not include_container_content):
1004+
raise ValueError(
1005+
"When recursive=True, include_container_content must also be True. "
1006+
"Setting recursive=True with include_container_content=False has no effect."
1007+
)
10091008

1009+
if should_process_children and _progress_bar is None:
10101010
with shared_download_progress_bar(
10111011
file_size=1,
10121012
synapse_client=client,
@@ -1032,11 +1032,6 @@ async def main():
10321032
if remaining > 0:
10331033
progress_bar.update(remaining)
10341034
elif should_process_children:
1035-
if recursive and not include_container_content:
1036-
raise ValueError(
1037-
"When recursive=True, include_container_content must also be True. "
1038-
"Setting recursive=True with include_container_content=False has no effect."
1039-
)
10401035
await self._process_children_with_progress(
10411036
client=client,
10421037
normalized_types=normalized_types,

0 commit comments

Comments
 (0)