Skip to content

Commit e06a35a

Browse files
committed
use rest_get_paginated_async to get paginated results
1 parent 21a4d8d commit e06a35a

File tree

1 file changed

+10
-17
lines changed

1 file changed

+10
-17
lines changed

synapseclient/api/wiki_service.py

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
if TYPE_CHECKING:
99
from synapseclient import Synapse
1010

11-
import sys
12-
1311

1412
async def post_wiki(
1513
owner_id: str,
@@ -195,19 +193,13 @@ async def get_wiki_header_tree(
195193

196194
client = Synapse.get_client(synapse_client=synapse_client)
197195

198-
prev_num_results = sys.maxsize
199-
while prev_num_results > 0:
200-
params = {"offset": offset, "limit": limit}
201-
page = await client.rest_get_async(
202-
uri=f"/entity/{owner_id}/wikiheadertree2",
203-
params=params,
204-
)
205-
results = page["results"] if "results" in page else page["children"]
206-
prev_num_results = len(results)
196+
response = client.rest_get_paginated_async(
197+
uri=f"/entity/{owner_id}/wikiheadertree2",
198+
limit=limit,
199+
offset=offset,
200+
)
207201

208-
for result in results:
209-
offset += 1
210-
yield result
202+
return response
211203

212204

213205
async def get_wiki_history(
@@ -240,11 +232,12 @@ async def get_wiki_history(
240232

241233
client = Synapse.get_client(synapse_client=synapse_client)
242234

243-
params = {"offset": offset, "limit": limit}
244-
return await client.rest_get_async(
235+
response = client.rest_get_paginated_async(
245236
uri=f"/entity/{owner_id}/wiki2/{wiki_id}/wikihistory",
246-
params=params,
237+
limit=limit,
238+
offset=offset,
247239
)
240+
return response
248241

249242

250243
async def get_attachment_handles(

0 commit comments

Comments
 (0)