fix(auth): resolve TypeScript compilation errors in OAuth implementation

- Fix unknown error type handling in OAuth service methods
- Update controller method return types from Response to void
- Add proper type guards for error instanceof Error checks
- Ensure consistent error handling patterns

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: HuanCheng65

src/auth/oauth/oauth.service.ts

@@ -39,8 +39,8 @@ export class OAuthService {
         await this.loadProvider(providerId, pluginPaths, allowNpmLoading);
       } catch (error) {
         this.logger.error(
-          `Failed to load OAuth provider '${providerId}': ${error.message}`,
-          error.stack,
+          `Failed to load OAuth provider '${providerId}': ${error instanceof Error ? error.message : String(error)}`,
+          error instanceof Error ? error.stack : undefined,
         );
       }
     }
@@ -186,7 +186,7 @@ export class OAuthService {
         }
       } catch (error) {
         this.logger.debug(
-          `Failed to load provider '${providerId}' from ${modulePath}: ${error.message}`,
+          `Failed to load provider '${providerId}' from ${modulePath}: ${error instanceof Error ? error.message : String(error)}`,
         );
       }
     }
@@ -213,7 +213,7 @@ export class OAuthService {
       }
     } catch (error) {
       this.logger.debug(
-        `Failed to load provider '${providerId}' from npm package '${packageName}': ${error.message}`,
+        `Failed to load provider '${providerId}' from npm package '${packageName}': ${error instanceof Error ? error.message : String(error)}`,
       );
     }
 
@@ -274,7 +274,7 @@ export class OAuthService {
       return provider.getAuthorizationUrl(state, accessType);
     } catch (error) {
       throw new OAuthError(
-        `Failed to generate authorization URL for provider '${providerId}': ${error.message}`,
+        `Failed to generate authorization URL for provider '${providerId}': ${error instanceof Error ? error.message : String(error)}`,
         providerId,
         'authorization',
         error,
@@ -300,7 +300,7 @@ export class OAuthService {
       return await provider.handleCallback(code, state);
     } catch (error) {
       throw new OAuthError(
-        `Failed to handle callback for provider '${providerId}': ${error.message}`,
+        `Failed to handle callback for provider '${providerId}': ${error instanceof Error ? error.message : String(error)}`,
         providerId,
         'token_exchange',
         error,
@@ -322,7 +322,7 @@ export class OAuthService {
       return await provider.getUserInfo(accessToken);
     } catch (error) {
       throw new OAuthError(
-        `Failed to get user info from provider '${providerId}': ${error.message}`,
+        `Failed to get user info from provider '${providerId}': ${error instanceof Error ? error.message : String(error)}`,
         providerId,
         'user_info',
         error,

src/users/users.controller.ts

@@ -1236,21 +1236,23 @@ export class UsersController {
     @Query('state') state?: string,
     @Query('access_type') accessType?: string,
     @Res() res?: Response,
-  ): Promise<Response> {
+  ): Promise<void> {
     try {
       const authUrl = await this.oauthService.generateAuthorizationUrl(
         providerId,
         state,
         accessType,
       );
-      return res!.redirect(authUrl);
+      res!.redirect(authUrl);
+      return;
     } catch (error) {
       if (error instanceof OAuthError) {
         const frontendBaseUrl = this.configService.get('FRONTEND_BASE_URL');
         const errorPath =
           this.configService.get('FRONTEND_OAUTH_ERROR_PATH') || '/oauth-error';
         const errorUrl = `${frontendBaseUrl}${errorPath}?error=${encodeURIComponent(error.message)}&provider=${providerId}`;
-        return res!.redirect(errorUrl);
+        res!.redirect(errorUrl);
+        return;
       }
       throw error;
     }
@@ -1264,15 +1266,16 @@ export class UsersController {
     @Ip() ip: string,
     @Headers('User-Agent') userAgent: string | undefined,
     @Res() res: Response,
-  ): Promise<Response> {
+  ): Promise<void> {
     try {
       // 检查是否有错误
       if (query.error) {
         const frontendBaseUrl = this.configService.get('FRONTEND_BASE_URL');
         const errorPath =
           this.configService.get('FRONTEND_OAUTH_ERROR_PATH') || '/oauth-error';
         const errorUrl = `${frontendBaseUrl}${errorPath}?error=${encodeURIComponent(query.error)}&provider=${providerId}&description=${encodeURIComponent(query.error_description || '')}`;
-        return res.redirect(errorUrl);
+        res.redirect(errorUrl);
+        return;
       }
 
       if (!query.code) {
@@ -1325,11 +1328,12 @@ export class UsersController {
       });
 
       // 7. 重定向到前端
-      return res.redirect(frontendUrl);
+      res.redirect(frontendUrl);
+      return;
     } catch (error) {
       this.logger.error(
-        `OAuth callback failed for provider ${providerId}: ${error.message}`,
-        error.stack,
+        `OAuth callback failed for provider ${providerId}: ${error instanceof Error ? error.message : String(error)}`,
+        error instanceof Error ? error.stack : undefined,
       );
 
       const frontendBaseUrl = this.configService.get('FRONTEND_BASE_URL');
@@ -1338,7 +1342,8 @@ export class UsersController {
       const errorMessage =
         error instanceof OAuthError ? error.message : 'Internal server error';
       const errorUrl = `${frontendBaseUrl}${errorPath}?error=${encodeURIComponent(errorMessage)}&provider=${providerId}`;
-      return res.redirect(errorUrl);
+      res.redirect(errorUrl);
+      return;
     }
   }
 }