Add build for linux shared library

Author: nekohasekai

.github/workflows/naive-build.yml

@@ -7,6 +7,10 @@ on:
         description: 'Publish to go-release branch'
         type: boolean
         default: false
+      version:
+        description: 'Release version (e.g., v1.0.0). Creates GitHub Release draft when provided.'
+        type: string
+        required: false
   push:
     branches: [main]
 
@@ -112,6 +116,20 @@ jobs:
             export QEMU_LD_PREFIX=$PWD/naiveproxy/src/out/sysroot-build/bullseye/bullseye_${{ matrix.sysroot_arch }}_staging
           fi
           ./cronet.test -test.v -test.run=TestEngineVersion
+      - name: Build purego test binary
+        run: |
+          cp lib/linux_${{ matrix.arch }}/libcronet.so .
+          CGO_ENABLED=0 \
+          GOOS=linux \
+          GOARCH=${{ matrix.arch }} \
+          go test -tags with_purego -c -o cronet.purego.test .
+      - name: Run purego test binary
+        run: |
+          if [ "${{ matrix.arch }}" != "amd64" ] && [ "${{ matrix.arch }}" != "386" ]; then
+            export QEMU_LD_PREFIX=$PWD/naiveproxy/src/out/sysroot-build/bullseye/bullseye_${{ matrix.sysroot_arch }}_staging
+          fi
+          export LD_LIBRARY_PATH=$PWD
+          ./cronet.purego.test -test.v -test.run=TestEngineVersion
       - uses: actions/upload-artifact@v4
         with:
           name: cronet-linux-${{ matrix.arch }}
@@ -488,3 +506,57 @@ jobs:
           else
             go run ./cmd/build-naive publish --branch go
           fi
+
+  release:
+    needs: [linux, publish]
+    if: github.event_name == 'workflow_dispatch' && github.event.inputs.version != ''
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Download Linux artifacts
+        uses: actions/download-artifact@v4
+        with:
+          pattern: cronet-linux-*
+          path: artifacts/
+          merge-multiple: false
+
+      - name: Get Chromium version
+        id: chromium
+        run: |
+          VERSION=$(grep -h 'const Version' artifacts/cronet-linux-amd64/lib/linux_amd64/libcronet_cgo.go | sed 's/.*"\(.*\)".*/\1/')
+          echo "version=$VERSION" >> $GITHUB_OUTPUT
+
+      - name: Prepare release assets
+        run: |
+          mkdir -p release
+          for dir in artifacts/cronet-linux-*/lib/linux_*; do
+            if [[ "$dir" != *_musl ]]; then
+              ARCH=$(basename "$dir" | sed 's/linux_//')
+              if [ -f "$dir/libcronet.so" ]; then
+                cp "$dir/libcronet.so" "release/libcronet-linux-${ARCH}.so"
+              fi
+            fi
+          done
+          ls -la release/
+
+      - name: Create or update release draft
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          VERSION="${{ github.event.inputs.version }}"
+          CHROMIUM_VERSION="${{ steps.chromium.outputs.version }}"
+
+          # Check if release exists
+          if gh release view "$VERSION" &>/dev/null; then
+            echo "Release $VERSION exists, uploading assets..."
+          else
+            echo "Creating release draft $VERSION..."
+            gh release create "$VERSION" \
+              --draft \
+              --title "$VERSION" \
+              --notes "Cronet Go binding release based on Chromium $CHROMIUM_VERSION"
+          fi
+
+          # Upload assets
+          gh release upload "$VERSION" release/*.so --clobber

cmd/build-naive/cmd.go

@@ -231,6 +231,35 @@ func copyDirectory(source, destination string) {
 	}
 }
 
+func copyDirectoryExclude(source, destination string, excludePatterns []string) {
+	os.MkdirAll(destination, 0o755)
+	entries, err := os.ReadDir(source)
+	if err != nil {
+		return
+	}
+	for _, entry := range entries {
+		sourcePath := filepath.Join(source, entry.Name())
+		destinationPath := filepath.Join(destination, entry.Name())
+
+		shouldExclude := false
+		for _, pattern := range excludePatterns {
+			if matched, _ := filepath.Match(pattern, entry.Name()); matched {
+				shouldExclude = true
+				break
+			}
+		}
+		if shouldExclude {
+			continue
+		}
+
+		if entry.IsDir() {
+			copyDirectoryExclude(sourcePath, destinationPath, excludePatterns)
+		} else {
+			copyFile(sourcePath, destinationPath)
+		}
+	}
+}
+
 func copyGlob(sourceDirectory, destinationDirectory, pattern string) {
 	matches, _ := filepath.Glob(filepath.Join(sourceDirectory, pattern))
 	for _, source := range matches {

cmd/build-naive/cmd_build.go

@@ -302,5 +302,11 @@ func buildTarget(t Target) {
 	} else {
 		log.Printf("Running: ninja -C %s cronet_static", outputDirectory)
 		runCommand(srcRoot, "ninja", "-C", outputDirectory, "cronet_static")
+
+		// For Linux glibc, also build shared library for purego mode and release distribution
+		if t.GOOS == "linux" && t.Libc != "musl" {
+			log.Printf("Running: ninja -C %s cronet", outputDirectory)
+			runCommand(srcRoot, "ninja", "-C", outputDirectory, "cronet")
+		}
 	}
 }

cmd/build-naive/cmd_package.go

@@ -83,6 +83,16 @@ func packageTargets(targets []Target) {
 					log.Printf("Copied static library for %s/%s", t.GOOS, t.ARCH)
 				}
 			}
+
+			// For Linux glibc, also copy shared library (for testing and release, not for go module)
+			if t.GOOS == "linux" && t.Libc != "musl" {
+				sourceShared := filepath.Join(srcRoot, outputDirectory, "libcronet.so")
+				destinationShared := filepath.Join(targetDirectory, "libcronet.so")
+				if _, err := os.Stat(sourceShared); err == nil {
+					copyFile(sourceShared, destinationShared)
+					log.Printf("Copied shared library for %s/%s", t.GOOS, t.ARCH)
+				}
+			}
 		}
 	}
 

cmd/build-naive/cmd_publish.go

@@ -50,7 +50,8 @@ func publish() {
 	log.Print("Step 1: Publishing main module and lib submodules...")
 
 	// Copy lib, include directories and include_cgo.go
-	copyDirectory(filepath.Join(projectRoot, "lib"), filepath.Join(temporaryDirectory, "lib"))
+	// Exclude shared libraries (.so) - they are for testing/release only, not for go module
+	copyDirectoryExclude(filepath.Join(projectRoot, "lib"), filepath.Join(temporaryDirectory, "lib"), []string{"*.so"})
 	copyDirectory(filepath.Join(projectRoot, "include"), filepath.Join(temporaryDirectory, "include"))
 	copyFile(filepath.Join(projectRoot, "include_cgo.go"), filepath.Join(temporaryDirectory, "include_cgo.go"))