Update golangci-lint to v2

Author: nekohasekai

.github/workflows/lint.yml

@@ -20,20 +20,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
         with:
           fetch-depth: 0
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
-          go-version: ^1.24
-      - name: Cache go module
-        uses: actions/cache@v3
-        with:
-          path: |
-            ~/go/pkg/mod
-          key: go-${{ hashFiles('**/go.sum') }}
+          go-version: ~1.24.6
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: latest
+          version: latest
+          args: --timeout=30m
+          install-mode: binary
+          verify: false

.golangci.yml

@@ -1,24 +1,49 @@
+version: "2"
+run:
+  go: "1.24"
 linters:
-  disable-all: true
+  default: none
   enable:
-    - gofumpt
     - govet
-    - gci
-    - staticcheck
-    - paralleltest
     - ineffassign
-
-linters-settings:
-  gci:
-    custom-order: true
-    sections:
-      - standard
-      - prefix(github.com/sagernet/)
-      - default
-  staticcheck:
-    checks:
-      - all
-      - -SA1003
-
-run:
-  go: "1.23"
+    - paralleltest
+    - staticcheck
+  settings:
+    staticcheck:
+      checks:
+        - all
+        - -S1000
+        - -S1008
+        - -S1017
+        - -ST1003
+        - -QF1001
+        - -QF1003
+        - -QF1008
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gci
+    - gofumpt
+  settings:
+    gci:
+      sections:
+        - standard
+        - prefix(github.com/sagernet/)
+        - default
+      custom-order: true
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

congestion_meta2/packet_number_indexed_queue.go

@@ -132,8 +132,6 @@ func (p *packetNumberIndexedQueue[T]) RemoveUpTo(packetNumber congestion.PacketN
 		p.firstPacket++
 	}
 	p.clearup()
-
-	return
 }
 
 // IsEmpty return if queue is empty.

congestion_meta2/windowed_filter.go

@@ -75,7 +75,7 @@ func MinFilter[O constraints.Ordered](a, b O) int {
 func NewWindowedFilter[V WindowedFilterValue, T WindowedFilterTime](windowLength T, comparator func(V, V) int) *WindowedFilter[V, T] {
 	return &WindowedFilter[V, T]{
 		windowLength: windowLength,
-		estimates:    make([]entry[V, T], 3, 3),
+		estimates:    make([]entry[V, T], 3),
 		comparator:   comparator,
 	}
 }
@@ -158,5 +158,5 @@ func (f *WindowedFilter[V, T]) Reset(newSample V, newTime T) {
 }
 
 func (f *WindowedFilter[V, T]) Clear() {
-	f.estimates = make([]entry[V, T], 3, 3)
+	f.estimates = make([]entry[V, T], 3)
 }

tuic/client.go

@@ -46,7 +46,7 @@ type Client struct {
 	zeroRTTHandshake  bool
 	heartbeat         time.Duration
 
-	connAccess sync.RWMutex
+	connAccess sync.Mutex
 	conn       *clientQUICConnection
 }