Buffer items missing in completion

[kuznetsss]

Hi, thanks for the amazing plugin!

I have an issue when buffer items don't appear in completion if language server is on. I'm not sure whether it is a bug or a misconfiguration on my side, so I decided to start with a discussion.

I would expect trace_layer to appear in completion items as a buffer item here:

But if I do :LspStop, trace_layer appears in completion items as expected.

I also tried to add completion.list.max_items = 1000000 to check whether there are too many items from language server, so buffer items got removed by the treshold, but it didn't help.

My blink.cmp config:

  completion = {
      documentation = {
        auto_show = true,
        auto_show_delay_ms = 500,
        window = {
          border = 'single',
          max_width = 80,
          max_height = 40,
        },
      },
      ghost_text = { enabled = true },
      list = {
        selection = function(ctx)
          return ctx.mode == 'cmdline' and 'auto_insert' or 'preselect'
        end,
        max_items = 1000000, -- adding this doesn't make any difference for the issue
      },
    },

    keymap = {
      preset = 'none',
      ['<C-space>'] = { 'show', 'show_documentation', 'hide_documentation' },
      ['<CR>'] = { 'accept', 'fallback' },
      ['<C-e>'] = { 'hide', 'fallback' },

      ['<C-n>'] = { 'select_next', 'fallback' },
      ['<C-p>'] = { 'select_prev', 'fallback' },

      ['<C-g>'] = { 'scroll_documentation_up', 'fallback' },
      ['<C-f>'] = { 'scroll_documentation_down', 'fallback' },

      ['<Tab>'] = { 'select_next', 'fallback' },
      ['<S-Tab>'] = { 'select_prev', 'fallback' },
    },

    snippets = {
      expand = function(snippet)
        require('luasnip').lsp_expand(snippet)
      end,
      active = function(filter)
        if filter and filter.direction then
          return require('luasnip').jumpable(filter.direction)
        end
        return require('luasnip').in_snippet()
      end,
      jump = function(direction)
        require('luasnip').jump(direction)
      end,
    },

    -- Default list of enabled providers defined so that you can extend it
    -- elsewhere in your config, without redefining it, due to `opts_extend`
    sources = {
      default = { 'lazydev', 'lsp', 'buffer', 'copilot', 'path', 'luasnip' },
      providers = {
        lazydev = {
          name = 'LazyDev',
          module = 'lazydev.integrations.blink',
          score_offset = 100,
        },
        copilot = {
          name = 'copilot',
          module = 'blink-cmp-copilot',
          score_offset = 100,
          async = true,
        },
      },
    }

[Saghen]

Hey! Set sources.providers.lsp.fallbacks = {}. By default, it only shows the buffer items when the lsp returns no items

[kuznetsss]

It helped, thank you!

How do you think maybe items from fallbacks should appear when only a few items from the current provider left? And in such case they could have score penalty for comming from a fallback.

Update:
I also adjusted score_offset for buffer provider and got the behaviour I wanted.

sources = {
  providers = {
    lsp = {
      fallbacks = {},
    },
    buffer = {
       score_offset = -10,
    },
  }
}