Accepting items in vtsls

[gonstoll]

I'm a bit unsure if this relates to some of the opened issues, specially #46 and #541. In order not to clutter the issues list, I rather ask around here.

I noticed today something funky with accepting items, specially around paths and the vtsls LSP server.

vtsls lets you define a importModuleSpecifier configuration to let the LSP figure out how to import modules. I haven't had any issues with nvim-cmp so far:

cmp-ext.mov

However, blink doesn't seem to respect this and just puts the .tsx extension in there:

blink-ext.mov

Moreover (and probably not just related to vtsls), accepting different sections of the path adds extra characters. For example, here with nvim-cmp, accepting the ui section of the path just completes with ui:

cmp-dir.mov

However, blink also puts an extra / at the end:

blink-dir.mov

Here's my blink config, in case there's something missing on my end:

return {
  'saghen/blink.cmp',
  version = 'v0.*',
  ---@module 'blink.cmp'
  ---@type blink.cmp.Config
  opts = {
    keymap = {
      preset = 'enter',
      ['<C-y>'] = {'show', 'show_documentation', 'hide_documentation'},
      ['<C-u>'] = {'scroll_documentation_up', 'fallback'},
      ['<C-d>'] = {'scroll_documentation_down', 'fallback'},
      cmdline = {
        preset = 'enter',
        ['<Tab>'] = {'select_next', 'fallback'},
        ['<S-Tab>'] = {'select_prev', 'fallback'},
      },
    },
    appearance = {
      nerd_font_variant = 'mono',
    },
    sources = {
      default = {'lsp', 'path', 'snippets', 'buffer', 'lazydev'},
      providers = {
        lazydev = {
          name = 'LazyDev',
          module = 'lazydev.integrations.blink',
          score_offset = 100, -- show at a higher priority than lsp
        },
        snippets = {
          name = 'Snippets',
          module = 'blink.cmp.sources.snippets',
          min_keyword_length = 3,
          opts = {
            friendly_snippets = false,
            search_paths = {vim.fn.stdpath('config') .. '/snippets/nvim'},
            global_snippets = {'all'},
            extended_filetypes = {},
            ignored_filetypes = {},
            get_filetype = function()
              return vim.bo.filetype
            end,
          },
        },
      },
    },
    signature = {enabled = true},
    completion = {
      trigger = {
        show_on_accept_on_trigger_character = false,
      },
      list = {
        selection = function(ctx)
          return ctx.mode == 'cmdline' and 'auto_insert' or 'manual'
        end,
      },
      menu = {
        draw = {
          treesitter = {'lsp'},
          columns = {
            {'label', gap = 2}, {'kind_icon', gap = 1, 'kind'},
          },
        },
      },
      documentation = {
        auto_show = true,
        auto_show_delay_ms = 200,
      },
    },
  },
  opts_extend = {'sources.default'},
}

[Saghen]

It sounds like you're using the built-in path source rather than vtsls in this case. You might want to disable it in typescript files with

sources.providers.path.enabled = function() 
  return not vim.tbl_contains({ 'typescript', 'typescriptreact', 'javascript', 'javascriptreact' }, vim.bo.filetype)
end

Thanks for reporting that the / isn't replaced, implemented that in d2b411c

[gonstoll]

For reference, this was my nvim-cmp setup:

return {
  'hrsh7th/nvim-cmp',
  event = 'VeryLazy',
  dependencies = {
    'hrsh7th/cmp-nvim-lsp',
    'hrsh7th/cmp-buffer',
    'hrsh7th/cmp-path',
    'hrsh7th/cmp-cmdline',
    'hrsh7th/cmp-calc',
    'hrsh7th/cmp-emoji',
    'garymjr/nvim-snippets',
  },
  config = function()
    local cmp = require('cmp')
    local lspkind = require('lspkind')
    local cmp_select_opts = {behavior = cmp.SelectBehavior.Select}

    cmp.setup({
      snippet = {
        expand = function(args)
          vim.snippet.expand(args.body)
        end,
      },
      preselect = cmp.PreselectMode.None,
      completion = {
        completeopt = 'menu,menuone,noinsert,noselect',
      },
      mapping = {
        ['<CR>'] = cmp.mapping.confirm({select = false, behavior = cmp.ConfirmBehavior.Insert}),
        ['<C-e>'] = cmp.mapping.abort(),
        ['<C-u>'] = cmp.mapping.scroll_docs(-4),
        ['<C-d>'] = cmp.mapping.scroll_docs(4),
        ['<Up>'] = cmp.mapping.select_prev_item(cmp_select_opts),
        ['<Down>'] = cmp.mapping.select_next_item(cmp_select_opts),
        ['<C-p>'] = cmp.mapping.select_prev_item(cmp_select_opts),
        ['<C-n>'] = cmp.mapping.select_next_item(cmp_select_opts),
        ['<C-y>'] = cmp.mapping.complete(),
      },
      sources = cmp.config.sources({
        {name = 'lazydev', group_index = 0},
        {name = 'nvim_lsp', keyword_length = 1},
        {
          name = 'snippets',
          entry_filter = function()
            local ctx = require('cmp.config.context')
            local in_string = ctx.in_syntax_group('String') or ctx.in_treesitter_capture('string')
            local in_comment = ctx.in_syntax_group('Comment') or ctx.in_treesitter_capture('comment')
            return not in_string and not in_comment
          end,
        },
      }, {
        {name = 'buffer', keyword_length = 3},
        {name = 'emoji'},
        {name = 'calc'},
        {name = 'path'},
      }),
      formatting = {
        format = lspkind.cmp_format({
          mode = 'symbol_text',
        }),
      },
    })

    cmp.setup.cmdline({'/', '?'}, {
      mapping = cmp.mapping.preset.cmdline(),
      sources = {
        {name = 'buffer'},
      },
    })

    cmp.setup.cmdline(':', {
      mapping = cmp.mapping.preset.cmdline(),
      sources = cmp.config.sources({
        {name = 'path'},
      }, {
        {name = 'cmdline'},
      }),
    })
  end,
}

What feels strange to me is that I didn't need to disable the path source, as the completions were rather coming from the lsp source 🤔

[gonstoll]

@Saghen should I convert this into an issue for proper tracking? 🤔

My initial intention was to not add up to the issues list, but at this point I think there might be a bug going around.

[Saghen]

Aha it looks like in your configuration, you were falling back to the path source when LSP returned no items. You can replicate this with sources.providers.lsp.fallbacks = { 'buffer', 'path' }. It might be worth making this the default so feel free to open an issue about that

[gonstoll]

Huh, that doesn't seem to do the trick either 😔 it seems that the path provider doesn't offer suggestions when there's any existing text in front of it

import foo from './|/'
//                 ^ Cursor is here, and completion window doesn't suggest anything

Here, / can be anything. If I have a r, u, or any character, it won't even suggest things.

import foo from './|'
//                 ^ Cursor is here, and suggestions appear on the completion window

Previous cmp experience:

import foo from './|/'
//                 ^ Cursor is here, and suggestions appear on the completion window

This again is the case with / or any other character. It would suggest, and upon accepting completing in front of the following character.

Demo

nvim-cmp

Screen.Recording.2025-01-08.at.09.46.29.mov

blink.cmp

Screen.Recording.2025-01-08.at.09.48.08.mov

(That fuzzy search at the start is 😗👌)

[gonstoll]

Opened a issue here #959