DTO constructor

[yookky]

Hi!
Is it good idea to use constructor inside response dto to create response just like new UserResponseDto(entity)?

export class UserResponseDto extends ResponseBase {
  @ApiProperty({
    example: '[email protected]',
    description: "User's email address",
  })
  email: string;

  .....

  constructor(entity: UserModel) {
    super(entity);
    Object.assign(this, entity);
  }
}

as an addition feature we can combine this with class-transformer and Exclude/Expose decorators inside dto

[Sairyss]

This way you make your DTOs depend on the entity.
I would do it like this instead:

export class UserResponseDto extends ResponseBase {
  @ApiProperty({
    example: '[email protected]',
    description: "User's email address",
  })
  email: string;

  .....

  constructor(props: UserResponseDto) { // <- self reference
    super(props);
    Object.assign(this, props);
  }
}

And if you pass an entity to this constructor, you should whitelist properties using class-transformer, or assign them manually to avoid leaking data with Object.assign(this,props)

[yookky]

Ty for explanation, ill try to work with it throught class-transformer)