Merge pull request RealDevSquad#155 from Real-Dev-Squad/fixing/auto-fetch-overdue

Fixing auto fetch over due tasks

Author: fakhruddinkw

src/handlers/scheduledEventHandler.ts

@@ -29,13 +29,6 @@ export async function send(env: env): Promise<void> {
       }
     });
 
-    if (
-      assigneeIds === error.INTERNAL_SERVER_ERROR ||
-      discordIds === error.INTERNAL_SERVER_ERROR
-    ) {
-      throw new Error(error.INTERNAL_SERVER_ERROR);
-    }
-
     const bodyObj = {
       content: stringToBeSent,
     };

src/utils/getDiscordIds.ts

@@ -4,7 +4,7 @@ import * as response from "../constants/responses";
 
 export const getDiscordIds = async (
   userIds: string[] | string
-): Promise<string[] | string> => {
+): Promise<string[]> => {
   try {
     const url = `${RDS_BASE_API_URL}/users/userId`;
 
@@ -65,6 +65,7 @@ export const getDiscordIds = async (
 
     return discordIds;
   } catch (e) {
-    return response.INTERNAL_SERVER_ERROR;
+    console.log(e);
+    throw e;
   }
 };

src/utils/taskOverDueDiscordMembers.ts

@@ -20,6 +20,7 @@ export const taskOverDueDiscordMembers = async (): Promise<
 
     return assigneeIds;
   } catch (e) {
-    return errors.INTERNAL_SERVER_ERROR;
+    console.log(e);
+    throw e;
   }
 };

tests/unit/utils/getDiscordIds.test.ts

@@ -39,11 +39,11 @@ describe("getDiscordIds()", () => {
       .spyOn(global, "fetch")
       .mockRejectedValueOnce(new Error("Network error"));
 
-    const result = await getDiscordIds([userBackendMock.user.id]);
-
-    expect(result).toEqual(
-      "Oops! We have encountered an internal Server Error"
-    );
+    try {
+      await getDiscordIds([userBackendMock.user.id]);
+    } catch (error: any) {
+      expect(error.message).toEqual("Network error");
+    }
 
     expect(global.fetch).toHaveBeenCalledWith(
       `${RDS_BASE_API_URL}/users/userId/${userBackendMock.user.id}`

tests/unit/utils/taskOverDueDiscordMembers.test.ts

@@ -27,11 +27,11 @@ describe("taskOverDueDiscordMembers()", () => {
       .spyOn(global, "fetch")
       .mockRejectedValueOnce(new Error("Network error"));
 
-    const result = await taskOverDueDiscordMembers();
-
-    expect(result).toEqual(
-      "Oops! We have encountered an internal Server Error"
-    );
+    try {
+      await taskOverDueDiscordMembers();
+    } catch (error: any) {
+      expect(error.message).toEqual("Network error");
+    }
 
     expect(global.fetch).toHaveBeenCalledWith(
       `${RDS_BASE_API_URL}/tasks?dev=true&status=overdue&size=100`