Fix test isolation, fast polling, and cleanup of command tests (#51)

* Fix test isolation, fast polling, and cleanup low-value command tests

Test Isolation:
- Add `credentialsFile` parameter to ResolveConfigOptions and LoadConfigOptions
- Update MobifySource to use credentialsFile when provided (overrides ~/.mobify)
- Add --credentials-file flag with MRT_CREDENTIALS_FILE env var to MrtCommand
- Add config-isolation.ts helper to clear SFCC_*/MRT_* env vars for tests

Fast Polling Tests:
- Use short pollInterval for site-archive tests instead of default 3000ms
- Tests now complete in milliseconds instead of seconds

Command Test Cleanup:
- Delete cartridge-command.test.ts (100% trivial delegation tests)
- Simplify base-command.test.ts (keep getExtraParams, catch tests)
- Simplify instance-command.test.ts (keep requireX, context tests)
- Simplify mrt-command.test.ts (keep requireMrtCredentials only)
- Simplify oauth-command.test.ts (keep parseAuthMethods, requireOAuthCredentials)
- Simplify ods-command.test.ts (keep odsClient lazy init tests)

Documentation:
- Update testing skill with config isolation, pollInterval patterns
- Add command test guidelines (what to test vs avoid)
- Remove general knowledge content (basic Mocha/Chai patterns)

* update lockfile

* Remove upward search from dw.json loading, complete test isolation

- Change loadDwJson() default to look only at ./dw.json (no parent search)
- Update DwJsonSource to use same logic, remove findDwJson import
- Keep findDwJson() exported for users who need explicit upward search
- Set SFCC_CONFIG=/dev/null and MRT_CREDENTIALS_FILE=/dev/null in isolateConfig()
- Update test to verify new behavior (no upward search)

* Wire up isolateConfig to SDK command tests

Add isolateConfig()/restoreConfig() to command test files to ensure
tests are isolated from developer's environment variables (SFCC_*, MRT_*).

Files updated:
- test/cli/base-command.test.ts
- test/cli/instance-command.test.ts
- test/cli/mrt-command.test.ts
- test/cli/oauth-command.test.ts
- test/cli/ods-command.test.ts

* timing issues in tests; don't sleep is poll is 0

* initial wait from poll interval

* Improve command test patterns with Sinon and integration tests

- Add sinon, @types/sinon, @oclif/test as SDK dev dependencies
- Create stubParse helper for cleaner parse method mocking
- Refactor 5 command test files to use Sinon instead of manual mocking
- Add test fixture (test/fixtures/test-cli/) for integration testing
- Add base-command.integration.test.ts with runCommand() tests
- Update testing skill docs with new patterns

The stubParse helper eliminates the brittle MockableXxxCommand type
casting pattern. Integration tests exercise full command lifecycle
through the oclif test utilities.

* Restore CartridgeCommand unit tests with improved coverage

- Add cartridge-command.test.ts with tests for cartridgePath,
  cartridgeOptions, provider runner init, and findCartridgesWithProviders
- Use stubParse helper with server mock for instance-dependent tests
- Improves cartridge-command.ts coverage from 19% to 91%

* Add InstanceCommand and MrtCommand integration tests

Integration tests provide API contract validation beyond code coverage:
- Catch flag definition errors (wrong type, missing env var)
- Validate baseFlags inheritance works correctly
- Exercise full oclif command lifecycle (discovery, parse, init, run)
- Test commands the way consumers actually use them

New fixtures:
- test-instance.js: Tests server, instance flags and hasServer check
- test-mrt.js: Tests api-key, project, environment, cloud-origin flags

New integration tests:
- instance-command.integration.test.ts (5 tests)
- mrt-command.integration.test.ts (8 tests)

Total integration tests: 18 (BaseCommand + InstanceCommand + MrtCommand)

* prettier updates

Author: clavery

.claude/skills/testing/SKILL.md

@@ -254,7 +254,7 @@ export default class OdsCreate extends OdsCommand<typeof OdsCreate> {
     this.log(t('commands.ods.create.waiting', 'Waiting for sandbox to be ready...'));
 
     // Initial delay before first poll to allow the sandbox to be registered in the API
-    await this.sleep(2000);
+    await this.sleep(pollIntervalMs);
 
     while (true) {
       // Check for timeout

packages/b2c-cli/src/commands/ods/create.ts

@@ -1,12 +1,7 @@
 {
   "all": true,
   "src": ["src"],
-  "exclude": [
-    "src/clients/*.generated.ts",
-    "test/**",
-    "**/*.d.ts",
-    "src/**/*types.ts"
-  ],
+  "exclude": ["src/clients/*.generated.ts", "test/**", "**/*.d.ts", "src/**/*types.ts"],
   "reporter": ["text", "text-summary", "html", "lcov"],
   "report-dir": "coverage",
   "check-coverage": true,

packages/b2c-tooling-sdk/.c8rc.json

@@ -1 +1,5 @@
 *.generated.ts
+dist
+coverage
+data
+specs

packages/b2c-tooling-sdk/.prettierignore

@@ -20,7 +20,7 @@ npm install @salesforce/b2c-tooling-sdk
 Use `resolveConfig()` to load configuration from project files (dw.json) and create a B2C instance:
 
 ```typescript
-import { resolveConfig } from '@salesforce/b2c-tooling-sdk/config';
+import {resolveConfig} from '@salesforce/b2c-tooling-sdk/config';
 
 // Load configuration, override secrets from environment
 const config = resolveConfig({
@@ -36,8 +36,8 @@ await instance.webdav.mkcol('Cartridges/v1');
 await instance.webdav.put('Cartridges/v1/app.zip', zipBuffer);
 
 // Use typed OCAPI client (openapi-fetch)
-const { data, error } = await instance.ocapi.GET('/sites', {
-  params: { query: { select: '(**)' } },
+const {data, error} = await instance.ocapi.GET('/sites', {
+  params: {query: {select: '(**)'}},
 });
 ```
 
@@ -46,16 +46,16 @@ const { data, error } = await instance.ocapi.GET('/sites', {
 For advanced use cases, you can construct a B2CInstance directly:
 
 ```typescript
-import { B2CInstance } from '@salesforce/b2c-tooling-sdk';
+import {B2CInstance} from '@salesforce/b2c-tooling-sdk';
 
 const instance = new B2CInstance(
-  { hostname: 'your-sandbox.demandware.net', codeVersion: 'v1' },
+  {hostname: 'your-sandbox.demandware.net', codeVersion: 'v1'},
   {
     oauth: {
       clientId: 'your-client-id',
-      clientSecret: 'your-client-secret'
-    }
-  }
+      clientSecret: 'your-client-secret',
+    },
+  },
 );
 ```
 
@@ -89,24 +89,24 @@ The OCAPI client uses [openapi-fetch](https://openapi-ts.dev/openapi-fetch/) wit
 
 ```typescript
 // List sites
-const { data, error } = await instance.ocapi.GET('/sites', {
-  params: { query: { select: '(**)' } },
+const {data, error} = await instance.ocapi.GET('/sites', {
+  params: {query: {select: '(**)'}},
 });
 
 // Activate a code version
-const { data, error } = await instance.ocapi.PATCH('/code_versions/{code_version_id}', {
-  params: { path: { code_version_id: 'v1' } },
-  body: { active: true },
+const {data, error} = await instance.ocapi.PATCH('/code_versions/{code_version_id}', {
+  params: {path: {code_version_id: 'v1'}},
+  body: {active: true},
 });
 ```
 
 ### Code Deployment
 
 ```typescript
-import { findAndDeployCartridges, activateCodeVersion } from '@salesforce/b2c-tooling-sdk/operations/code';
+import {findAndDeployCartridges, activateCodeVersion} from '@salesforce/b2c-tooling-sdk/operations/code';
 
 // Deploy cartridges
-await findAndDeployCartridges(instance, './cartridges', { reload: true });
+await findAndDeployCartridges(instance, './cartridges', {reload: true});
 
 // Activate code version
 await activateCodeVersion(instance, 'v1');
@@ -115,7 +115,7 @@ await activateCodeVersion(instance, 'v1');
 ### Job Execution
 
 ```typescript
-import { executeJob, waitForJob, siteArchiveImport } from '@salesforce/b2c-tooling-sdk/operations/jobs';
+import {executeJob, waitForJob, siteArchiveImport} from '@salesforce/b2c-tooling-sdk/operations/jobs';
 
 // Run a job and wait for completion
 const execution = await executeJob(instance, 'my-job-id');
@@ -129,32 +129,32 @@ await siteArchiveImport(instance, './site-data.zip');
 
 The SDK provides subpath exports for tree-shaking and organization:
 
-| Export | Description |
-|--------|-------------|
-| `@salesforce/b2c-tooling-sdk` | Main entry point with all exports |
-| `@salesforce/b2c-tooling-sdk/config` | Configuration resolution (resolveConfig) |
-| `@salesforce/b2c-tooling-sdk/auth` | Authentication strategies (OAuth, Basic, API Key) |
-| `@salesforce/b2c-tooling-sdk/instance` | B2CInstance class |
-| `@salesforce/b2c-tooling-sdk/clients` | Low-level API clients (WebDAV, OCAPI, SLAS, ODS, MRT) |
-| `@salesforce/b2c-tooling-sdk/operations/code` | Code deployment operations |
-| `@salesforce/b2c-tooling-sdk/operations/jobs` | Job execution and site import/export |
-| `@salesforce/b2c-tooling-sdk/operations/sites` | Site management |
-| `@salesforce/b2c-tooling-sdk/discovery` | Workspace type detection (PWA Kit, SFRA, etc.) |
-| `@salesforce/b2c-tooling-sdk/cli` | CLI utilities (BaseCommand, table rendering) |
-| `@salesforce/b2c-tooling-sdk/logging` | Structured logging utilities |
+| Export                                         | Description                                           |
+| ---------------------------------------------- | ----------------------------------------------------- |
+| `@salesforce/b2c-tooling-sdk`                  | Main entry point with all exports                     |
+| `@salesforce/b2c-tooling-sdk/config`           | Configuration resolution (resolveConfig)              |
+| `@salesforce/b2c-tooling-sdk/auth`             | Authentication strategies (OAuth, Basic, API Key)     |
+| `@salesforce/b2c-tooling-sdk/instance`         | B2CInstance class                                     |
+| `@salesforce/b2c-tooling-sdk/clients`          | Low-level API clients (WebDAV, OCAPI, SLAS, ODS, MRT) |
+| `@salesforce/b2c-tooling-sdk/operations/code`  | Code deployment operations                            |
+| `@salesforce/b2c-tooling-sdk/operations/jobs`  | Job execution and site import/export                  |
+| `@salesforce/b2c-tooling-sdk/operations/sites` | Site management                                       |
+| `@salesforce/b2c-tooling-sdk/discovery`        | Workspace type detection (PWA Kit, SFRA, etc.)        |
+| `@salesforce/b2c-tooling-sdk/cli`              | CLI utilities (BaseCommand, table rendering)          |
+| `@salesforce/b2c-tooling-sdk/logging`          | Structured logging utilities                          |
 
 ## Logging
 
 Configure logging for debugging HTTP requests:
 
 ```typescript
-import { configureLogger } from '@salesforce/b2c-tooling-sdk/logging';
+import {configureLogger} from '@salesforce/b2c-tooling-sdk/logging';
 
 // Enable debug logging (shows HTTP request summaries)
-configureLogger({ level: 'debug' });
+configureLogger({level: 'debug'});
 
 // Enable trace logging (shows full request/response with headers and bodies)
-configureLogger({ level: 'trace' });
+configureLogger({level: 'trace'});
 ```
 
 ## Documentation

packages/b2c-tooling-sdk/README.md

@@ -195,8 +195,8 @@
     "build:cjs": "tsc -p tsconfig.cjs.json && echo '{\"type\":\"commonjs\"}' > dist/cjs/package.json",
     "clean": "shx rm -rf dist",
     "lint": "eslint",
-    "format": "prettier --write src scripts",
-    "format:check": "prettier --check src scripts",
+    "format": "prettier --write .",
+    "format:check": "prettier --check .",
     "pretest": "tsc --noEmit -p test",
     "test": "c8 mocha --forbid-only \"test/**/*.test.ts\"",
     "test:ci": "c8 mocha --forbid-only --reporter json --reporter-option output=test-results.json \"test/**/*.test.ts\"",
@@ -210,12 +210,14 @@
     "@eslint/compat": "^1",
     "@oclif/core": "^4",
     "@oclif/prettier-config": "^0.2.1",
+    "@oclif/test": "^4.1.14",
     "@salesforce/dev-config": "^4.3.2",
     "@tony.ganchev/eslint-plugin-header": "^3.1.11",
     "@types/archiver": "^7.0.0",
     "@types/chai": "^4.3.20",
     "@types/mocha": "^10.0.10",
     "@types/node": "^18.19.130",
+    "@types/sinon": "^21.0.0",
     "@types/xml2js": "^0.4.14",
     "c8": "^10.1.3",
     "chai": "^4.5.0",
@@ -227,6 +229,7 @@
     "openapi-typescript": "^7.10.1",
     "prettier": "^3.6.2",
     "shx": "^0.3.3",
+    "sinon": "^21.0.1",
     "tsx": "^4.20.6",
     "typescript": "^5",
     "typescript-eslint": "^8"
@@ -244,9 +247,9 @@
   },
   "dependencies": {
     "archiver": "^7.0.1",
-    "fuse.js": "^7.0.0",
     "chokidar": "^5.0.0",
     "cliui": "^9.0.1",
+    "fuse.js": "^7.0.0",
     "glob": "^13.0.0",
     "i18next": "^25.6.3",
     "jszip": "^3.10.1",

packages/b2c-tooling-sdk/package.json

@@ -44,6 +44,8 @@ export interface LoadConfigOptions {
   configPath?: string;
   /** Cloud origin for MRT ~/.mobify lookup (e.g., https://cloud-staging.mobify.com) */
   cloudOrigin?: string;
+  /** Path to custom MRT credentials file (overrides default ~/.mobify) */
+  credentialsFile?: string;
 }
 
 /**
@@ -110,6 +112,7 @@ export function loadConfig(
     configPath: options.configPath,
     hostnameProtection: true,
     cloudOrigin: options.cloudOrigin,
+    credentialsFile: options.credentialsFile,
     sourcesBefore: pluginSources.before,
     sourcesAfter: pluginSources.after,
   });

packages/b2c-tooling-sdk/src/cli/config.ts

@@ -55,15 +55,21 @@ export abstract class MrtCommand<T extends typeof Command> extends BaseCommand<T
       description: `MRT cloud origin URL (default: ${DEFAULT_MRT_ORIGIN})`,
       env: 'SFCC_MRT_CLOUD_ORIGIN',
     }),
+    'credentials-file': Flags.string({
+      description: 'Path to MRT credentials file (overrides default ~/.mobify)',
+      env: 'MRT_CREDENTIALS_FILE',
+    }),
   };
 
   protected override loadConfiguration(): ResolvedConfig {
     const cloudOrigin = this.flags['cloud-origin'] as string | undefined;
+    const credentialsFile = this.flags['credentials-file'] as string | undefined;
 
     const options: LoadConfigOptions = {
       instance: this.flags.instance,
       configPath: this.flags.config,
       cloudOrigin, // MobifySource uses this to load ~/.mobify--[hostname] if set
+      credentialsFile, // Override path to MRT credentials file
     };
 
     const flagConfig: Partial<ResolvedConfig> = {

packages/b2c-tooling-sdk/src/cli/mrt-command.ts

@@ -149,26 +149,32 @@ function selectConfig(json: DwJsonMultiConfig, instanceName?: string): DwJsonCon
 /**
  * Loads configuration from a dw.json file.
  *
- * Searches upward from the current directory (or specified startDir) for a dw.json file.
- * Supports both single-config and multi-config formats.
+ * If an explicit path is provided, uses that file. Otherwise, looks for dw.json
+ * in the startDir (or cwd). Does NOT search parent directories.
+ *
+ * Use `findDwJson()` if you need to search upward through parent directories.
  *
  * @param options - Loading options
  * @returns The parsed config, or undefined if no dw.json found
  *
  * @example
- * // Auto-find dw.json
+ * // Load from ./dw.json (current directory)
  * const config = loadDwJson();
  *
+ * // Load from specific directory
+ * const config = loadDwJson({ startDir: '/path/to/project' });
+ *
  * // Use named instance
  * const config = loadDwJson({ instance: 'staging' });
  *
  * // Explicit path
  * const config = loadDwJson({ path: './config/dw.json' });
  */
 export function loadDwJson(options: LoadDwJsonOptions = {}): DwJsonConfig | undefined {
-  const dwJsonPath = options.path || findDwJson(options.startDir);
+  // If explicit path provided, use it. Otherwise default to ./dw.json (no upward search)
+  const dwJsonPath = options.path ?? path.join(options.startDir || process.cwd(), 'dw.json');
 
-  if (!dwJsonPath || !fs.existsSync(dwJsonPath)) {
+  if (!fs.existsSync(dwJsonPath)) {
     return undefined;
   }
 

packages/b2c-tooling-sdk/src/config/dw-json.ts

@@ -8,7 +8,8 @@
  *
  * @internal This module is internal to the SDK. Use ConfigResolver instead.
  */
-import {loadDwJson, findDwJson} from '../dw-json.js';
+import * as path from 'node:path';
+import {loadDwJson} from '../dw-json.js';
 import {mapDwJsonToNormalizedConfig} from '../mapping.js';
 import type {ConfigSource, NormalizedConfig, ResolveConfigOptions} from '../types.js';
 
@@ -33,8 +34,8 @@ export class DwJsonSource implements ConfigSource {
       return undefined;
     }
 
-    // Track the path for diagnostics
-    this.lastPath = options.configPath || findDwJson(options.startDir);
+    // Track the path for diagnostics - use explicit path or default location
+    this.lastPath = options.configPath ?? path.join(options.startDir || process.cwd(), 'dw.json');
 
     return mapDwJsonToNormalizedConfig(dwConfig);
   }