Remove B2CInstance.fromEnvironment() in favor of resolveConfig() #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fromEnvironment() method had no runtime usages - only documentation examples. This change: - Removes FromEnvironmentOptions interface and fromEnvironment() static method - Updates all JSDoc examples to use resolveConfig() pattern - Restructures docs/api-readme.md to document the unified config system - Adds Configuration Resolution section covering multi-source loading, validation helpers, warnings, and hostname protection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following PR #30 (Unified Configuration System), this PR removes the unused
B2CInstance.fromEnvironment()method and updates all documentation to use the newresolveConfig()pattern.FromEnvironmentOptionsinterface andfromEnvironment()static method (had zero runtime usages)resolveConfig()patterndocs/api-readme.mdwith comprehensive documentation for the unified config system@salesforce/b2c-tooling-sdk/configto SDK README exports tableThe
resolveConfig()API provides better validation, warnings, and multi-source configuration loading compared to the removed method.